All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v2 07/27] mm/damon/sysfs: implement report producer directory
Date: Tue, 17 Nov 2026 18:22:02 -0800	[thread overview]
Message-ID: <20261118022225.100659-8-sj@kernel.org> (raw)
In-Reply-To: <20261118022225.100659-1-sj@kernel.org>

Implement a sysfs directory for each report producer.  Create and remove
the directories for reports/producers/nr_producers file writes.  It is a
placeholder for sysfs files that will be used for controlling each
report producer.

Signed-off-by: SJ Park <sj@kernel.org>
---
 mm/damon/sysfs.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 70 insertions(+), 1 deletion(-)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index d3a7cb170975a..7c6bc30c12125 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2979,10 +2979,40 @@ static const struct kobj_type damon_sysfs_kdamonds_ktype = {
 	.default_groups = damon_sysfs_kdamonds_groups,
 };
 
+/* producer dir */
+
+struct damon_sysfs_producer {
+	struct kobject kobj;
+};
+
+static struct damon_sysfs_producer *damon_sysfs_producer_alloc(void)
+{
+	return kzalloc_obj(struct damon_sysfs_producer);
+}
+
+static void damon_sysfs_producer_release(struct kobject *kobj)
+{
+	struct damon_sysfs_producer *producer = container_of(kobj,
+			struct damon_sysfs_producer, kobj);
+	kfree(producer);
+}
+
+static struct attribute *damon_sysfs_producer_attrs[] = {
+	NULL,
+};
+ATTRIBUTE_GROUPS(damon_sysfs_producer);
+
+static const struct kobj_type damon_sysfs_producer_ktype = {
+	.release = damon_sysfs_producer_release,
+	.sysfs_ops = &kobj_sysfs_ops,
+	.default_groups = damon_sysfs_producer_groups,
+};
+
 /* producers dir */
 
 struct damon_sysfs_producers {
 	struct kobject kobj;
+	struct damon_sysfs_producer **producers_arr;
 	int nr;
 };
 
@@ -2994,14 +3024,53 @@ static struct damon_sysfs_producers *damon_sysfs_producers_alloc(void)
 static void damon_sysfs_producers_rm_dirs(
 		struct damon_sysfs_producers *producers)
 {
+	struct damon_sysfs_producer **producers_arr = producers->producers_arr;
+	int i;
+
+	for (i = 0; i < producers->nr; i++) {
+		kobject_del(&producers_arr[i]->kobj);
+		kobject_put(&producers_arr[i]->kobj);
+	}
 	producers->nr = 0;
+	kfree(producers_arr);
+	producers->producers_arr = NULL;
 }
 
 static int damon_sysfs_producers_add_dirs(
 		struct damon_sysfs_producers *producers, int nr_producers)
 {
+	struct damon_sysfs_producer **producers_arr, *producer;
+	int err, i;
+
 	damon_sysfs_producers_rm_dirs(producers);
-	producers->nr = nr_producers;
+	if (!nr_producers)
+		return 0;
+
+	producers_arr = kmalloc_objs(*producers_arr, nr_producers,
+			GFP_KERNEL | __GFP_NOWARN);
+	if (!producers_arr)
+		return -ENOMEM;
+	producers->producers_arr = producers_arr;
+
+	for (i = 0; i < nr_producers; i++) {
+		producer = damon_sysfs_producer_alloc();
+		if (!producer) {
+			damon_sysfs_producers_rm_dirs(producers);
+			return -ENOMEM;
+		}
+
+		err = kobject_init_and_add(&producer->kobj,
+				&damon_sysfs_producer_ktype, &producers->kobj,
+				"%d", i);
+		if (err) {
+			kobject_put(&producer->kobj);
+			damon_sysfs_producers_rm_dirs(producers);
+			return err;
+		}
+
+		producers_arr[i] = producer;
+		producers->nr++;
+	}
 	return 0;
 }
 
-- 
2.47.3

  parent reply	other threads:[~2026-11-18  2:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  2:21 [RFC PATCH v2 00/27] mm/damon: let users report their data attribute findings SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 01/27] mm/damon/api: introduce struct damon_report SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 02/27] mm/damon/core: implement data attribute report queue SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 03/27] mm/damon/core: introduce damon_submit_report() SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 04/27] mm/damon/sysfs: add admin/reports/ directory SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 05/27] mm/damon/sysfs: add reports/producers/ directory SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 06/27] mm/damon/sysfs: add producers/nr_producers file SJ Park
2026-11-18  2:22 ` SJ Park [this message]
2026-11-18  2:22 ` [RFC PATCH v2 08/27] mm/damon/sysfs: implement report producer type and state files SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 09/27] Docs/mm/damon/design: update for report system SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 10/27] Docs/admin-guide/mm/damon/usage: update for report producer sysfs SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 11/27] Docs/ABI/damon: update for report producer sysfs files SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 12/27] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 13/27] mm/damon/core: introduce damon_report_exist() SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 14/27] mm/damon/paddr: support REPORT_MADE type probe filter SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 15/27] mm/damon/sysfs: add filter_report_type file under probe filter directory SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 16/27] mm/damon/sysfs: support REPORT_MADE type probe filter setup SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 17/27] Docs/mm/damon/design: update for report_made probe filter type SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 18/27] Docs/admin-guide/mm/damon/usage: update for REPORT_MADE probe filter SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 19/27] Docs/ABI/damon: " SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 20/27] mm/damon/api: introduce user_report report type SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 21/27] mm/damon/sysfs: add user_report support for report type input SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 22/27] mm/damon/sysfs: implement report producer addr_{start,end} files SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 23/27] mm/damon/sysfs: implement submit command for report producer SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 24/27] selftests/damon/sysfs.sh: add basic tests for admin/reports/ SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 25/27] Docs/mm/damon/design: update for user report support SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 26/27] Docs/admin-guide/mm/damon/usage: update for user_report " SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 27/27] Docs/ABI/damon: " SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118022225.100659-8-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.