All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: badal.nilawar@intel.com, sk.anirban@intel.com,
	Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>,
	Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
Subject: [PATCH 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs
Date: Wed, 18 Nov 2026 11:52:58 +0530	[thread overview]
Message-ID: <20261118062301.4135537-3-naresh.kumar.g@intel.com> (raw)
In-Reply-To: <20261118062301.4135537-1-naresh.kumar.g@intel.com>

From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

Expose the maximum achievable memory frequency and bandwidth reported
by PCODE MEMORY_CONFIG as read-only tile#/memory/max_freq (MHz) and
tile#/memory/max_bw_Mbps (Mbps) on Crescent Island.

These are capability limits, not the current memory frequency or
bandwidth usage. The existing PVC memory/freq0 entries are unchanged.

Document both attributes in the Xe sysfs ABI.

Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
---
 .../ABI/testing/sysfs-driver-intel-xe-gpu     | 24 ++++++
 drivers/gpu/drm/xe/xe_vram_config.c           | 85 ++++++++++++++++++-
 2 files changed, 105 insertions(+), 4 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu b/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
index 4dc4afc3961d..45a140af965e 100644
--- a/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
+++ b/Documentation/ABI/testing/sysfs-driver-intel-xe-gpu
@@ -8,3 +8,27 @@ Description:
 
 		This sysfs file is present only on supported Intel Xe platforms.
 		Accessible only to users with administrative privileges.
+
+What:		/sys/bus/pci/drivers/xe/.../tile<N>/memory/max_bw
+Date:		October 2026
+KernelVersion:	7.4
+Contact:	intel-xe@lists.freedesktop.org
+Description:
+		RO. Maximum achievable memory bandwidth reported by firmware, in
+		megabits per second (Mbps), as a decimal integer.
+		This is not a measurement of current memory bandwidth usage.
+
+		This sysfs file is present only on Crescent Island devices.
+		It is readable by all users.
+
+What:		/sys/bus/pci/drivers/xe/.../tile<N>/memory/max_freq
+Date:		October 2026
+KernelVersion:	7.4
+Contact:	intel-xe@lists.freedesktop.org
+Description:
+		RO. Maximum achievable memory frequency reported by firmware,
+		in MHz, as a decimal integer.
+		This is not the current memory frequency.
+
+		This sysfs file is present only on Crescent Island devices.
+		It is readable by all users.
diff --git a/drivers/gpu/drm/xe/xe_vram_config.c b/drivers/gpu/drm/xe/xe_vram_config.c
index 31a3405c39ab..4b8661b8597a 100644
--- a/drivers/gpu/drm/xe/xe_vram_config.c
+++ b/drivers/gpu/drm/xe/xe_vram_config.c
@@ -8,13 +8,14 @@
 #include "xe_device_types.h"
 #include "xe_pcode.h"
 #include "xe_pcode_api.h"
+#include "xe_pm.h"
 #include "xe_tile_sysfs.h"
 #include "xe_vram_config.h"
 
 /**
  * DOC: Xe VRAM config
  *
- * Provides sysfs entries for vram frequency in tile
+ * Provides sysfs entries for vram frequency and bandwidth in tile
  *
  * device/tile#/memory/freq0/max_freq - This is maximum frequency. This value is read-only as it
  *					is the fixed fuse point P0. It is not the system
@@ -22,6 +23,11 @@
  * device/tile#/memory/freq0/min_freq - This is minimum frequency. This value is read-only as it
  *					is the fixed fuse point PN. It is not the system
  *					configuration.
+ *
+ * On Crescent Island, the following entries are provided instead:
+ *
+ * device/tile#/memory/max_freq - Maximum achievable memory frequency in MHz. Read-only.
+ * device/tile#/memory/max_bw - Maximum achievable memory bandwidth in Mbps. Read-only.
  */
 
 static struct xe_tile *dev_to_tile(struct device *dev)
@@ -84,11 +90,81 @@ static const struct attribute_group freq_group_attrs = {
 	.attrs = freq_attrs,
 };
 
+static const struct attribute_group *pvc_memory_groups[] = {
+	&freq_group_attrs,
+	NULL
+};
+
+static int memory_config_read(struct device *dev, u32 subcmd, u32 *val)
+{
+	struct xe_tile *tile = dev_to_tile(dev);
+
+	guard(xe_pm_runtime)(tile_to_xe(tile));
+
+	return xe_pcode_read(tile, PCODE_MBOX(PCODE_MEMORY_CONFIG, subcmd, 0),
+			     val, NULL);
+}
+
+static ssize_t cri_max_freq_show(struct device *dev, struct device_attribute *attr,
+				 char *buf)
+{
+	u32 val = 0;
+	int err;
+
+	err = memory_config_read(dev, MEMORY_CONFIG_SUBCOMMAND_READ_MAX_FREQUENCY, &val);
+	if (err)
+		return err;
+
+	return sysfs_emit(buf, "%u\n", val);
+}
+
+static struct device_attribute dev_attr_cri_max_freq =
+	__ATTR(max_freq, 0444, cri_max_freq_show, NULL);
+
+static ssize_t max_bw_show(struct device *dev, struct device_attribute *attr,
+			   char *buf)
+{
+	u32 val = 0;
+	int err;
+
+	err = memory_config_read(dev, MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH, &val);
+	if (err)
+		return err;
+
+	return sysfs_emit(buf, "%u\n", val);
+}
+static DEVICE_ATTR_RO(max_bw);
+
+static struct attribute *cri_memory_attrs[] = {
+	&dev_attr_cri_max_freq.attr,
+	&dev_attr_max_bw.attr,
+	NULL
+};
+
+static const struct attribute_group cri_memory_group_attrs = {
+	.attrs = cri_memory_attrs,
+};
+
+static const struct attribute_group *cri_memory_groups[] = {
+	&cri_memory_group_attrs,
+	NULL
+};
+
+static const struct attribute_group **memory_groups(struct xe_device *xe)
+{
+	if (xe->info.platform == XE_PVC)
+		return pvc_memory_groups;
+	if (xe->info.platform == XE_CRESCENTISLAND)
+		return cri_memory_groups;
+	return NULL;
+}
+
 static void vram_freq_sysfs_fini(void *arg)
 {
 	struct kobject *kobj = arg;
+	struct xe_tile *tile = kobj_to_tile(kobj->parent);
 
-	sysfs_remove_group(kobj, &freq_group_attrs);
+	sysfs_remove_groups(kobj, memory_groups(tile_to_xe(tile)));
 	kobject_put(kobj);
 }
 
@@ -103,17 +179,18 @@ static void vram_freq_sysfs_fini(void *arg)
 int xe_vram_config_sysfs_init(struct xe_tile *tile)
 {
 	struct xe_device *xe = tile_to_xe(tile);
+	const struct attribute_group **groups = memory_groups(xe);
 	struct kobject *kobj;
 	int err;
 
-	if (xe->info.platform != XE_PVC)
+	if (!groups)
 		return 0;
 
 	kobj = kobject_create_and_add("memory", tile->sysfs);
 	if (!kobj)
 		return -ENOMEM;
 
-	err = sysfs_create_group(kobj, &freq_group_attrs);
+	err = sysfs_create_groups(kobj, groups);
 	if (err) {
 		kobject_put(kobj);
 		return err;
-- 
2.43.0


  parent reply	other threads:[~2026-11-18  6:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:22 [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
2026-11-18  6:22 ` [PATCH 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config Nareshkumar Gollakoti
2026-11-18  6:53   ` Nilawar, Badal
2026-11-18  6:22 ` Nareshkumar Gollakoti [this message]
2026-11-18  6:44   ` [PATCH 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs sashiko-bot
2026-11-18  6:33 ` ✗ CI.checkpatch: warning for series starting with [1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Patchwork
2026-11-18  6:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-18  6:45 ` [PATCH 1/3] " Nilawar, Badal
2026-11-18  7:10 ` ✓ Xe.CI.BAT: success for series starting with [1/3] " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-11-18  7:25 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18  7:25 ` [PATCH 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs Nareshkumar Gollakoti
2026-11-18  7:44   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118062301.4135537-3-naresh.kumar.g@intel.com \
    --to=naresh.kumar.g@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sk.anirban@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.