All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: <sk.anirban@intel.com>,
	Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Subject: Re: [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions
Date: Wed, 18 Nov 2026 12:15:40 +0530	[thread overview]
Message-ID: <c57fd116-7adf-4618-9f2c-048237c22162@intel.com> (raw)
In-Reply-To: <20261118062301.4135537-1-naresh.kumar.g@intel.com>


On 18-11-2026 11:52, Nareshkumar Gollakoti wrote:
> From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>
> Add the PCODE MEMORY_CONFIG command and its READ_MAX_BANDWIDTH and
> READ_MAX_FREQUENCY sub-commands. They report the maximum achievable
> memory bandwidth in Mbps and the maximum achievable memory frequency
> in MHz.
>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_pcode_api.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
> index 00c4fc7d0124..f05846931059 100644
> --- a/drivers/gpu/drm/xe/xe_pcode_api.h
> +++ b/drivers/gpu/drm/xe/xe_pcode_api.h
> @@ -81,6 +81,10 @@
>   /* Domain IDs (param2) */
>   #define     PCODE_MBOX_DOMAIN_HBM		0x2
>   
> +#define   PCODE_MEMORY_CONFIG		0x70
> +#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> +#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_FREQUENCY 0x1
> +

The PCode mailbox ordering seems inconsistent: 7E, 7D, 25, 5C, 6E, 70, 
7E. Clean up can be done in separate patch.

Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Thanks,
Badal

>   #define   FAN_SPEED_CONTROL			0x7D
>   #define     FSC_READ_NUM_FANS			0x4
>   

  parent reply	other threads:[~2026-11-18  6:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:22 [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
2026-11-18  6:22 ` [PATCH 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config Nareshkumar Gollakoti
2026-11-18  6:53   ` Nilawar, Badal
2026-11-18  6:22 ` [PATCH 3/3] drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs Nareshkumar Gollakoti
2026-11-18  6:44   ` sashiko-bot
2026-11-18  6:33 ` ✗ CI.checkpatch: warning for series starting with [1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Patchwork
2026-11-18  6:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-18  6:45 ` Nilawar, Badal [this message]
2026-11-18  7:10 ` ✓ Xe.CI.BAT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-11-18  7:23 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18  7:23 ` [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
2026-11-18  7:25 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18  7:25 ` [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c57fd116-7adf-4618-9f2c-048237c22162@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=naresh.kumar.g@intel.com \
    --cc=sk.anirban@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.