From: Anand Moon <linux.amoon@gmail.com>
To: "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Yixun Lan" <dlan@kernel.org>,
"Radim Krčmář" <rkrcmar@ventanamicro.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
linux-riscv@lists.infradead.org (open list:RISC-V ARCHITECTURE),
linux-kernel@vger.kernel.org (open list),
linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM HOST DRIVERS),
linux-pm@vger.kernel.org (open list:SYSTEM RESET/SHUTDOWN
DRIVERS),
spacemit@lists.linux.dev (open list:RISC-V SPACEMIT SoC Support)
Cc: Anand Moon <linux.amoon@gmail.com>
Subject: [PATCH v2 3/3] power: reset: Remove SpacemiT P1 reboot driver
Date: Wed, 18 Nov 2026 16:19:15 +0530 [thread overview]
Message-ID: <20261118104935.1716-3-linux.amoon@gmail.com> (raw)
In-Reply-To: <20261118104935.1716-1-linux.amoon@gmail.com>
The SpacemiT P1 reboot driver uses I2C-backed regmap operations to
request system shutdown and restart through the PMIC.
The system-off handlers run in atomic context, where regmap operations
may sleep. This can trigger invalid wait context and
scheduling-while-atomic warnings during shutdown or restart.
On SpacemiT K1 platforms, system poweroff and restart are handled by
OpenSBI through the SBI System Reset (SRST) extension. The Linux PMIC
reboot driver duplicates this firmware functionality and is no longer
needed.
Remove the driver along with its Kconfig and Makefile entries.
The P1 MFD driver and its other functionality remain unaffected.
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
New patch
---
drivers/power/reset/Kconfig | 9 ---
drivers/power/reset/Makefile | 1 -
drivers/power/reset/spacemit-p1-reboot.c | 87 ------------------------
3 files changed, 97 deletions(-)
delete mode 100644 drivers/power/reset/spacemit-p1-reboot.c
diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index bce996bbef28..9e997d58fcc6 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -295,15 +295,6 @@ config POWER_RESET_KEYSTONE
help
Reboot support for the KEYSTONE SoCs.
-config POWER_RESET_SPACEMIT_P1
- tristate "SpacemiT P1 poweroff and reset driver"
- depends on ARCH_SPACEMIT || COMPILE_TEST
- depends on MFD_SPACEMIT_P1
- default MFD_SPACEMIT_P1
- help
- This driver supports power-off and reset operations for the SpacemiT
- P1 PMIC.
-
config POWER_RESET_SYSCON
bool "Generic SYSCON regmap reset driver"
depends on OF
diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
index e31cab4ba78e..2d5bdd1584cc 100644
--- a/drivers/power/reset/Makefile
+++ b/drivers/power/reset/Makefile
@@ -25,7 +25,6 @@ obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o
obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o
obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o
obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o
-obj-$(CONFIG_POWER_RESET_SPACEMIT_P1) += spacemit-p1-reboot.o
obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o
obj-$(CONFIG_POWER_RESET_TH1520_AON) += th1520-aon-reboot.o
obj-$(CONFIG_POWER_RESET_TORADEX_EC) += tdx-ec-poweroff.o
diff --git a/drivers/power/reset/spacemit-p1-reboot.c b/drivers/power/reset/spacemit-p1-reboot.c
deleted file mode 100644
index c0454b547718..000000000000
--- a/drivers/power/reset/spacemit-p1-reboot.c
+++ /dev/null
@@ -1,87 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Copyright (C) 2025 by Aurelien Jarno
- */
-
-#include <linux/bits.h>
-#include <linux/platform_device.h>
-#include <linux/regmap.h>
-#include <linux/reboot.h>
-
-/* Power Control Register 2 */
-#define PWR_CTRL2 0x7e
-#define PWR_CTRL2_SHUTDOWN BIT(2) /* Shutdown request */
-#define PWR_CTRL2_RST BIT(1) /* Reset request */
-
-static int spacemit_p1_pwroff_handler(struct sys_off_data *data)
-{
- struct regmap *regmap = data->cb_data;
- int ret;
-
- /* Put the PMIC into shutdown state */
- ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_SHUTDOWN);
- if (ret) {
- dev_err(data->dev, "shutdown failed: %d\n", ret);
- return notifier_from_errno(ret);
- }
-
- return NOTIFY_DONE;
-}
-
-static int spacemit_p1_restart_handler(struct sys_off_data *data)
-{
- struct regmap *regmap = data->cb_data;
- int ret;
-
- /* Put the PMIC into reset state */
- ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_RST);
- if (ret) {
- dev_err(data->dev, "restart failed: %d\n", ret);
- return notifier_from_errno(ret);
- }
-
- return NOTIFY_DONE;
-}
-
-static int spacemit_p1_reboot_probe(struct platform_device *pdev)
-{
- struct device *dev = &pdev->dev;
- struct regmap *regmap;
- int ret;
-
- regmap = dev_get_regmap(dev->parent, NULL);
- if (!regmap)
- return -ENODEV;
-
- ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler,
- regmap);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to register power off handler\n");
-
- ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler,
- regmap);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to register restart handler\n");
-
- return 0;
-}
-
-static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
- { .name = "spacemit-p1-reboot" },
- { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
-
-static struct platform_driver spacemit_p1_reboot_driver = {
- .driver = {
- .name = "spacemit-p1-reboot",
- },
- .probe = spacemit_p1_reboot_probe,
- .id_table = spacemit_p1_reboot_id_table,
-};
-module_platform_driver(spacemit_p1_reboot_driver);
-
-MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
-MODULE_LICENSE("GPL");
--
2.56.0
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: "Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Yixun Lan" <dlan@kernel.org>,
"Radim Krčmář" <rkrcmar@ventanamicro.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
linux-riscv@lists.infradead.org (open list:RISC-V ARCHITECTURE),
linux-kernel@vger.kernel.org (open list),
linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM HOST DRIVERS),
linux-pm@vger.kernel.org (open list:SYSTEM RESET/SHUTDOWN
DRIVERS),
spacemit@lists.linux.dev (open list:RISC-V SPACEMIT SoC Support)
Subject: [PATCH v2 3/3] power: reset: Remove SpacemiT P1 reboot driver
Date: Wed, 18 Nov 2026 16:19:15 +0530 [thread overview]
Message-ID: <20261118104935.1716-3-linux.amoon@gmail.com> (raw)
In-Reply-To: <20261118104935.1716-1-linux.amoon@gmail.com>
The SpacemiT P1 reboot driver uses I2C-backed regmap operations to
request system shutdown and restart through the PMIC.
The system-off handlers run in atomic context, where regmap operations
may sleep. This can trigger invalid wait context and
scheduling-while-atomic warnings during shutdown or restart.
On SpacemiT K1 platforms, system poweroff and restart are handled by
OpenSBI through the SBI System Reset (SRST) extension. The Linux PMIC
reboot driver duplicates this firmware functionality and is no longer
needed.
Remove the driver along with its Kconfig and Makefile entries.
The P1 MFD driver and its other functionality remain unaffected.
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
New patch
---
drivers/power/reset/Kconfig | 9 ---
drivers/power/reset/Makefile | 1 -
drivers/power/reset/spacemit-p1-reboot.c | 87 ------------------------
3 files changed, 97 deletions(-)
delete mode 100644 drivers/power/reset/spacemit-p1-reboot.c
diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index bce996bbef28..9e997d58fcc6 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -295,15 +295,6 @@ config POWER_RESET_KEYSTONE
help
Reboot support for the KEYSTONE SoCs.
-config POWER_RESET_SPACEMIT_P1
- tristate "SpacemiT P1 poweroff and reset driver"
- depends on ARCH_SPACEMIT || COMPILE_TEST
- depends on MFD_SPACEMIT_P1
- default MFD_SPACEMIT_P1
- help
- This driver supports power-off and reset operations for the SpacemiT
- P1 PMIC.
-
config POWER_RESET_SYSCON
bool "Generic SYSCON regmap reset driver"
depends on OF
diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
index e31cab4ba78e..2d5bdd1584cc 100644
--- a/drivers/power/reset/Makefile
+++ b/drivers/power/reset/Makefile
@@ -25,7 +25,6 @@ obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o
obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o
obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o
obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o
-obj-$(CONFIG_POWER_RESET_SPACEMIT_P1) += spacemit-p1-reboot.o
obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o
obj-$(CONFIG_POWER_RESET_TH1520_AON) += th1520-aon-reboot.o
obj-$(CONFIG_POWER_RESET_TORADEX_EC) += tdx-ec-poweroff.o
diff --git a/drivers/power/reset/spacemit-p1-reboot.c b/drivers/power/reset/spacemit-p1-reboot.c
deleted file mode 100644
index c0454b547718..000000000000
--- a/drivers/power/reset/spacemit-p1-reboot.c
+++ /dev/null
@@ -1,87 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Copyright (C) 2025 by Aurelien Jarno
- */
-
-#include <linux/bits.h>
-#include <linux/platform_device.h>
-#include <linux/regmap.h>
-#include <linux/reboot.h>
-
-/* Power Control Register 2 */
-#define PWR_CTRL2 0x7e
-#define PWR_CTRL2_SHUTDOWN BIT(2) /* Shutdown request */
-#define PWR_CTRL2_RST BIT(1) /* Reset request */
-
-static int spacemit_p1_pwroff_handler(struct sys_off_data *data)
-{
- struct regmap *regmap = data->cb_data;
- int ret;
-
- /* Put the PMIC into shutdown state */
- ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_SHUTDOWN);
- if (ret) {
- dev_err(data->dev, "shutdown failed: %d\n", ret);
- return notifier_from_errno(ret);
- }
-
- return NOTIFY_DONE;
-}
-
-static int spacemit_p1_restart_handler(struct sys_off_data *data)
-{
- struct regmap *regmap = data->cb_data;
- int ret;
-
- /* Put the PMIC into reset state */
- ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_RST);
- if (ret) {
- dev_err(data->dev, "restart failed: %d\n", ret);
- return notifier_from_errno(ret);
- }
-
- return NOTIFY_DONE;
-}
-
-static int spacemit_p1_reboot_probe(struct platform_device *pdev)
-{
- struct device *dev = &pdev->dev;
- struct regmap *regmap;
- int ret;
-
- regmap = dev_get_regmap(dev->parent, NULL);
- if (!regmap)
- return -ENODEV;
-
- ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler,
- regmap);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to register power off handler\n");
-
- ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler,
- regmap);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to register restart handler\n");
-
- return 0;
-}
-
-static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
- { .name = "spacemit-p1-reboot" },
- { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
-
-static struct platform_driver spacemit_p1_reboot_driver = {
- .driver = {
- .name = "spacemit-p1-reboot",
- },
- .probe = spacemit_p1_reboot_probe,
- .id_table = spacemit_p1_reboot_id_table,
-};
-module_platform_driver(spacemit_p1_reboot_driver);
-
-MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
-MODULE_LICENSE("GPL");
--
2.56.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-11-18 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 10:49 [PATCH v2 1/3] i2c: spacemit: Avoid sleeping during bus reset in atomic context Anand Moon
2026-11-18 10:49 ` Anand Moon
2026-11-18 10:49 ` [PATCH v2 2/3] riscv: sbi: Register SRST handlers with firmware priority Anand Moon
2026-11-18 10:49 ` Anand Moon
2026-11-18 10:49 ` Anand Moon [this message]
2026-11-18 10:49 ` [PATCH v2 3/3] power: reset: Remove SpacemiT P1 reboot driver Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118104935.1716-3-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=alex@ghiti.fr \
--cc=andi.shyti@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=aurelien@aurel32.net \
--cc=dlan@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rkrcmar@ventanamicro.com \
--cc=spacemit@lists.linux.dev \
--cc=sre@kernel.org \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.