All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Herve Codina <herve.codina@bootlin.com>,
	Jia Jia <physicalmtea@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v6 4/8] gpiolib: cdev: don't sleep in the SRCU read section in read()
Date: Wed, 18 Nov 2026 23:40:41 +0800	[thread overview]
Message-ID: <20261118154041.GB46152@rigel> (raw)
In-Reply-To: <20261116-gpiolib-chip-removal-v6-4-aambrozewicz@nvidia.com>

On Mon, Nov 16, 2026 at 03:47:07PM +0200, Adrian Ambrozewicz wrote:
> linereq_read(), lineevent_read() and lineinfo_watch_read() stay in the
> gdev->srcu read section while they sleep waiting for an event, so
> gpiochip_remove() blocks in synchronize_srcu() until an event arrives
> or the reader is signalled. The device lock is held meanwhile, which
> also blocks device_shutdown():
> 
>   task:init state:D stack:0 pid:1 tgid:1 ppid:0
>   Call Trace:
>    __synchronize_srcu
>    gpiochip_remove
>    devres_release_all
>    device_release_driver_internal
>    platform_device_unregister
>    gpio_sim_device_deactivate
> 
> Check the chip in a scoped SRCU section only; nothing after the check
> dereferences it. End the wait once the chip is gone, and return -ENODEV
> if there is no event to report.
> 
> Reproduced with gpio-sim: setting "live" to 0 hangs while a reader is
> blocked in read() on a line request; with this change, the write
> returns at once and read() fails with -ENODEV.
> 

Reviewed-by: Kent Gibson <warthog618@gmail.com>

Cheers,
Kent.

  reply	other threads:[~2026-11-18 15:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:47 [PATCH v6 0/8] gpiolib: fix chip removal with lines still requested from user space Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 1/8] gpiolib: wait for pending label frees before cleaning up desc_srcu Adrian Ambrozewicz
2026-11-17  8:32   ` Andy Shevchenko
2026-11-18  2:05   ` Lai, Yi
2026-11-16 13:47 ` [PATCH v6 2/8] gpiolib: free the label of lines released after their chip was removed Adrian Ambrozewicz
2026-11-17  8:33   ` Andy Shevchenko
2026-11-16 13:47 ` [PATCH v6 3/8] gpiolib: cdev: do not free line IRQs again after the chip is removed Adrian Ambrozewicz
2026-11-18 15:39   ` Kent Gibson
2026-11-16 13:47 ` [PATCH v6 4/8] gpiolib: cdev: don't sleep in the SRCU read section in read() Adrian Ambrozewicz
2026-11-18 15:40   ` Kent Gibson [this message]
2026-11-16 13:47 ` [PATCH v6 5/8] gpiolib: cdev: don't leak the IRQ name when the chip is removed Adrian Ambrozewicz
2026-11-18 15:41   ` Kent Gibson
2026-11-16 13:47 ` [PATCH v6 6/8] gpiolib: cdev: don't report a failed line read as an edge Adrian Ambrozewicz
2026-11-18 15:42   ` Kent Gibson
2026-11-16 13:47 ` [PATCH v6 7/8] gpiolib: let the character device free its IRQs first on chip removal Adrian Ambrozewicz
2026-11-18 15:52   ` Kent Gibson
2026-11-19  7:06     ` Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 8/8] gpiolib: remove the shared GPIO proxies before freeing the remaining IRQs Adrian Ambrozewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118154041.GB46152@rigel \
    --to=warthog618@gmail.com \
    --cc=aambrozewicz@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=herve.codina@bootlin.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=physicalmtea@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.