All of lore.kernel.org
 help / color / mirror / Atom feed
* + parport-use-kstrdup-in-parse_data.patch added to mm-nonmm-unstable branch
@ 2026-11-18 21:42 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-11-18 21:42 UTC (permalink / raw)
  To: mm-commits, sudipm.mukherjee, blum, akpm


The patch titled
     Subject: parport: use kstrdup() in parse_data()
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     parport-use-kstrdup-in-parse_data.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/parport-use-kstrdup-in-parse_data.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days

------------------------------------------------------
From: Thorsten Blum <blum@kernel.org>
Subject: parport: use kstrdup() in parse_data()
Date: Wed, 18 Nov 2026 19:10:34 +0100

strcpy() has been deprecated [1] because it performs no bounds checking on
the destination buffer, which can lead to buffer overflows.

While the current code works correctly, replace kmalloc() and strcpy()
with a single kstrdup() call to simplify the code.

Link: https://lore.kernel.org/20261118181033.666623-3-blum@kernel.org
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Signed-off-by: Thorsten Blum <blum@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

 drivers/parport/probe.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/parport/probe.c~parport-use-kstrdup-in-parse_data
+++ a/drivers/parport/probe.c
@@ -52,7 +52,7 @@ static void pretty_print(struct parport
 
 static void parse_data(struct parport *port, int device, char *str)
 {
-	char *txt = kmalloc(strlen(str)+1, GFP_KERNEL);
+	char *txt = kstrdup(str, GFP_KERNEL);
 	char *p = txt, *q;
 	int guessed_class = PARPORT_CLASS_UNSPEC;
 	struct parport_device_info *info = &port->probe_info[device + 1];
@@ -61,7 +61,6 @@ static void parse_data(struct parport *p
 		pr_warn("%s probe: memory squeeze\n", port->name);
 		return;
 	}
-	strcpy(txt, str);
 	while (p) {
 		char *sep;
 		q = strchr(p, ';');
_

Patches currently in -mm which might be from blum@kernel.org are

init-reject-bare-rodata-parameter-before-architecture-parsing.patch
init-use-strscpy-in-do_initcalls.patch
init-use-kmalloc-in-do_initcalls.patch
init-remove-strlcat-and-sprintf-from-do_one_initcall.patch
init-use-strscpy-in-initcall_blacklist.patch
init-combine-blacklist-entry-allocations-in-initcall_blacklist.patch
parport-use-kstrdup-in-parse_data.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-18 21:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 21:42 + parport-use-kstrdup-in-parse_data.patch added to mm-nonmm-unstable branch Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.