From: "Nikhil P. Rao" <nikhil.rao@amd.com>
To: Brett Creeley <brett.creeley@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Abhijit Gangurde <abhijit.gangurde@amd.com>,
Allen Hubbe <allen.hubbe@amd.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Leon Romanovsky <leon@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Eric Joyner <eric.joyner@amd.com>,
Arun Kumar Prakash <ArunKumar.Prakash@amd.com>,
"Nikhil P. Rao" <nikhil.rao@amd.com>
Subject: [PATCH net-next v3 0/3] ionic: make the device command timeout configurable
Date: Thu, 19 Nov 2026 00:32:30 +0000 [thread overview]
Message-ID: <20261119-b4-ionic-cmd-timeout-v3-0-2cdb8fca15fd@amd.com> (raw)
ionic waits a fixed 5 seconds for device and admin queue commands, and
the RDMA driver gives its admin queue 2 seconds. Some commands can take
the firmware longer than that, for example while a PFC configuration
change flaps the links. The firmware is alive but slow, yet the
timed-out command and everything queued behind it fail, and an RDMA
admin queue timeout resets the RDMA LIF so that later verbs fail with
-ENODEV.
Patch 1 makes the timeout a per-device value without changing it.
Patch 2 has the RDMA admin queue use the ionic command timeout instead
of its own 2 seconds.
Patch 3 adds a permanent devlink parameter, cmd_timeout, on each PF.
The firmware stores the value per PF in NVM, and the PF and its VFs
read it at probe and after a reset.
Tested on an AMD Pensando adapter under KASAN and lockdep: get and set
of the parameter, and the stored value read back after an FLR.
Patch 2 conflicts with "RDMA/ionic: Wait the device command timeout for
admin queue commands", sent to rdma for-rc:
https://patch.msgid.link/20261118-b4-ionic-rdma-admin-timeout-v1-1-39536999a3e4@amd.com
When both are merged, keep this series' version: ionic_admin_timeout()
replaces IONIC_ADMIN_TIMEOUT, and already defaults to 5 seconds.
This series was developed with the help of an LLM-based coding
assistant (Claude).
---
Changes in v3:
- patch 3:
- register the parameter once at probe, on PFs only, instead of
unregistering it on firmware and PCI resets and registering it
again on restart
- get reports the value read at the last probe or reset, or stored by
a later set, instead of sending a device command
- keep the timeout in use when reading the stored value fails,
instead of falling back to the default
- read the stored value right after identify at probe and PCI reset,
so the remaining commands there use it
- rebase on net-next
- Link to v2: https://patch.msgid.link/20261105-b4-ionic-cmd-timeout-v2-0-35a9a2aa48b1@amd.com
Changes in v2:
- patch 3:
- comment in ionic_dl_cmd_timeout_get() on why it has no FW_RESET check
- changelog "after probe or reset" -> "after probe or PCI reset"
- Link to v1: https://patch.msgid.link/20261102-b4-ionic-cmd-timeout-v1-0-2f75c2d0a0c7@amd.com
---
Arun Kumar Prakash (3):
ionic: make the command timeout per device
RDMA/ionic: Use the ionic command timeout for the admin queue
ionic: add devlink param for command timeout
Documentation/networking/devlink/ionic.rst | 27 ++++++++
drivers/infiniband/hw/ionic/ionic_admin.c | 9 ++-
drivers/net/ethernet/pensando/ionic/ionic.h | 10 ++-
drivers/net/ethernet/pensando/ionic/ionic_api.h | 8 +++
drivers/net/ethernet/pensando/ionic/ionic_aux.c | 8 ++-
.../net/ethernet/pensando/ionic/ionic_bus_pci.c | 3 +
drivers/net/ethernet/pensando/ionic/ionic_dev.c | 70 ++++++++++++++++++--
drivers/net/ethernet/pensando/ionic/ionic_dev.h | 2 +
.../net/ethernet/pensando/ionic/ionic_devlink.c | 77 ++++++++++++++++++++++
.../net/ethernet/pensando/ionic/ionic_ethtool.c | 12 ++--
drivers/net/ethernet/pensando/ionic/ionic_fw.c | 8 +--
drivers/net/ethernet/pensando/ionic/ionic_if.h | 8 +++
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 11 ++--
drivers/net/ethernet/pensando/ionic/ionic_main.c | 17 ++---
14 files changed, 236 insertions(+), 34 deletions(-)
---
base-commit: 44454974aef9c81949e5858ed3e8cbd08e104cad
change-id: 20261102-b4-ionic-cmd-timeout-c704d5304b4f
Best regards,
--
Nikhil P. Rao <nikhil.rao@amd.com>
next reply other threads:[~2026-11-19 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 0:32 Nikhil P. Rao [this message]
2026-11-19 0:32 ` [PATCH net-next v3 1/3] ionic: make the command timeout per device Nikhil P. Rao
2026-11-19 0:42 ` sashiko-bot
2026-11-19 0:32 ` [PATCH net-next v3 2/3] RDMA/ionic: Use the ionic command timeout for the admin queue Nikhil P. Rao
2026-11-19 0:42 ` sashiko-bot
2026-11-19 0:32 ` [PATCH net-next v3 3/3] ionic: add devlink param for command timeout Nikhil P. Rao
2026-11-19 0:42 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119-b4-ionic-cmd-timeout-v3-0-2cdb8fca15fd@amd.com \
--to=nikhil.rao@amd.com \
--cc=ArunKumar.Prakash@amd.com \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=eric.joyner@amd.com \
--cc=horms@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.