All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nikhil P. Rao" <nikhil.rao@amd.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/3] ionic: add devlink param for command timeout
Date: Thu, 19 Nov 2026 00:42:06 +0000	[thread overview]
Message-ID: <sashiko-outbox-222259@kernel.org> (raw)
In-Reply-To: <20261119-b4-ionic-cmd-timeout-v3-3-2cdb8fca15fd@amd.com>

> From: Arun Kumar Prakash <ArunKumar.Prakash@amd.com>
> 
> Some device and admin commands can take firmware longer than the
> driver allows to complete, for example while a PFC configuration change
> flaps the links. The firmware is alive but slow, yet the timed-out
> command and everything queued behind it fail.
> 
> Make the timeout configurable so it can be tuned to the firmware
> behaviour seen in production.
> 
> Add a permanent devlink parameter, cmd_timeout (u8, seconds), stored in
> device NVM via a new device attribute, on firmware that advertises the
> new IONIC_DEV_CAP_CMD_TIMEOUT capability. A non-zero value replaces the
> device command and admin queue timeouts, and the firmware heartbeat
> check interval derived from them; 0 restores the default. A new value
> [ ... ]
> 
> Signed-off-by: Arun Kumar Prakash <ArunKumar.Prakash@amd.com>
> Reviewed-by: Brett Creeley <brett.creeley@amd.com>
> Co-developed-by: Nikhil P. Rao <nikhil.rao@amd.com>
> Signed-off-by: Nikhil P. Rao <nikhil.rao@amd.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-b4-ionic-cmd-timeout-v3-0-2cdb8fca15fd@amd.com?part=3


      reply	other threads:[~2026-11-19  0:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  0:32 [PATCH net-next v3 0/3] ionic: make the device command timeout configurable Nikhil P. Rao
2026-11-19  0:32 ` [PATCH net-next v3 1/3] ionic: make the command timeout per device Nikhil P. Rao
2026-11-19  0:42   ` sashiko-bot
2026-11-19  0:32 ` [PATCH net-next v3 2/3] RDMA/ionic: Use the ionic command timeout for the admin queue Nikhil P. Rao
2026-11-19  0:42   ` sashiko-bot
2026-11-19  0:32 ` [PATCH net-next v3 3/3] ionic: add devlink param for command timeout Nikhil P. Rao
2026-11-19  0:42   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222259@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=nikhil.rao@amd.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.