All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	pavan.chebbi@broadcom.com
Subject: Re: [PATCH net-next 6/6] eth: bnxt_en: restart Rx queues when their IRQ moves to another NUMA node
Date: Thu, 19 Nov 2026 14:30:27 -0800	[thread overview]
Message-ID: <20261119143027.6d8ca735@kernel.org> (raw)
In-Reply-To: <CACKFLi=Zi7QBd1oNt-d99S5e6PfJ_Ym-p_-+k+iFHSU5zCi+Mw@mail.gmail.com>

On Wed, 18 Nov 2026 17:24:12 -0800 Michael Chan wrote:
> queue restart already has the code to do HWRM_RING_FREE of the CP ring
> to program the new TPH tag.  We can add the missing logic to
> re-allocate the CP ring pages from the proper NUMA.  Since we are
> paying the heavy price for a ring restart, should we include the CP
> ring to make it more complete?

I coded this up. AI review thing popped up the problem that
re-allocating CP rings causes loss of IRQ moderation settings. 
This seems net-worthy to me :S  Attaching a memory provider 
on a machine with TPH will lead to loss of coalescing settings.
Quite unpleasant for the -irq settings in particular.

Can I send out the coal fixes for net and this series without 
the CP realloc? I'd follow up with the CP realloc after the
net->net-next merge which we just missed :(

  reply	other threads:[~2026-11-19 22:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  2:38 [PATCH net-next 0/6] eth: bnxt_en: allocate memory on the right NUMA node Jakub Kicinski
2026-11-18  2:39 ` [PATCH net-next 1/6] eth: bnxt_en: order event data before setting the sp_event bit Jakub Kicinski
2026-11-18 12:27   ` Björn Töpel
2026-11-19  3:21   ` netdev-bot+sashiko
2026-11-18  2:39 ` [PATCH net-next 2/6] eth: bnxt_en: follow explicitly set IRQ affinity when placing page pool Jakub Kicinski
2026-11-18 12:32   ` Björn Töpel
2026-11-18 14:42   ` Joe Damato
2026-11-19  3:21   ` netdev-bot+sashiko
2026-11-18  2:39 ` [PATCH net-next 3/6] eth: bnxt_en: allocate per-queue SW state on the queue's NUMA node Jakub Kicinski
2026-11-18 12:37   ` Björn Töpel
2026-11-18 14:49   ` Joe Damato
2026-11-18  2:39 ` [PATCH net-next 4/6] eth: bnxt_en: explicitly keep device-only memory on the device's node Jakub Kicinski
2026-11-18 12:38   ` Björn Töpel
2026-11-18 14:50   ` Joe Damato
2026-11-18  2:39 ` [PATCH net-next 5/6] eth: bnxt_en: allocate fast path DMA rings on the queue's NUMA node Jakub Kicinski
2026-11-18 12:39   ` Björn Töpel
2026-11-18 14:51   ` Joe Damato
2026-11-18  2:39 ` [PATCH net-next 6/6] eth: bnxt_en: restart Rx queues when their IRQ moves to another " Jakub Kicinski
2026-11-18 12:50   ` Björn Töpel
2026-11-18 15:01   ` Joe Damato
2026-11-19  1:24   ` Michael Chan
2026-11-19 22:30     ` Jakub Kicinski [this message]
2026-11-20  0:46       ` Michael Chan
2026-11-19  3:21   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119143027.6d8ca735@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.