All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Damato <joe@dama.to>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, michael.chan@broadcom.com,
	netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org,
	pavan.chebbi@broadcom.com
Subject: Re: [PATCH net-next 2/6] eth: bnxt_en: follow explicitly set IRQ affinity when placing page pool
Date: Wed, 18 Nov 2026 06:42:32 -0800	[thread overview]
Message-ID: <av25WMsvk8hiJ9VO@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20261118023905.3050661-3-kuba@kernel.org>

On Tue, Nov 17, 2026 at 06:39:01PM -0800, Jakub Kicinski wrote:
> The driver picks the NUMA node for each Rx ring's page pool with
> cpumask_local_spread() at open. IRQ affinity configured by the user
> is already recorded by the driver and persists across close/open
> cycles. Use it instead of cpumask_local_spread().
> 
> The affinity notifier runs without any of the locks held by
> the allocation paths, and copying a multi-word cpumask is not atomic.
> Like for the TPH Steering Tag, have the notifier compute the node
> (of the first online CPU in the mask) and publish it with WRITE_ONCE().
> 
> Queue restart (bnxt_queue_mem_alloc()) needs to resolve the NUMA
> node instead of copying the nid of the old page pool.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h |  5 +++
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 48 +++++++++++++++++++----
>  2 files changed, 46 insertions(+), 7 deletions(-)

Reviewed-by: Joe Damato <joe@dama.to>

  parent reply	other threads:[~2026-11-18 14:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  2:38 [PATCH net-next 0/6] eth: bnxt_en: allocate memory on the right NUMA node Jakub Kicinski
2026-11-18  2:39 ` [PATCH net-next 1/6] eth: bnxt_en: order event data before setting the sp_event bit Jakub Kicinski
2026-11-18 12:27   ` Björn Töpel
2026-11-19  3:21   ` netdev-bot+sashiko
2026-11-18  2:39 ` [PATCH net-next 2/6] eth: bnxt_en: follow explicitly set IRQ affinity when placing page pool Jakub Kicinski
2026-11-18 12:32   ` Björn Töpel
2026-11-18 14:42   ` Joe Damato [this message]
2026-11-19  3:21   ` netdev-bot+sashiko
2026-11-18  2:39 ` [PATCH net-next 3/6] eth: bnxt_en: allocate per-queue SW state on the queue's NUMA node Jakub Kicinski
2026-11-18 12:37   ` Björn Töpel
2026-11-18 14:49   ` Joe Damato
2026-11-18  2:39 ` [PATCH net-next 4/6] eth: bnxt_en: explicitly keep device-only memory on the device's node Jakub Kicinski
2026-11-18 12:38   ` Björn Töpel
2026-11-18 14:50   ` Joe Damato
2026-11-18  2:39 ` [PATCH net-next 5/6] eth: bnxt_en: allocate fast path DMA rings on the queue's NUMA node Jakub Kicinski
2026-11-18 12:39   ` Björn Töpel
2026-11-18 14:51   ` Joe Damato
2026-11-18  2:39 ` [PATCH net-next 6/6] eth: bnxt_en: restart Rx queues when their IRQ moves to another " Jakub Kicinski
2026-11-18 12:50   ` Björn Töpel
2026-11-18 15:01   ` Joe Damato
2026-11-19  1:24   ` Michael Chan
2026-11-19 22:30     ` Jakub Kicinski
2026-11-20  0:46       ` Michael Chan
2026-11-19  3:21   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av25WMsvk8hiJ9VO@devvm20253.cco0.facebook.com \
    --to=joe@dama.to \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.