From: Jakub Kicinski <kuba@kernel.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: netdev@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
LABBE Corentin <clabbe.montjoie@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: stmmac: dwmac-sun8i: Honor the RX checksum offload setting
Date: Thu, 19 Nov 2026 16:11:51 -0800 [thread overview]
Message-ID: <20261119161151.5251fc86@kernel.org> (raw)
In-Reply-To: <CADvTj4oJ6HDR2k6qVgefUX-h0TGh2n+AO5gx_dcJFzzWML+2UQ@mail.gmail.com>
On Thu, 19 Nov 2026 16:32:58 -0700 James Hilliard wrote:
> Would it make sense to address the `rx on` drops in a separate
> follow-up along the lines of Oleksij's dwmac4 fix [0]? On sun8i that
> would mean enabling error forwarding to DMA and passing packets whose
> only error is an IP or transport checksum up as CHECKSUM_NONE, while
> still discarding frames with a bad FCS or other fatal RX errors.
>
> If we leave the checker enabled in both modes, `rx off` would only
> control whether the driver reports a checksum as verified. In that
> form the follow-up would replace the conditional bit-27 write rather
> than depend on this patch.
I'm not very clear on the changes needed to get to "bad L4 csum packets
still reach the stack" / correct behavior. Would you be willing to
sketch the full series out already, and then we decide what gets
applied where?
What I would like to avoid is us applying this fix to net (which
seems legitimate on the surface), but then following up with another
fix which unconditionally clears EMAC_RX_DO_CRC since AFAIU we
need to clear it for the correct behavior.
next prev parent reply other threads:[~2026-11-20 0:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 0:58 [PATCH net] net: stmmac: dwmac-sun8i: Honor the RX checksum offload setting James Hilliard
2026-11-16 1:03 ` netdev-bot+sinfo
2026-11-16 2:19 ` James Hilliard
2026-11-16 2:28 ` James Hilliard
2026-11-17 15:20 ` Maxime Chevallier
2026-11-17 15:26 ` Lorenzo Bianconi
2026-11-18 4:00 ` netdev-bot+sashiko
2026-11-19 17:18 ` James Hilliard
2026-11-19 22:48 ` Jakub Kicinski
2026-11-19 23:32 ` James Hilliard
2026-11-20 0:11 ` Jakub Kicinski [this message]
2026-11-20 17:33 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119161151.5251fc86@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.