All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] x86/mce: Report unavailable MCE support at informational level
@ 2026-11-19 18:58 Dexuan Cui
  0 siblings, 0 replies; only message in thread
From: Dexuan Cui @ 2026-11-19 18:58 UTC (permalink / raw)
  To: tony.luck, bp, tglx, mingo, dave.hansen, x86, hpa, linux-edac,
	linux-kernel
  Cc: kameroncarr, Dexuan Cui, Naman Jain, Yazen Ghannam

mcheck_init_device() reports an error and returns -EIO when
mce_available() is false. However, MCE support being unavailable does
not necessarily indicate an initialization failure.

For example, a TDX guest with TD_CTLS.REDUCE_VE set and
FEATURE_PARAVIRT_CTLS.MCA clear does not enumerate the MCE and MCA
CPUID capabilities. This is an expected configuration, but it causes
the kernel to print:

  mce: Unable to init MCE device (rc: -5)

MCE can also be unavailable because it was explicitly disabled with
mce=off or nomce. When it was disabled due to an earlier initialization
problem, the relevant path already reports the reason.

Report MCE unavailability at informational level and return -ENODEV
directly instead of routing it through the common error path.

Reviewed-by: Naman Jain <namjain@linux.microsoft.com>
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
---

Changes since v1:
    v1: https://lore.kernel.org/all/20260923173033.4104944-1-decui@microsoft.com/

    Added Reviewed-by's of Naman and Yazen.
    No other change.

 arch/x86/kernel/cpu/mce/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 50b1614968be6..ca7b729b74126 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -2815,8 +2815,8 @@ static __init int mcheck_init_device(void)
 	MAYBE_BUILD_BUG_ON(__VIRTUAL_MASK_SHIFT >= 63);
 
 	if (!mce_available(&boot_cpu_data)) {
-		err = -EIO;
-		goto err_out;
+		pr_info("MCE is unavailable\n");
+		return -ENODEV;
 	}
 
 	if (!zalloc_cpumask_var(&mce_device_initialized, GFP_KERNEL)) {
-- 
2.55.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-19 18:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 18:58 [PATCH v2] x86/mce: Report unavailable MCE support at informational level Dexuan Cui

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.