All of lore.kernel.org
 help / color / mirror / Atom feed
* CVE-2026-99547: thunderbolt: Do not RPM complete unrelated subtrees on unplug
@ 2026-11-19 14:27 Greg Kroah-Hartman
  0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2026-11-19 14:27 UTC (permalink / raw)
  To: linux-cve-announce; +Cc: Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@kernel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

thunderbolt: Do not RPM complete unrelated subtrees on unplug

When a Thunderbolt device is unplugged, that switch and every switch
subsequent to it on the bus device list is `complete()`d, not just its
child devices. In the case of multiple domains, it may cause, eg, an
attempt to `complete()` the uninitialized domain 1 root switch RPM
completion on unplug of a switch from domain 0 (though ordering is not
guaranteed numerically sorted).

I initially noticed this issue on a Dell XPS9720 when the system would
seem to sporadically not wake after unplugging a Thunderbolt dock. I
tried multiple kernel versions including v7.2.7 and v7.3-rc4 to see if
that resolved the issue, but the issue persisted. Eventually I found
that I could consistently generate a kernel Oops reporting a page fault
at 0xffff_ffff_ffff_fff8 on unplug from one side of the laptop and went
bug hunting. I became suspicious of the `bus_for_each_dev()` walk that I
ultimately ended up changing. To confirm this issue, I did an eBPF trace
of `bus_for_each_dev()`, `complete_rpm()`, and `complete()` while
unplugging in a variety of situations and found that an unplug from
domain 0 tries to `complete_rpm()` domain 1's switch, whose RPM
completion is not initialized and thus is holding a null wait-list
pointer, triggering the page fault.

Here are the key sections of that eBPF trace. Note that HEAD denotes the
completion's own wait-list HEAD:

```
RESCAN_ENTER domain=0

COMPLETE rescan_domain=0 target=0-1 target_domain=0
         route=0x1 parent=0-0 unplugged=1
COMPLETION done=0 head=HEAD next=HEAD prev=HEAD

BUS_WALK domain=0 start=0-1 callback=complete_rpm
CALLBACK_ENTER rescan_domain=0 dev=1-0 parent=domain1 is_switch=1

COMPLETE rescan_domain=0 target=1-0 target_domain=1
         route=0x0 parent=domain1 unplugged=0
COMPLETION done=0 head=HEAD next=0 prev=0

        complete+5
        complete_rpm+43
        bus_for_each_dev+133
        icm_free_unplugged_children+250
        icm_rescan_work+42
```

This patch gates the `complete()` on an additional condition - that the
Thunderbolt domain matches the domain of the device that was unplugged.

I only have a single system with multiple Thunderbolt domains - the Dell
XPS9720. I am consistently able to reproduce the Oops on that system.
Since running with this patch, I have not seen the Oops reoccur. I have
also tested it on a Thinkpad X1-Gen12, and that system boots and runs
well with it, but it only has a single Thunderbolt domain, so it does
not exercise the multi-domain failure case.

The Linux kernel CVE team has assigned CVE-2026-99547 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.2 with commit 4f7c2e0d8765a0266b920c66ffc495fde44c1ec8 and fixed in 6.12.117 with commit a7f354751b05ead5538176deadb9bc5b1fda0a3c
	Issue introduced in 5.2 with commit 4f7c2e0d8765a0266b920c66ffc495fde44c1ec8 and fixed in 6.18.61 with commit 85a8777c7ec5e17b999b4c9eb0c8cbf4ab936998
	Issue introduced in 5.2 with commit 4f7c2e0d8765a0266b920c66ffc495fde44c1ec8 and fixed in 7.3.2 with commit e45356d83adce72fd99f57763eb3456c7c560857
	Issue introduced in 5.2 with commit 4f7c2e0d8765a0266b920c66ffc495fde44c1ec8 and fixed in 7.4-rc1 with commit 96a8479804e3f7af43e639e9df39f562f1a75fd5

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2026-99547
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/thunderbolt/icm.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/a7f354751b05ead5538176deadb9bc5b1fda0a3c
	https://git.kernel.org/stable/c/85a8777c7ec5e17b999b4c9eb0c8cbf4ab936998
	https://git.kernel.org/stable/c/e45356d83adce72fd99f57763eb3456c7c560857
	https://git.kernel.org/stable/c/96a8479804e3f7af43e639e9df39f562f1a75fd5

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-19 15:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 14:27 CVE-2026-99547: thunderbolt: Do not RPM complete unrelated subtrees on unplug Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.