All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: eip93 - return request validation errors synchronously
@ 2026-11-20 19:37 ` Gleb Pesin via B4 Relay
  0 siblings, 0 replies; 2+ messages in thread
From: Gleb Pesin @ 2026-11-20 19:37 UTC (permalink / raw)
  To: Christian Marangi, Antoine Tenart, Herbert Xu, David S. Miller
  Cc: linux-crypto, linux-kernel

The skcipher and AEAD paths validate requests before submitting them
to the hardware. On validation failure they invoke the completion
callback and return the same error. Callers handle that return value
as a synchronous failure and can complete the request a second time.

Return the validation error directly in both paths. Keep completion
callbacks in the hardware result handlers.

Codex (gpt-6.2-sol) assisted with comparing the two paths, preparing the
change and writing the changelog. The corresponding OpenWrt 6.18.64
driver object was cross-compiled on MIPS.

Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
Reported-by: Herbert Xu <herbert@gondor.apana.org.au>
Closes: https://lore.kernel.org/linux-crypto/aXxmIuU9PKJiDs7n@gondor.apana.org.au/
Signed-off-by: Gleb Pesin <dormancygrace@gmail.com>
---
 drivers/crypto/inside-secure/eip93/eip93-aead.c   | 4 +---
 drivers/crypto/inside-secure/eip93/eip93-cipher.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/inside-secure/eip93/eip93-aead.c b/drivers/crypto/inside-secure/eip93/eip93-aead.c
index 0b7a899b1..12134b6aa 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-aead.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-aead.c
@@ -47,10 +47,8 @@ static int eip93_aead_send_req(struct crypto_async_request *async)
 	int err;
 
 	err = check_valid_request(rctx);
-	if (err) {
-		aead_request_complete(req, err);
+	if (err)
 		return err;
-	}
 
 	return eip93_send_req(async, req->iv, rctx);
 }
diff --git a/drivers/crypto/inside-secure/eip93/eip93-cipher.c b/drivers/crypto/inside-secure/eip93/eip93-cipher.c
index 4dd7ab750..7b6d510f4 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-cipher.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-cipher.c
@@ -38,10 +38,8 @@ static int eip93_skcipher_send_req(struct crypto_async_request *async)
 
 	err = check_valid_request(rctx);
 
-	if (err) {
-		skcipher_request_complete(req, err);
+	if (err)
 		return err;
-	}
 
 	return eip93_send_req(async, req->iv, rctx);
 }

---
base-commit: 26ca5f34841f0a86d0883664a1c13be89a01d351
change-id: 20261120-eip93-sync-errors-fd700c897151

Best regards,
--  
Gleb Pesin <dormancygrace@gmail.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-20 19:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 19:37 [PATCH] crypto: eip93 - return request validation errors synchronously Gleb Pesin
2026-11-20 19:37 ` Gleb Pesin via B4 Relay

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.