From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Oded Gabbay <ogabbay@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
sashiko-bot@kernel.org
Subject: [PATCH v5 00/19] accel: ethosu: Cmd stream validation fixes
Date: Fri, 20 Nov 2026 08:57:24 -0600 [thread overview]
Message-ID: <20261120-ethosu-fixes-v5-0-52d459acdb84@kernel.org> (raw)
The series was getting a bit long, so I split out the cmd stream
validation fixes from the error path, close/unbind, lifetime, etc.
fixes. It's a mixture of AI reported issues, different solutions to
other posted issues and fixes[1] and my own fixes. It also adds U85 OFM
transpose, resize and IFM upscaling support.
The series adds rejecting OFM transpose in cmd stream, but then a later
patch adds support for it. I did this so the rejection can be
backported, but maybe supporting OFM transpose is small enough that it
should just be backported too?
Rob
[1] https://lore.kernel.org/all/20260717061145.1478139-1-zhaoguohan@kylinos.cn
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Changes in v5:
- Drop all but cmd stream validation patches
- IFM upscaling also supported on U65
- Fix U85 shared DMA stride mode and mixed contiguous/strided U65 DMA.
Ignore stale bounds for inactive weight and scale streams.
- Correct resize bounds for signed offsets and programmed input sizes.
- New patch to reject U85 IFM broadcasting on U65
- Fixes for handling multiple weight streams and U85 fast weights mode
- Handle accumulator size mismatch with IFM2 size and ensure ACC_FORMAT
is set.
- Drop "accel: ethosu: Account for kernel dilation in IFM size" which
wasn't correct.
- Link to v4: https://patch.msgid.link/20261029-ethosu-fixes-v4-0-4aa25e22578e@kernel.org
Changes in v4:
- More patches added for existing issues raised by Sashiko in v3 and
local runs
- Combined the 2 patches for unknown cmds and unhandled parameters into
one patch
- Link to v3: https://patch.msgid.link/20260908-ethosu-fixes-v3-0-490fe215286f@kernel.org
Changes in v3:
- Address Sashiko comments
- Another runtime-PM fix for driver remove()
- Add a fix for NHCWB16 bounds calculation
- Link to v2: https://patch.msgid.link/20260904-ethosu-fixes-v2-0-3767738756a4@kernel.org
Changes in v2:
- Dropped first 5 patches which are already applied
- Patches 11-17 and 19 are new patches with more cmd stream validation
- Add fix to diable clocks on PM setup failure
- Rework the runtime-PM to suspend after initialization and before
drm_dev_register(). This simplifies the error clean-up in probe.
- Handle quiescing jobs before scheduler teardown
- Rework the cmd stream register initialization tracking to use a bitmap
of registers instead of relying on initial state values.
- Handle U85 DMA 2D/3D modes correctly
- Link to v1: https://patch.msgid.link/20260827-ethosu-fixes-v1-0-346f9ea8791c@kernel.org
---
Rob Herring (Arm) (19):
accel: ethosu: Prevent command stream export
accel: ethosu: Move DMA mode to src/dst struct
accel: ethosu: Track command stream register setup
accel: ethosu: Factor buffer bounds checks
accel: ethosu: Fix NHCWB16 bounds calculation
accel: ethosu: Validate secondary streams
accel: ethosu: Reject unsupported commands and params
accel: ethosu: Validate all feature map tiles
accel: ethosu: Account for feature map element size
accel: ethosu: Validate convolution parameter
accel: ethosu: Validate accumulator input
accel: ethosu: Restrict dynamic IFM2 weights
accel: ethosu: Split U65 and U85 DMA length validation
accel: ethosu: Validate OFM transpose
accel: ethosu: Validate resize operations
accel: ethosu: Ensure cmd stream is multiple of 4 bytes
accel: ethosu: Require active weight streams setup
accel: ethosu: Support IFM upscaling
accel: ethosu: Reject IFM broadcast on U65
drivers/accel/ethosu/ethosu_device.h | 32 ++
drivers/accel/ethosu/ethosu_gem.c | 1009 +++++++++++++++++++++++++++++++---
2 files changed, 961 insertions(+), 80 deletions(-)
---
base-commit: b4d01c788bfa50dc65ffb5fbc9db4135004c0e01
change-id: 20260827-ethosu-fixes-ee58386e9000
Best regards,
--
Rob Herring (Arm) <robh@kernel.org>
next reply other threads:[~2026-11-20 14:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 14:57 Rob Herring (Arm) [this message]
2026-11-20 14:57 ` [PATCH v5 01/19] accel: ethosu: Prevent command stream export Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 02/19] accel: ethosu: Move DMA mode to src/dst struct Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 03/19] accel: ethosu: Track command stream register setup Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 04/19] accel: ethosu: Factor buffer bounds checks Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 05/19] accel: ethosu: Fix NHCWB16 bounds calculation Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 06/19] accel: ethosu: Validate secondary streams Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 07/19] accel: ethosu: Reject unsupported commands and params Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 08/19] accel: ethosu: Validate all feature map tiles Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 09/19] accel: ethosu: Account for feature map element size Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 10/19] accel: ethosu: Validate convolution parameter Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 11/19] accel: ethosu: Validate accumulator input Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 12/19] accel: ethosu: Restrict dynamic IFM2 weights Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 13/19] accel: ethosu: Split U65 and U85 DMA length validation Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 14/19] accel: ethosu: Validate OFM transpose Rob Herring (Arm)
2026-11-20 15:07 ` sashiko-bot
2026-11-20 14:57 ` [PATCH v5 15/19] accel: ethosu: Validate resize operations Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 16/19] accel: ethosu: Ensure cmd stream is multiple of 4 bytes Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 17/19] accel: ethosu: Require active weight streams setup Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 18/19] accel: ethosu: Support IFM upscaling Rob Herring (Arm)
2026-11-20 15:12 ` sashiko-bot
2026-11-20 14:57 ` [PATCH v5 19/19] accel: ethosu: Reject IFM broadcast on U65 Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120-ethosu-fixes-v5-0-52d459acdb84@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.