All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 18/19] accel: ethosu: Support IFM upscaling
Date: Fri, 20 Nov 2026 15:12:26 +0000	[thread overview]
Message-ID: <sashiko-outbox-225440@kernel.org> (raw)
In-Reply-To: <20261120-ethosu-fixes-v5-18-52d459acdb84@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] accel: ethosu: missing NPU_SET_IFM_UPSCALE check in
  feat_matrix_validate()
--

commit a2e33d72a9a5c1a79fd1f24546e3bdc167a7ece4
Author: Rob Herring (Arm) <robh@kernel.org>

accel: ethosu: Support IFM upscaling

This commit tracks NPU_SET_IFM_UPSCALE during command stream validation,
adjusts IFM bounds for 2x resampling modes, and rejects incompatible
stride, chained storage, resize, and pooling configurations.

> diff --git a/drivers/accel/ethosu/ethosu_gem.c b/drivers/accel/ethosu/ethosu_gem.c
> index d2884d9922aea..b4544298742f1 100644
> --- a/drivers/accel/ethosu/ethosu_gem.c
> +++ b/drivers/accel/ethosu/ethosu_gem.c
[ ... ]
> @@ -402,6 +403,11 @@ static int feat_matrix_validate(struct ethosu_device *edev,
>  		    !cmd_state_reg_is_set(st, NPU_SET_IFM_PRECISION) ||
>  		    !cmd_state_reg_is_set(st, NPU_SET_IFM_DEPTH_M1))
>  			return -EINVAL;
> +		if (st->ifm_upscale &&
> +		    (!cmd_state_reg_is_set(st, NPU_SET_KERNEL_STRIDE) ||
> +		     feat_matrix_chained(edev, fm) ||
> +		     (st->ifm.stride_kernel & (BIT(0) | BIT(1) | BIT(6) | BIT(9)))))
> +			return -EINVAL;
>  		if (feat_matrix_chained(edev, fm))
>  			return 0;
>  		if (!cmd_state_reg_is_set(st, NPU_SET_IFM_WIDTH0_M1) ||

[Severity: High]
Should feat_matrix_validate() require cmd_state_reg_is_set(st,
NPU_SET_IFM_UPSCALE) for FEAT_MATRIX_IFM?

The NPU is not reset between consecutive jobs, so NPU_SET_IFM_UPSCALE
persists in hardware from a previous job while cmd_state_init()
zero-initializes st->ifm_upscale to NPU_IFM_UPSCALE_NONE.  If a second job
omits NPU_SET_IFM_UPSCALE, it runs with IFM upscaling enabled in hardware
while validation checks st->ifm_upscale == NPU_IFM_UPSCALE_NONE, bypassing
the chained-IFM and kernel-stride checks here as well as the upscaling
restrictions in calc_sizes_resize() and NPU_OP_POOL.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-ethosu-fixes-v5-0-52d459acdb84@kernel.org?part=18

  reply	other threads:[~2026-11-20 15:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 14:57 [PATCH v5 00/19] accel: ethosu: Cmd stream validation fixes Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 01/19] accel: ethosu: Prevent command stream export Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 02/19] accel: ethosu: Move DMA mode to src/dst struct Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 03/19] accel: ethosu: Track command stream register setup Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 04/19] accel: ethosu: Factor buffer bounds checks Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 05/19] accel: ethosu: Fix NHCWB16 bounds calculation Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 06/19] accel: ethosu: Validate secondary streams Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 07/19] accel: ethosu: Reject unsupported commands and params Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 08/19] accel: ethosu: Validate all feature map tiles Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 09/19] accel: ethosu: Account for feature map element size Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 10/19] accel: ethosu: Validate convolution parameter Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 11/19] accel: ethosu: Validate accumulator input Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 12/19] accel: ethosu: Restrict dynamic IFM2 weights Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 13/19] accel: ethosu: Split U65 and U85 DMA length validation Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 14/19] accel: ethosu: Validate OFM transpose Rob Herring (Arm)
2026-11-20 15:07   ` sashiko-bot
2026-11-20 14:57 ` [PATCH v5 15/19] accel: ethosu: Validate resize operations Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 16/19] accel: ethosu: Ensure cmd stream is multiple of 4 bytes Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 17/19] accel: ethosu: Require active weight streams setup Rob Herring (Arm)
2026-11-20 14:57 ` [PATCH v5 18/19] accel: ethosu: Support IFM upscaling Rob Herring (Arm)
2026-11-20 15:12   ` sashiko-bot [this message]
2026-11-20 14:57 ` [PATCH v5 19/19] accel: ethosu: Reject IFM broadcast on U65 Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225440@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.