All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: "Matthew Brost" <matthew.brost@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Himal Prasad Ghimiray" <himal.prasad.ghimiray@intel.com>,
	"Stuart Summers" <stuart.summers@intel.com>
Cc: intel-xe@lists.freedesktop.org, Matthew Auld <matthew.auld@intel.com>
Subject: [PATCH v2 0/6] Non-fatal repin retries and NUMA-local rebind worker
Date: Fri, 20 Nov 2026 13:02:15 +0000	[thread overview]
Message-ID: <20261120-userptr-repin-v2-0-65e1f6e582ef@intel.com> (raw)

drm_gpusvm_get_pages() fails with -EBUSY after a fixed 1s budget when
CPU mappings keep changing during a userptr repin (for instance under
AutoNUMA balancing or concurrent mapping churn), which Xe currently
treats as fatal.

Retry userptr repins with locks dropped up to a configurable
userptr_repin_timeout_ms sysfs timeout (requeuing the compute rebind
worker on -EAGAIN), restore userptr invalidations lost on VMA op unwind,
and run the compute rebind worker on the device's NUMA node so HMM
faults do not trigger remote AutoNUMA migrations (hopefully).

First patch is mostly orthogonal bug fix, however series here could
potentially make the race more likely, so included it here.

---
Changes in v2:
- Reduce the timeout, also give more time for known NUMA config.
- Move the compute rebind worker away from 1-at-a-time.
- Tweak the teardown order for rebind wq.
- Split one fix out from Thomas' patch.
- Link to v1: https://lore.kernel.org/r/20261119-userptr-repin-v1-0-af2e327833a9@intel.com

---
Matthew Auld (2):
      drm/xe/vm: restore userptr invalidations on VMA op unwind
      drm/xe: run compute rebind worker on device NUMA node

Thomas Hellström (4):
      drm/xe/vf: Free preempt fences on rebind worker retry
      drm/xe: Requeue the rebind worker instead of retrying in-line on -EAGAIN
      drm/xe: Add a userptr repin timeout sysfs attribute
      drm/xe/userptr: Make the repin retry loop non-fatal

 drivers/gpu/drm/xe/xe_device.c       |  12 ++-
 drivers/gpu/drm/xe/xe_device.h       |   3 +
 drivers/gpu/drm/xe/xe_device_sysfs.c |  57 ++++++++++++++
 drivers/gpu/drm/xe/xe_device_types.h |  14 +++-
 drivers/gpu/drm/xe/xe_exec.c         |   9 ++-
 drivers/gpu/drm/xe/xe_pagefault.c    |   4 +
 drivers/gpu/drm/xe/xe_userptr.c      |  47 ++++++++++--
 drivers/gpu/drm/xe/xe_userptr.h      |  53 +++++++++++++
 drivers/gpu/drm/xe/xe_vm.c           | 139 ++++++++++++++++++++++++-----------
 drivers/gpu/drm/xe/xe_vm.h           |   6 +-
 drivers/gpu/drm/xe/xe_vm_madvise.c   |  23 +++++-
 drivers/gpu/drm/xe/xe_vm_types.h     |   8 ++
 12 files changed, 319 insertions(+), 56 deletions(-)
---
base-commit: 5273820504a824f0c81ed31f939599dd0da3fc69
change-id: 20261118-userptr-repin-52499936a13c


             reply	other threads:[~2026-11-20 13:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 13:02 Matthew Auld [this message]
2026-11-20 13:02 ` [PATCH v2 1/6] drm/xe/vm: restore userptr invalidations on VMA op unwind Matthew Auld
2026-11-20 13:02 ` [PATCH v2 2/6] drm/xe/vf: Free preempt fences on rebind worker retry Matthew Auld
2026-11-20 15:59   ` Himal prasad Ghimiray
2026-11-20 13:02 ` [PATCH v2 3/6] drm/xe: Requeue the rebind worker instead of retrying in-line on -EAGAIN Matthew Auld
2026-11-20 13:02 ` [PATCH v2 4/6] drm/xe: Add a userptr repin timeout sysfs attribute Matthew Auld
2026-11-20 15:56   ` Himal prasad Ghimiray
2026-11-20 13:02 ` [PATCH v2 5/6] drm/xe/userptr: Make the repin retry loop non-fatal Matthew Auld
2026-11-20 14:03   ` sashiko-bot
2026-11-20 14:52     ` Matthew Auld
2026-11-20 13:02 ` [PATCH v2 6/6] drm/xe: run compute rebind worker on device NUMA node Matthew Auld
2026-11-20 13:12 ` ✓ CI.KUnit: success for Non-fatal repin retries and NUMA-local rebind worker (rev2) Patchwork
2026-11-20 13:47 ` ✓ Xe.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120-userptr-repin-v2-0-65e1f6e582ef@intel.com \
    --to=matthew.auld@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=stuart.summers@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.