From: Himal prasad Ghimiray <himal.prasad.ghimiray@intel.com>
To: "Matthew Auld" <matthew.auld@intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Stuart Summers" <stuart.summers@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/6] drm/xe/vf: Free preempt fences on rebind worker retry
Date: Fri, 20 Nov 2026 21:29:27 +0530 [thread overview]
Message-ID: <e66f9aca-5a07-4afa-b11b-a70af863d140@intel.com> (raw)
In-Reply-To: <20261120-userptr-repin-v2-2-65e1f6e582ef@intel.com>
On 20-11-2026 18:32, Matthew Auld wrote:
> From: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
> When preempt_rebind_work_func() hits -EAGAIN after
> alloc_preempt_fences(), the SR-IOV VF migration path requeues the worker
> and returns without freeing the local preempt_fences list or emitting
> trace_xe_vm_rebind_worker_exit().
>
> Free preempt_fences and emit the exit tracepoint before returning.
>
> Fixes: 1faeeea056ab ("drm/xe/vf: Avoid indefinite blocking in preempt rebind worker for VFs supporting migration")
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <stable@vger.kernel.org> # v6.19+
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 75be5e5329bd..82e716b12b49 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -649,7 +649,9 @@ static void preempt_rebind_work_func(struct work_struct *w)
> if (IS_SRIOV_VF(vm->xe) &&
> xe_sriov_vf_migration_supported(vm->xe)) {
> up_write(&vm->lock);
> + free_preempt_fences(&preempt_fences);
> xe_vm_queue_rebind_worker(vm);
> + trace_xe_vm_rebind_worker_exit(vm);
LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> return;
> }
>
>
next prev parent reply other threads:[~2026-11-20 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 13:02 [PATCH v2 0/6] Non-fatal repin retries and NUMA-local rebind worker Matthew Auld
2026-11-20 13:02 ` [PATCH v2 1/6] drm/xe/vm: restore userptr invalidations on VMA op unwind Matthew Auld
2026-11-20 13:02 ` [PATCH v2 2/6] drm/xe/vf: Free preempt fences on rebind worker retry Matthew Auld
2026-11-20 15:59 ` Himal prasad Ghimiray [this message]
2026-11-20 13:02 ` [PATCH v2 3/6] drm/xe: Requeue the rebind worker instead of retrying in-line on -EAGAIN Matthew Auld
2026-11-20 13:02 ` [PATCH v2 4/6] drm/xe: Add a userptr repin timeout sysfs attribute Matthew Auld
2026-11-20 15:56 ` Himal prasad Ghimiray
2026-11-20 13:02 ` [PATCH v2 5/6] drm/xe/userptr: Make the repin retry loop non-fatal Matthew Auld
2026-11-20 14:03 ` sashiko-bot
2026-11-20 14:52 ` Matthew Auld
2026-11-20 13:02 ` [PATCH v2 6/6] drm/xe: run compute rebind worker on device NUMA node Matthew Auld
2026-11-20 13:12 ` ✓ CI.KUnit: success for Non-fatal repin retries and NUMA-local rebind worker (rev2) Patchwork
2026-11-20 13:47 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e66f9aca-5a07-4afa-b11b-a70af863d140@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=stuart.summers@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.