All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edward Adam Davis <eadavis@sina.com>
To: syzbot+ee09ee2112d03c35f1f7@syzkaller.appspotmail.com
Cc: joern@lazybastard.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
	richard@nod.at, syzkaller-bugs@googlegroups.com, vigneshr@ti.com
Subject: [PATCH] mtd: Use I/O memory accessors when in an uncached
Date: Fri, 20 Nov 2026 12:37:09 +0800	[thread overview]
Message-ID: <20261120043709.99845-1-eadavis@sina.com> (raw)
In-Reply-To: <6afd0433.8f566acc.2517be.000f.GAE@google.com>

When registering a phram device via module parameter or sysfs invokes
register_device() with pdev = NULL, which causes new->cached to be false.
As a result, phram_map() maps the physical memory region using ioremap()
(mapped as PROT_DEVICE_nGnRE on arm64) and forces the pointer into mtd->
priv, yet phram_read(), phram_write(), and phram_erase() access it using
standard memcpy() and memset() instead of I/O memory accessors (like
memcpy_fromio()). When scanning partition headers (e.g., ftl_add_mtd()
reading a 68-byte header via mtd_read()), arm64's memcpy implementation
issues pair-load (ldp) instructions at unaligned offsets, which triggers
an alignment fault (FSC = 0x21) on Device memory and crashes the kernel.

In phram_read/write/erase(), standard memory accessors are used when in
a cached; otherwise, I/O memory accessors are used.

Fixes: f3d45ac21e46 ("mtd: phram: Module parameters add writable permissions")
Fixes: 285133040e6c ("arm64: Import latest memcpy()/memmove() implementation")
Reported-by: syzbot+ee09ee2112d03c35f1f7@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=ee09ee2112d03c35f1f7
Signed-off-by: Edward Adam Davis <eadavis@sina.com>
---
 drivers/mtd/devices/phram.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index b42cadcd76b1..95bd5a9d7e48 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -43,8 +43,13 @@ static LIST_HEAD(phram_list);
 static int phram_erase(struct mtd_info *mtd, struct erase_info *instr)
 {
 	u_char *start = mtd->priv;
+	struct device_node *np = mtd_get_of_node(mtd);
+	bool cached = np ? !of_property_read_bool(np, "no-map") : false;
 
-	memset(start + instr->addr, 0xff, instr->len);
+	if (cached)
+		memset(start + instr->addr, 0xff, instr->len);
+	else
+		memset_io(start + instr->addr, 0xff, instr->len);
 
 	return 0;
 }
@@ -66,8 +71,13 @@ static int phram_read(struct mtd_info *mtd, loff_t from, size_t len,
 		size_t *retlen, u_char *buf)
 {
 	u_char *start = mtd->priv;
+	struct device_node *np = mtd_get_of_node(mtd);
+	bool cached = np ? !of_property_read_bool(np, "no-map") : false;
 
-	memcpy(buf, start + from, len);
+	if (cached)
+		memcpy(buf, start + from, len);
+	else
+		memcpy_fromio(buf, start + from, len);
 	*retlen = len;
 	return 0;
 }
@@ -76,8 +86,13 @@ static int phram_write(struct mtd_info *mtd, loff_t to, size_t len,
 		size_t *retlen, const u_char *buf)
 {
 	u_char *start = mtd->priv;
+	struct device_node *np = mtd_get_of_node(mtd);
+	bool cached = np ? !of_property_read_bool(np, "no-map") : false;
 
-	memcpy(start + to, buf, len);
+	if (cached)
+		memcpy(start + to, buf, len);
+	else
+		memcpy_fromio(start + to, buf, len);
 	*retlen = len;
 	return 0;
 }
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Edward Adam Davis <eadavis@sina.com>
To: syzbot+ee09ee2112d03c35f1f7@syzkaller.appspotmail.com
Cc: joern@lazybastard.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
	richard@nod.at, syzkaller-bugs@googlegroups.com, vigneshr@ti.com
Subject: [PATCH] mtd: Use I/O memory accessors when in an uncached
Date: Fri, 20 Nov 2026 12:37:09 +0800	[thread overview]
Message-ID: <20261120043709.99845-1-eadavis@sina.com> (raw)
In-Reply-To: <6afd0433.8f566acc.2517be.000f.GAE@google.com>

When registering a phram device via module parameter or sysfs invokes
register_device() with pdev = NULL, which causes new->cached to be false.
As a result, phram_map() maps the physical memory region using ioremap()
(mapped as PROT_DEVICE_nGnRE on arm64) and forces the pointer into mtd->
priv, yet phram_read(), phram_write(), and phram_erase() access it using
standard memcpy() and memset() instead of I/O memory accessors (like
memcpy_fromio()). When scanning partition headers (e.g., ftl_add_mtd()
reading a 68-byte header via mtd_read()), arm64's memcpy implementation
issues pair-load (ldp) instructions at unaligned offsets, which triggers
an alignment fault (FSC = 0x21) on Device memory and crashes the kernel.

In phram_read/write/erase(), standard memory accessors are used when in
a cached; otherwise, I/O memory accessors are used.

Fixes: f3d45ac21e46 ("mtd: phram: Module parameters add writable permissions")
Fixes: 285133040e6c ("arm64: Import latest memcpy()/memmove() implementation")
Reported-by: syzbot+ee09ee2112d03c35f1f7@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=ee09ee2112d03c35f1f7
Signed-off-by: Edward Adam Davis <eadavis@sina.com>
---
 drivers/mtd/devices/phram.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index b42cadcd76b1..95bd5a9d7e48 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -43,8 +43,13 @@ static LIST_HEAD(phram_list);
 static int phram_erase(struct mtd_info *mtd, struct erase_info *instr)
 {
 	u_char *start = mtd->priv;
+	struct device_node *np = mtd_get_of_node(mtd);
+	bool cached = np ? !of_property_read_bool(np, "no-map") : false;
 
-	memset(start + instr->addr, 0xff, instr->len);
+	if (cached)
+		memset(start + instr->addr, 0xff, instr->len);
+	else
+		memset_io(start + instr->addr, 0xff, instr->len);
 
 	return 0;
 }
@@ -66,8 +71,13 @@ static int phram_read(struct mtd_info *mtd, loff_t from, size_t len,
 		size_t *retlen, u_char *buf)
 {
 	u_char *start = mtd->priv;
+	struct device_node *np = mtd_get_of_node(mtd);
+	bool cached = np ? !of_property_read_bool(np, "no-map") : false;
 
-	memcpy(buf, start + from, len);
+	if (cached)
+		memcpy(buf, start + from, len);
+	else
+		memcpy_fromio(buf, start + from, len);
 	*retlen = len;
 	return 0;
 }
@@ -76,8 +86,13 @@ static int phram_write(struct mtd_info *mtd, loff_t to, size_t len,
 		size_t *retlen, const u_char *buf)
 {
 	u_char *start = mtd->priv;
+	struct device_node *np = mtd_get_of_node(mtd);
+	bool cached = np ? !of_property_read_bool(np, "no-map") : false;
 
-	memcpy(start + to, buf, len);
+	if (cached)
+		memcpy(start + to, buf, len);
+	else
+		memcpy_fromio(start + to, buf, len);
 	*retlen = len;
 	return 0;
 }
-- 
2.43.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-20  4:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  1:49 [syzbot] [mtd?] BUG: unable to handle kernel paging request in phram_read syzbot
2026-11-18  1:49 ` syzbot
2026-11-20  4:37 ` Edward Adam Davis [this message]
2026-11-20  4:37   ` [PATCH] mtd: Use I/O memory accessors when in an uncached Edward Adam Davis
2026-11-20  4:47   ` sashiko-bot
2026-11-20  5:24     ` [PATCH v2] " Edward Adam Davis
2026-11-20  5:35       ` sashiko-bot
2026-11-20  8:25         ` Miquel Raynal
2026-11-20  9:44           ` Edward Adam Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120043709.99845-1-eadavis@sina.com \
    --to=eadavis@sina.com \
    --cc=joern@lazybastard.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=syzbot+ee09ee2112d03c35f1f7@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.