All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: u-boot@lists.u-boot-project.org,
	Dave Klotz <DaveWK225@protonmail.com>,
	Eric Chung <eric.chung@riscstar.com>,
	Hung-Chun Tseng <alan.tseng.cs@gmail.com>,
	E Shattow <e@freeshell.de>, Tom Rini <trini@konsulko.com>,
	Johan Jonker <jbx6244@gmail.com>,
	Raymond Mao <raymond.mao@riscstar.com>
Subject: Re: [PATCH v1 4/6] gpio: spacemit: Add SPL support for K1 GPIO driver
Date: Fri, 20 Nov 2026 05:58:42 +0000	[thread overview]
Message-ID: <20261120055842-GKE156369@kernel.org> (raw)
In-Reply-To: <20261029134705.3767-5-linux.amoon@gmail.com>

Hi Anand,

Can you split out patch 4, 5 and send a v2? I'd like to
 take them first..

On 19:16 Thu 29 Oct     , Anand Moon wrote:
> Add SPL_SPACEMIT_GPIO to enable the SpacemiT K1 GPIO driver
> during SPL initialization.
> 
..
> Depend on SPL_DM_GPIO and TARGET_SPACEMIT_K1, and select
> SPACEMIT_GPIO to reuse the existing driver implementation.
> 
I'd rather drop above explanation, it's quite obvious from
reading the code..

> This allows SPL to access GPIOs required for early board
s/This allows/Allow/, use imperative mood
> initialization.
> 
Any specific user of the GPIO? Can you add more detail, I can
 think of reason that SdCard's Dectect pin will use gpio.. 

> Cc: Dave Klotz <DaveWK225@protonmail.com>
> Cc: Eric Chung <eric.chung@riscstar.com>
> Cc: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
> Cc: E Shattow <e@freeshell.de>
> Cc: Yixun Lan <dlan@kernel.org>
Can you put CC list in cover letter? I'd rather not apply them..
or possibly under line "---" if you want specific CC in single
patch? and of course it works..

> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  drivers/gpio/Kconfig | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 7f12e39dad8..3be6a9e54fa 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -457,6 +457,13 @@ config SPACEMIT_GPIO
>  	  arranged into a number of banks (different for each SoC type) each
>  	  with 32 GPIOs.
>  
> +config SPL_SPACEMIT_GPIO
> +	bool "Spacemit K1 GPIO driver in SPL"
    just "SpacemiT GPIO driver in SPL", which also make it work for K3,
so let's not only mention for K1..

> +	 depends on SPL_DM_GPIO && TARGET_SPACEMIT_K1
I'd also like to see it enabled in K3 platform, so how about

	 depends on SPL_DM_GPIO && (TARGET_SPACEMIT_K1 || TARGET_SPACEMIT_K3)
or simply remove platform contraint..
	 depends on SPL_DM_GPIO

> +	 select SPACEMIT_GPIO
> +	 help
> +	   Enable the Spacemit K1 GPIO driver in SPL.
> +	   This allows SPL to configure GPIOs during early board initialization.
>  
>  config SUNXI_GPIO
>  	bool "Allwinner GPIO driver"
> -- 
> 2.56.0
> 

-- 
Yixun Lan (dlan)

  reply	other threads:[~2026-11-20  5:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 13:46 [PATCH v1 0/6] riscv: dts: spacemit: Improve K1 SPL support Anand Moon
2026-10-29 13:46 ` [PATCH v1 1/6] riscv: dts: spacemit: Clean Up K1 U-Boot Device Tree for SPL Initialization Anand Moon
2026-10-31 11:54   ` Hung-Chun Tseng
2026-10-31 11:56   ` Hung-Chun Tseng
2026-10-31 16:45     ` Anand Moon
2026-10-31 18:15       ` E Shattow
2026-11-02  7:40         ` Anand Moon
2026-10-29 13:46 ` [PATCH v1 2/6] mmc: spacemit_sdhci: Improve voltage switching diagnostics Anand Moon
2026-10-29 13:46 ` [PATCH v1 3/6] mmc: spacemit_sdhci: Handle missing pinctrl states Anand Moon
2026-10-29 13:46 ` [PATCH v1 4/6] gpio: spacemit: Add SPL support for K1 GPIO driver Anand Moon
2026-11-20  5:58   ` Yixun Lan [this message]
2026-10-29 13:46 ` [PATCH v1 5/6] pinctrl: spacemit: Add SPL support for K1 pinctrl driver Anand Moon
2026-11-20  6:12   ` Yixun Lan
2026-10-29 13:46 ` [PATCH v1 6/6] configs: spacemit_k1: Enable SPL GPIO and pinctrl support Anand Moon
2026-11-20  6:19   ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120055842-GKE156369@kernel.org \
    --to=dlan@kernel.org \
    --cc=DaveWK225@protonmail.com \
    --cc=alan.tseng.cs@gmail.com \
    --cc=e@freeshell.de \
    --cc=eric.chung@riscstar.com \
    --cc=jbx6244@gmail.com \
    --cc=linux.amoon@gmail.com \
    --cc=raymond.mao@riscstar.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.