From: Yixun Lan <dlan@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: u-boot@lists.u-boot-project.org,
Dave Klotz <DaveWK225@protonmail.com>,
Eric Chung <eric.chung@riscstar.com>,
Hung-Chun Tseng <alan.tseng.cs@gmail.com>,
E Shattow <e@freeshell.de>, Huan Zhou <pericycle.cc@gmail.com>,
Tom Rini <trini@konsulko.com>, Guodong Xu <guodong@riscstar.com>,
Raymond Mao <raymond.mao@riscstar.com>,
u-boot-spacemit@groups.io
Subject: Re: [PATCH v1 6/6] configs: spacemit_k1: Enable SPL GPIO and pinctrl support
Date: Fri, 20 Nov 2026 06:19:55 +0000 [thread overview]
Message-ID: <20261120061955-GKG156369@kernel.org> (raw)
In-Reply-To: <20261029134705.3767-7-linux.amoon@gmail.com>
Hi Anand,
With those two mmc patches 2,3, which should be used for switching
i/o pins to 1.8v, so can you check if it able to work in UHS mode?
try with CONFIG_MMC_UHS_SUPPORT enabled?
On 19:16 Thu 29 Oct , Anand Moon wrote:
> Enable GPIO and pinctrl support in SPL for SpacemiT K1 boards
> to support early board initialization and SD card boot.
>
> Enable SPL MMC I/O voltage switching and configure the shared
> K1 U-Boot device tree include for the supported boards.
>
> Also enable MTD and SPI NOR partition support with the default
> flash partition layout.
>
> Configure a 2 MiB SPL simple malloc buffer for early allocations.
> Enable regulator commands, SPL GPIO and pinctrl support, and
> SPL MMC I/O voltage switching.
>
> Cc: Dave Klotz <DaveWK225@protonmail.com>
> Cc: Eric Chung <eric.chung@riscstar.com>
> Cc: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
> Cc: E Shattow <e@freeshell.de>
> Cc: Yixun Lan <dlan@kernel.org>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> configs/spacemit_k1_defconfig | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/configs/spacemit_k1_defconfig b/configs/spacemit_k1_defconfig
> index 8ee9baa13b7..04b5ec4f700 100644
> --- a/configs/spacemit_k1_defconfig
> +++ b/configs/spacemit_k1_defconfig
> @@ -3,10 +3,10 @@ CONFIG_SYS_MALLOC_LEN=0x1000000
> CONFIG_SYS_MALLOC_F_LEN=0x10000
> CONFIG_NR_DRAM_BANKS=2
> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x1000000
> +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x1200000
> CONFIG_DM_GPIO=y
> CONFIG_SPL_DM_SPI=y
..
> -CONFIG_DEFAULT_DEVICE_TREE="spacemit/k1-musepi-pro"
> +CONFIG_DEFAULT_DEVICE_TREE="spacemit/k1-bananapi-f3"
no need to change
> CONFIG_SPL_SYS_MALLOC_F_LEN=0x4000
> CONFIG_SPL_MMC=y
> CONFIG_SPL_STACK_R_ADDR=0xc00000
> @@ -63,10 +63,12 @@ CONFIG_CMD_PCI=y
> CONFIG_CMD_SPI=y
> CONFIG_CMD_USB=y
> CONFIG_CMD_EXT4=y
> +CONFIG_CMD_REGULATOR=y
> CONFIG_CMD_FAT=y
> CONFIG_EFI_PARTITION=y
> CONFIG_OF_UPSTREAM=y
> -CONFIG_OF_LIST="spacemit/k1-bananapi-f3 spacemit/k1-musepi-pro"
> +CONFIG_DEVICE_TREE_INCLUDES="spacemit-k1-u-boot.dtsi"
..
> +CONFIG_OF_LIST="spacemit/k1-bananapi-f3 spacemit/k1-musepi-pro spacemit/k1-milkv-jupiter"
ditto
> CONFIG_MULTI_DTB_FIT=y
> CONFIG_ENV_OVERWRITE=y
> CONFIG_SPL_DM_SEQ_ALIAS=y
> @@ -117,3 +119,15 @@ CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_GENERIC=y
> CONFIG_USB_STORAGE=y
> CONFIG_SPL_LIB_RATIONAL=y
> +CONFIG_SPL_GPIO=y
> +CONFIG_SPL_DM_GPIO=y
> +CONFIG_SPL_PINCTRL=y
> +CONFIG_SPL_SPACEMIT_GPIO=y
> +CONFIG_SPL_PINCTRL_SPACEMIT_K1=y
> +CONFIG_SPL_MMC_IO_VOLTAGE=y
> +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x200000
> +CONFIG_CMD_MTD=y
> +CONFIG_CMD_MTDPARTS=y
> +CONFIG_SPI_FLASH_MTD=y
> +CONFIG_MTDIDS_DEFAULT="nor0=spi0.0"
> +CONFIG_MTDPARTS_DEFAULT="spi0.0:128k(bootinfo),512k(fsbl),64k(env),1024k(esos),384k(opensbi),-(uboot)"
> --
> 2.56.0
>
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-11-20 6:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 13:46 [PATCH v1 0/6] riscv: dts: spacemit: Improve K1 SPL support Anand Moon
2026-10-29 13:46 ` [PATCH v1 1/6] riscv: dts: spacemit: Clean Up K1 U-Boot Device Tree for SPL Initialization Anand Moon
2026-10-31 11:54 ` Hung-Chun Tseng
2026-10-31 11:56 ` Hung-Chun Tseng
2026-10-31 16:45 ` Anand Moon
2026-10-31 18:15 ` E Shattow
2026-11-02 7:40 ` Anand Moon
2026-10-29 13:46 ` [PATCH v1 2/6] mmc: spacemit_sdhci: Improve voltage switching diagnostics Anand Moon
2026-10-29 13:46 ` [PATCH v1 3/6] mmc: spacemit_sdhci: Handle missing pinctrl states Anand Moon
2026-10-29 13:46 ` [PATCH v1 4/6] gpio: spacemit: Add SPL support for K1 GPIO driver Anand Moon
2026-11-20 5:58 ` Yixun Lan
2026-10-29 13:46 ` [PATCH v1 5/6] pinctrl: spacemit: Add SPL support for K1 pinctrl driver Anand Moon
2026-11-20 6:12 ` Yixun Lan
2026-10-29 13:46 ` [PATCH v1 6/6] configs: spacemit_k1: Enable SPL GPIO and pinctrl support Anand Moon
2026-11-20 6:19 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120061955-GKG156369@kernel.org \
--to=dlan@kernel.org \
--cc=DaveWK225@protonmail.com \
--cc=alan.tseng.cs@gmail.com \
--cc=e@freeshell.de \
--cc=eric.chung@riscstar.com \
--cc=guodong@riscstar.com \
--cc=linux.amoon@gmail.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.