All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c: acpi: Limit DLL0945 100 kHz quirk to Dell Precision 5560 and XPS 15 9510
@ 2026-11-19 14:32 Paul Menzel
  2026-11-20  7:19 ` Mika Westerberg
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Menzel @ 2026-11-19 14:32 UTC (permalink / raw)
  To: Mika Westerberg, Andi Shyti, Wolfram Sang, fangzhong.zhou
  Cc: Hans de Goede, Dell.Client.Kernel, Paul Menzel, linux-i2c,
	linux-acpi, linux-kernel

Commit 0b7c9528facd ("i2c: Force DLL0945 touchpad i2c freq to 100khz")
forces the I2C bus to 100 kHz for all devices with the ACPI ID DLL0945 to
work around a sluggish cursor on the Dell Precision 5560. But DLL0945 does
not identify a touchpad model. Dell uses it for touchpads from different
vendors:

    System                Touchpad
    Dell Precision 5560   ELAN 04F3:311C
    Dell XPS 15 9510      ELAN 04F3:311C (bugzilla #214597)
    Dell XPS 13 9310      Synaptics 06CB:CDE6

The ELAN touchpads are the ones known to need 100 kHz, but the Synaptics
touchpad of the Dell XPS 13 9310 is slowed down without need. Its DSDT
specifies 400 kHz, and Linux logs:

    i2c_designware i2c_designware.0: [Firmware Bug]: DSDT uses known not-working I2C bus speed 400000, forcing it to 100000

The touchpad scans every 7.1 ms (scan time field in the input report), and
i2c-hid reads wMaxInputLength (64 bytes) for each report. Tracing the I2C
transfers for 30 seconds of moving a finger on the touchpad shows:

                             100 kHz   400 kHz
    read time (median)        7.3 ms    2.5 ms
    bus busy                   87 %      36 %
    reports per second          111       140
    frames lost                18.6 %     0 %

At 100 kHz the host cannot keep up with the touchpad, and every fifth frame
is lost. At 400 kHz all frames arrive, and no sluggish cursor was noticed.

So, only apply the DLL0945 entry on the Dell Precision 5560 and XPS 15 9510
by pointing the entry's driver_data to a DMI table, which can be used to
restrict other entries in the same way.

Tested on the Dell XPS 13 9310.

- The `[Firmware Bug] … forcing it to 100000` line is gone from dmesg.
- Re-probed the touchpad’s I²C controller with debug output on, and it
  reports `Bus speed: Fast Mode (400 kHz)`. The touchpad came back up
  under hid-multitouch.

Fixes: 0b7c9528facd ("i2c: Force DLL0945 touchpad i2c freq to 100khz")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=214597
Cc: Hans de Goede <johannes.goede@oss.qualcomm.com>
Cc: Dell.Client.Kernel@dell.com
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---

Notes:
    Based on andi/i2c/i2c-next (9c19b1c07854) with Mika Westerberg's
    "[PATCH v2] i2c: acpi: Force Dell XPS 17 9720 touchpad to 100 kHz"
    <20261118073607.297350-1-mika.westerberg@linux.intel.com> applied, as
    both change the same table.

    https://lore.kernel.org/linux-i2c/20261118073607.297350-1-mika.westerberg@linux.intel.com/


    Claude Opus 5.5 (Claude Code) helped analyze the I2C traces, write the
    code and draft the commit message.

 drivers/i2c/i2c-core-acpi.c | 36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
index 64fdf8ffb5ffe..8feb3cb205fdd 100644
--- a/drivers/i2c/i2c-core-acpi.c
+++ b/drivers/i2c/i2c-core-acpi.c
@@ -7,6 +7,7 @@
 
 #include <linux/acpi.h>
 #include <linux/device.h>
+#include <linux/dmi.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
 #include <linux/list.h>
@@ -356,6 +357,31 @@ static const struct acpi_device_id i2c_acpi_force_400khz_device_ids[] = {
 	{ }
 };
 
+/*
+ * Dell uses DLL0945 for touchpads from different vendors. The ELAN 04F3:311C
+ * touchpad of these systems needs 100 kHz, but for example the Synaptics
+ * 06CB:CDE6 touchpad of the Dell XPS 13 9310 works fine at 400 kHz.
+ */
+static const struct dmi_system_id i2c_acpi_dll0945_dmi_ids[] = {
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Precision 5560"),
+		},
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9510"),
+		},
+	},
+	{ }
+};
+
+/*
+ * If driver_data is set, it points to a DMI table, and the entry only applies
+ * to the systems in that table.
+ */
 static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	/*
 	 * When a 400KHz freq is used on this model of ELAN touchpad in Linux,
@@ -373,7 +399,10 @@ static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	 */
 	{ .id = "ASUE140D" },
 	{ .id = "DELL0A86" },
-	{ .id = "DLL0945" },
+	{
+		.id = "DLL0945",
+		.driver_data = (kernel_ulong_t)i2c_acpi_dll0945_dmi_ids,
+	},
 	{ .id = "ELAN0678" },
 	{ .id = "ELAN06FA" },
 	{ .id = "ELAN1300" },
@@ -391,6 +420,7 @@ static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
 {
 	struct i2c_acpi_lookup *lookup = data;
 	struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
+	const struct acpi_device_id *id;
 
 	if (!adev || i2c_acpi_do_lookup(adev, lookup))
 		return AE_OK;
@@ -404,7 +434,9 @@ static acpi_status i2c_acpi_lookup_speed(acpi_handle handle, u32 level,
 	if (acpi_match_device_ids(adev, i2c_acpi_force_400khz_device_ids) == 0)
 		lookup->force_speed = I2C_MAX_FAST_MODE_FREQ;
 
-	if (acpi_match_device_ids(adev, i2c_acpi_force_100khz_device_ids) == 0)
+	id = acpi_match_acpi_device(i2c_acpi_force_100khz_device_ids, adev);
+	if (id && (!id->driver_data ||
+		   dmi_check_system((const struct dmi_system_id *)id->driver_data)))
 		lookup->force_speed = I2C_MAX_STANDARD_MODE_FREQ;
 
 	return AE_OK;
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-20  7:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 14:32 [PATCH] i2c: acpi: Limit DLL0945 100 kHz quirk to Dell Precision 5560 and XPS 15 9510 Paul Menzel
2026-11-20  7:19 ` Mika Westerberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.