* [linux-next:master 6175/9862] drivers/phy/rockchip/phy-rockchip-inno-usb2.c:495:5-8: Unneeded variable: "ret". Return "0" on line 534
@ 2026-11-20 7:02 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-11-20 7:02 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: oe-kbuild-all, Vinod Koul
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: adcad7f4e6332cff3d6d7165f41584899f598534
commit: d5162b71dc6ebf997a9f64dab89ffd3bf9ebcb9b [6175/9862] phy: rockchip: inno-usb2: ignore regmap_write return codes
config: arm-randconfig-r2109-20261120 (https://download.01.org/0day-ci/archive/20261120/20261120075259.lBe4Stwa-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 8db60b003f961f25c5cafe91ee44176f61374279)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/20261120075259.lBe4Stwa-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/phy/rockchip/phy-rockchip-inno-usb2.c:495:5-8: Unneeded variable: "ret". Return "0" on line 534
vim +495 drivers/phy/rockchip/phy-rockchip-inno-usb2.c
3a7db8e9edefd9e drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2023-05-22 490
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 491 static int rockchip_usb2phy_init(struct phy *phy)
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 492 {
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 493 struct rockchip_usb2phy_port *rport = phy_get_drvdata(phy);
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 494 struct rockchip_usb2phy *rphy = dev_get_drvdata(phy->dev.parent);
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 @495 int ret = 0;
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 496
dd341fe270a274f drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 497 dev_dbg(&phy->dev, "phy port init\n");
dd341fe270a274f drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 498
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 499 mutex_lock(&rport->mutex);
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 500
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 501 if (rport->port_id == USB2PHY_PORT_OTG) {
9632781122e5f7a drivers/phy/rockchip/phy-rockchip-inno-usb2.c William Wu 2017-06-02 502 if (rport->mode != USB_DR_MODE_HOST &&
9632781122e5f7a drivers/phy/rockchip/phy-rockchip-inno-usb2.c William Wu 2017-06-02 503 rport->mode != USB_DR_MODE_UNKNOWN) {
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 504 /* clear bvalid status and enable bvalid detect irq */
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 505 property_enable(rphy->grf, &rport->port_cfg->bvalid_det_clr, true);
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 506 property_enable(rphy->grf, &rport->port_cfg->bvalid_det_en, true);
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 507
2fda59099462ee7 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Alex Bee 2023-11-19 508 /* clear id status and enable id detect irqs */
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 509 property_enable(rphy->grf, &rport->port_cfg->idfall_det_clr, true);
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 510 property_enable(rphy->grf, &rport->port_cfg->idrise_det_clr, true);
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 511 property_enable(rphy->grf, &rport->port_cfg->idfall_det_en, true);
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 512 property_enable(rphy->grf, &rport->port_cfg->idrise_det_en, true);
51a9b2c03dd3fdd drivers/phy/rockchip/phy-rockchip-inno-usb2.c Samuel Holland 2022-04-13 513
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 514 schedule_delayed_work(&rport->otg_sm_work,
5a74a8b74233f0e drivers/phy/rockchip/phy-rockchip-inno-usb2.c William Wu 2017-06-02 515 OTG_SCHEDULE_DELAY * 3);
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 516 } else {
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 517 /* If OTG works in host only mode, do nothing. */
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 518 dev_dbg(&rport->phy->dev, "mode %d\n", rport->mode);
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 519 }
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 520 } else if (rport->port_id == USB2PHY_PORT_HOST) {
3a7db8e9edefd9e drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2023-05-22 521 if (rport->port_cfg->disfall_en.offset) {
3a7db8e9edefd9e drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2023-05-22 522 rport->host_disconnect = true;
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 523 rockchip_usb2phy_enable_host_disc_irq(rphy, rport, true);
3a7db8e9edefd9e drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2023-05-22 524 }
3a7db8e9edefd9e drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2023-05-22 525
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 526 /* clear linestate and enable linestate detect irq */
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 527 property_enable(rphy->grf, &rport->port_cfg->ls_det_clr, true);
d5162b71dc6ebf9 drivers/phy/rockchip/phy-rockchip-inno-usb2.c Sebastian Reichel 2026-11-10 528 property_enable(rphy->grf, &rport->port_cfg->ls_det_en, true);
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 529
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 530 schedule_delayed_work(&rport->sm_work, SCHEDULE_DELAY);
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 531 }
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 532
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 533 mutex_unlock(&rport->mutex);
98898f3bc83c8a7 drivers/phy/phy-rockchip-inno-usb2.c William Wu 2016-11-07 @534 return ret;
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 535 }
0e08d2a727e68bb drivers/phy/phy-rockchip-inno-usb2.c Frank Wang 2016-07-22 536
:::::: The code at line 495 was first introduced by commit
:::::: 98898f3bc83c8a74e562869332cb1b349976a116 phy: rockchip-inno-usb2: support otg-port for rk3399
:::::: TO: William Wu <wulf@rock-chips.com>
:::::: CC: Kishon Vijay Abraham I <kishon@ti.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-20 7:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 7:02 [linux-next:master 6175/9862] drivers/phy/rockchip/phy-rockchip-inno-usb2.c:495:5-8: Unneeded variable: "ret". Return "0" on line 534 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.