From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: "kernel test robot" <yi1.lai@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org, aubrey.li@linux.intel.com,
yu.c.chen@intel.com, ltp@lists.linux.it, cgroups@vger.kernel.org,
rcu@vger.kernel.org, linux-doc@vger.kernel.org,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Valentin Schneider" <vschneid@redhat.com>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"luca abeni" <luca.abeni@santannapisa.it>,
"Yuri Andriaccio" <yurand2000@gmail.com>,
"Yuri Andriaccio" <yuri.andriaccio@santannapisa.it>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Neeraj Upadhyay" <neeraj.upadhyay@kernel.org>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Josh Triplett" <josh@joshtriplett.org>,
"Boqun Feng" <boqun@kernel.org>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang@linux.dev>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Qais Yousef" <qyousef@layalina.io>,
"John Ogness" <john.ogness@linutronix.de>
Subject: Re: [PATCH v3 6/8] sched: Limit sysctl sched_rt_{period|runtime}_us to RT_GROUP_SCHED
Date: Fri, 20 Nov 2026 16:36:19 +0100 [thread overview]
Message-ID: <20261120153619.gkOojPT4@linutronix.de> (raw)
In-Reply-To: <awBiDzEvUch_5ZJn@jlelli-thinkpadt14gen4.remote.csb>
On 2026-11-20 16:06:55 [+0100], Juri Lelli wrote:
> Hello,
Hi,
> I agree on the RT throttling part. Before this series, writing to them
> does serve a purpose, though. 5/8 moves that functionality to sysfs,
> which leaves the files without a purpose, and 6/8 then removes them. So
> existing users don't lose a useless knob; they lose the working one,
> which has moved somewhere else. LTP is not the only one that will
> notice, I'm afraid.
>
> This is what I meant with "yes and no" in the RFC thread: we need an
> interface for admission control, and I wasn't sure how much breakage
> moving it would cause. Now we have a first data point. :)
>
> You suggested yourself back then to keep the files and make them apply
> to DL only. I think that's something like:
>
> - keep sched_rt_{period,runtime}_us for !RT_GROUP_SCHED, backed by the
> same code as the new dl_{period,runtime}_us (sched_dl_try_boundary()),
> keeping the current validation semantics (the LTP test checks the
> EINVAL cases, and 0 is a valid runtime today)
> - pr_warn_once() on write saying they only control DEADLINE admission
> control and that RT throttling is handled by the fair_server,
> pointing to where its knobs are
> - fix the documentation as you are doing already
>
> That way nobody gets surprised anymore, which was your point, and we
> don't break anyone? We can still discuss deprecating the procfs names
> later, once the new interface has been around for a while maybe?
Doesn't sound bad. Let me respin it with these changes.
Thanks.
> Thanks,
> Juri
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: linux-doc@vger.kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Boqun Feng" <boqun@kernel.org>,
"Yuri Andriaccio" <yuri.andriaccio@santannapisa.it>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
"Ben Segall" <bsegall@google.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Valentin Schneider" <vschneid@redhat.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
yu.c.chen@intel.com, "Jonathan Corbet" <corbet@lwn.net>,
"luca abeni" <luca.abeni@santannapisa.it>,
aubrey.li@linux.intel.com, "Ingo Molnar" <mingo@redhat.com>,
"Mel Gorman" <mgorman@suse.de>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Josh Triplett" <josh@joshtriplett.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
rcu@vger.kernel.org,
"Neeraj Upadhyay" <neeraj.upadhyay@kernel.org>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
cgroups@vger.kernel.org,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
ltp@lists.linux.it, lkp@intel.com, Zqiang <qiang.zhang@linux.dev>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, "Qais Yousef" <qyousef@layalina.io>,
"Tejun Heo" <tj@kernel.org>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Michal Koutný" <mkoutny@suse.com>,
"kernel test robot" <yi1.lai@intel.com>,
oe-lkp@lists.linux.dev,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Yuri Andriaccio" <yurand2000@gmail.com>
Subject: Re: [LTP] [PATCH v3 6/8] sched: Limit sysctl sched_rt_{period|runtime}_us to RT_GROUP_SCHED
Date: Fri, 20 Nov 2026 16:36:19 +0100 [thread overview]
Message-ID: <20261120153619.gkOojPT4@linutronix.de> (raw)
In-Reply-To: <awBiDzEvUch_5ZJn@jlelli-thinkpadt14gen4.remote.csb>
On 2026-11-20 16:06:55 [+0100], Juri Lelli wrote:
> Hello,
Hi,
> I agree on the RT throttling part. Before this series, writing to them
> does serve a purpose, though. 5/8 moves that functionality to sysfs,
> which leaves the files without a purpose, and 6/8 then removes them. So
> existing users don't lose a useless knob; they lose the working one,
> which has moved somewhere else. LTP is not the only one that will
> notice, I'm afraid.
>
> This is what I meant with "yes and no" in the RFC thread: we need an
> interface for admission control, and I wasn't sure how much breakage
> moving it would cause. Now we have a first data point. :)
>
> You suggested yourself back then to keep the files and make them apply
> to DL only. I think that's something like:
>
> - keep sched_rt_{period,runtime}_us for !RT_GROUP_SCHED, backed by the
> same code as the new dl_{period,runtime}_us (sched_dl_try_boundary()),
> keeping the current validation semantics (the LTP test checks the
> EINVAL cases, and 0 is a valid runtime today)
> - pr_warn_once() on write saying they only control DEADLINE admission
> control and that RT throttling is handled by the fair_server,
> pointing to where its knobs are
> - fix the documentation as you are doing already
>
> That way nobody gets surprised anymore, which was your point, and we
> don't break anyone? We can still discuss deprecating the procfs names
> later, once the new interface has been around for a while maybe?
Doesn't sound bad. Let me respin it with these changes.
Thanks.
> Thanks,
> Juri
Sebastian
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-11-20 15:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 10:50 [PATCH v3 0/8] sched: RT throttling cleanup and a bit of documentation Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 1/8] sched/deadline: Reject debugfs dl_server writes for not-active CPUs Sebastian Andrzej Siewior
2026-11-13 14:48 ` Juri Lelli
2026-11-13 15:11 ` Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 2/8] sched: Mark RT_GROUP_SCHED broken Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 3/8] rcutorture: Don't try to disable to RT throttling Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 4/8] sched: rcutorture: Allow to disable DL fair_server Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 5/8] sched: Move DL's admission control to sysfs Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 6/8] sched: Limit sysctl sched_rt_{period|runtime}_us to RT_GROUP_SCHED Sebastian Andrzej Siewior
2026-11-19 14:11 ` kernel test robot
2026-11-19 14:11 ` [LTP] " kernel test robot
2026-11-19 14:23 ` Sebastian Andrzej Siewior
2026-11-19 14:23 ` [LTP] " Sebastian Andrzej Siewior
2026-11-20 15:06 ` Juri Lelli
2026-11-20 15:06 ` [LTP] " Juri Lelli via ltp
2026-11-20 15:36 ` Sebastian Andrzej Siewior [this message]
2026-11-20 15:36 ` Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 7/8] sched: Add sysfs files for the per-CPU fair_server knobs Sebastian Andrzej Siewior
2026-11-13 10:50 ` [PATCH v3 8/8] Documentation/sched: Add fairserver to sched-deadline Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120153619.gkOojPT4@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=aubrey.li@linux.intel.com \
--cc=boqun@kernel.org \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dave@stgolabs.net \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jiangshanlai@gmail.com \
--cc=joelagnelf@nvidia.com \
--cc=john.ogness@linutronix.de \
--cc=josh@joshtriplett.org \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ltp@lists.linux.it \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=oe-lkp@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=qiang.zhang@linux.dev \
--cc=qyousef@layalina.io \
--cc=rcu@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yi1.lai@intel.com \
--cc=yu.c.chen@intel.com \
--cc=yurand2000@gmail.com \
--cc=yuri.andriaccio@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.