From: Andrey Albershteyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: "fsdevel" <linux-fsdevel@vger.kernel.org>,
"fsverity" <fsverity@lists.linux.dev>,
"linux-ext4" <linux-ext4@vger.kernel.org>,
"linux-btrfs" <linux-btrfs@vger.kernel.org>,
"linux-f2fs" <linux-f2fs-devel@lists.sourceforge.net>,
"linux-xfs" <linux-xfs@vger.kernel.org>,
dsterba@suse.com, "Eric Biggers" <ebiggers@kernel.org>,
"Christian Brauner" <brauner@kernel.org>
Cc: tytso@mit.edu, viro@zeniv.linux.org.uk, jaegeuk@kernel.org,
Boris Burkov <boris@bur.io>,
Andrey Albershteyn <aalbersh@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: [f2fs-dev] [PATCH v3 2/7] fs: strip FS_VERITY_FL from FS_IOC_SETFLAGS
Date: Fri, 20 Nov 2026 16:50:24 +0100 [thread overview]
Message-ID: <20261120155032.187246-3-aalbersh@kernel.org> (raw)
In-Reply-To: <20261120155032.187246-1-aalbersh@kernel.org>
The common use of FS_IOC_GETFLAGS/SETFLAGS is get-modify-set loop.
Filesystems could return verity status with GETFLAGS, attempting to then
pass FS_VERITY_FL to SETFLAGS is not allowed.
The ext4 and f2fs already treat FS_VERITY_FL in the set path as no-op,
however, BTRFS returns -EOPNOTSUPP. So, the modification of other flags
doesn't work on BTRFS for fsverity inodes.
Fix it for BTRFS and anyone else, the ext4 and f2fs masking becomes
no-op. The file_get/setattr() path is fine here as this flag is cleared
right before fileattr_set_prepare(). The future fsverity support in XFS
would also need it.
Cc: Boris Burkov <boris@bur.io>
Cc: David Sterba <dsterba@suse.com>
Fixes: 146054090b08 ("btrfs: initial fsverity support")
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
fs/file_attr.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/fs/file_attr.c b/fs/file_attr.c
index 833e03810b24..81bf55f9b255 100644
--- a/fs/file_attr.c
+++ b/fs/file_attr.c
@@ -199,6 +199,16 @@ static int fileattr_set_prepare(struct inode *inode,
if (err)
return err;
+ /*
+ * FS_VERITY_FL is settable only via FS_IOC_ENABLE_VERITY; never through
+ * fileattr
+ *
+ * Treat it as a no-op so the FS_IOC_GETFLAGS/SETFLAGS round-trip
+ * doesn't break for other flags
+ */
+ fa->flags &= ~FS_VERITY_FL;
+ fa->fsx_xflags &= ~FS_XFLAG_VERITY;
+
/*
* Project Quota ID state is only allowed to change from within the init
* namespace. Enforce that restriction only if we are trying to change
--
2.54.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Albershteyn <aalbersh@kernel.org>
To: "fsdevel" <linux-fsdevel@vger.kernel.org>,
"fsverity" <fsverity@lists.linux.dev>,
"linux-ext4" <linux-ext4@vger.kernel.org>,
"linux-btrfs" <linux-btrfs@vger.kernel.org>,
"linux-f2fs" <linux-f2fs-devel@lists.sourceforge.net>,
"linux-xfs" <linux-xfs@vger.kernel.org>,
dsterba@suse.com, "Eric Biggers" <ebiggers@kernel.org>,
"Christian Brauner" <brauner@kernel.org>
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
tytso@mit.edu, chao@kernel.org, jaegeuk@kernel.org,
viro@zeniv.linux.org.uk, Boris Burkov <boris@bur.io>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH v3 2/7] fs: strip FS_VERITY_FL from FS_IOC_SETFLAGS
Date: Fri, 20 Nov 2026 16:50:24 +0100 [thread overview]
Message-ID: <20261120155032.187246-3-aalbersh@kernel.org> (raw)
In-Reply-To: <20261120155032.187246-1-aalbersh@kernel.org>
The common use of FS_IOC_GETFLAGS/SETFLAGS is get-modify-set loop.
Filesystems could return verity status with GETFLAGS, attempting to then
pass FS_VERITY_FL to SETFLAGS is not allowed.
The ext4 and f2fs already treat FS_VERITY_FL in the set path as no-op,
however, BTRFS returns -EOPNOTSUPP. So, the modification of other flags
doesn't work on BTRFS for fsverity inodes.
Fix it for BTRFS and anyone else, the ext4 and f2fs masking becomes
no-op. The file_get/setattr() path is fine here as this flag is cleared
right before fileattr_set_prepare(). The future fsverity support in XFS
would also need it.
Cc: Boris Burkov <boris@bur.io>
Cc: David Sterba <dsterba@suse.com>
Fixes: 146054090b08 ("btrfs: initial fsverity support")
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
fs/file_attr.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/fs/file_attr.c b/fs/file_attr.c
index 833e03810b24..81bf55f9b255 100644
--- a/fs/file_attr.c
+++ b/fs/file_attr.c
@@ -199,6 +199,16 @@ static int fileattr_set_prepare(struct inode *inode,
if (err)
return err;
+ /*
+ * FS_VERITY_FL is settable only via FS_IOC_ENABLE_VERITY; never through
+ * fileattr
+ *
+ * Treat it as a no-op so the FS_IOC_GETFLAGS/SETFLAGS round-trip
+ * doesn't break for other flags
+ */
+ fa->flags &= ~FS_VERITY_FL;
+ fa->fsx_xflags &= ~FS_XFLAG_VERITY;
+
/*
* Project Quota ID state is only allowed to change from within the init
* namespace. Enforce that restriction only if we are trying to change
--
2.54.0
next prev parent reply other threads:[~2026-11-20 15:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:50 [f2fs-dev] [PATCH v3 0/7] fsverity: lift ioctl() input masking and runtime inode flag to VFS Andrey Albershteyn via Linux-f2fs-devel
2026-11-20 15:50 ` Andrey Albershteyn
2026-11-20 15:50 ` [f2fs-dev] [PATCH v3 1/7] fs: constify inode argument of inode_state_read_once() Andrey Albershteyn via Linux-f2fs-devel
2026-11-20 15:50 ` Andrey Albershteyn
2026-11-20 15:58 ` sashiko-bot
2026-11-20 15:58 ` sashiko-bot
2026-11-20 15:50 ` Andrey Albershteyn via Linux-f2fs-devel [this message]
2026-11-20 15:50 ` [PATCH v3 2/7] fs: strip FS_VERITY_FL from FS_IOC_SETFLAGS Andrey Albershteyn
2026-11-20 16:00 ` sashiko-bot
2026-11-20 16:02 ` sashiko-bot
2026-11-20 15:50 ` [PATCH v3 3/7] fs,fsverity: add I_VERITY_BUILDING inode state flag Andrey Albershteyn
2026-11-20 15:50 ` [f2fs-dev] [PATCH v3 3/7] fs, fsverity: " Andrey Albershteyn via Linux-f2fs-devel
2026-11-20 16:01 ` [PATCH v3 3/7] fs,fsverity: " sashiko-bot
2026-11-20 16:01 ` sashiko-bot
2026-11-20 15:50 ` [PATCH v3 4/7] iomap: use fsverity_is_building() to check for fsverity IO Andrey Albershteyn
2026-11-20 15:50 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-20 16:13 ` sashiko-bot
2026-11-20 16:21 ` sashiko-bot
2026-11-20 16:42 ` Andrey Albershteyn
2026-11-20 15:50 ` [PATCH v3 5/7] btrfs: use I_VERITY_BUILDING instead of private flags Andrey Albershteyn
2026-11-20 15:50 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-20 15:58 ` sashiko-bot
2026-11-20 15:59 ` sashiko-bot
2026-11-20 15:50 ` [PATCH v3 6/7] ext4: " Andrey Albershteyn
2026-11-20 15:50 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-20 16:00 ` sashiko-bot
2026-11-20 16:01 ` sashiko-bot
2026-11-20 15:50 ` [PATCH v3 7/7] f2fs: " Andrey Albershteyn
2026-11-20 15:50 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-20 15:58 ` sashiko-bot
2026-11-20 16:01 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120155032.187246-3-aalbersh@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=aalbersh@kernel.org \
--cc=boris@bur.io \
--cc=brauner@kernel.org \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.