From: Mehmet Fide <mehmet.fide@gmail.com>
To: Luka Gejak <luka.gejak@linux.dev>, Ping-Ke Shih <pkshih@realtek.com>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v13 2/3] wifi: rtw88: support channel switch in AP mode
Date: Fri, 20 Nov 2026 18:03:22 +0100 [thread overview]
Message-ID: <20261120170322.375333-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <20261120141554.68116-1-luka.gejak@linux.dev>
Hi Luka,
> I think this can finish before the last count gets a TBTT if the work
> runs a full interval late.
Right, at this commit. With a test build that delays the step at count
2 by 150 ms, count 1 never went on the air with 2/3 alone (0 of 5 runs)
and always did with 3/3 applied (5 of 5). I kept the TBTT pacing in its
own patch to keep 2/3 easier to review. If Ping-Ke prefers, v14 can
carry it in 2/3.
> What happens if the page can never fit? On RTL8821C the driver has
> eight 128 byte pages.
The switch would stay pending, but hostapd refuses such a request
first. On an RTL8821CU at 2.4 GHz a beacon still fit with 778 bytes of
vendor elements, while hostapd could not build the channel switch
request above 586 bytes ("nl80211: Could not build channel switch
request"). That message carries the beacon and the probe response
twice, before and after the switch, in the default 4 KB of
nlmsg_alloc(). No chip has less than eight 128 byte pages, and an AP
next to a station interface is only possible on the RTL8822C, which has
16. So I would rather not add a reject path that cannot be reached.
> Could we retry the first beacon download after the switch too?
[ ... ]
> Could we queue a retry for the station if this refresh fails?
Neither download is retried, like every other beacon update in rtw88
today. In about 2360 kernel logs from our test runs, a reserved page
download failed only in unbind and firmware crash tests, and with one
experimental change that is not in this series. I would keep both
paths as they are.
Mehmet
next prev parent reply other threads:[~2026-11-20 17:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 23:19 [PATCH rtw-next v13 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-18 23:19 ` [PATCH rtw-next v13 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-18 23:19 ` [PATCH rtw-next v13 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-20 14:15 ` Luka Gejak
2026-11-20 17:03 ` Mehmet Fide [this message]
2026-11-18 23:19 ` [PATCH rtw-next v13 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-11-20 14:15 ` Luka Gejak
2026-11-20 17:03 ` Mehmet Fide
2026-11-19 5:38 ` [PATCH rtw-next v13 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120170322.375333-1-mehmet.fide@gmail.com \
--to=mehmet.fide@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=mehmet.fide@screeningeagle.com \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.