All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Mehmet Fide <mehmet.fide@gmail.com>, Ping-Ke Shih <pkshih@realtek.com>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v13 3/3] wifi: rtw88: time the countdown downloads from the TBTT
Date: Fri, 20 Nov 2026 15:15:53 +0100	[thread overview]
Message-ID: <20261120141554.68116-2-luka.gejak@linux.dev> (raw)
In-Reply-To: <20261118231940.3950-4-mehmet.fide@gmail.com>

Hi Mehmet,

Thanks for the v13. One comment below.

On November 19, 2026 12:19:40 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:

> diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
> index 9d5df3e65b97..c24932d00e14 100644
> --- a/drivers/net/wireless/realtek/rtw88/fw.c
> +++ b/drivers/net/wireless/realtek/rtw88/fw.c

[ ... ]

> +	div_u64_rem(rtw_fw_read_tsf(rtwdev), interval, &rem);
> +	delay = interval - rem;
> +	if (delay < RTW_CSA_TBTT_MARGIN_US)
> +		delay += interval;

[ ... ]

> +				     usecs_to_jiffies(delay +
> +						      RTW_CSA_TBTT_MARGIN_US));

Does the short interval case need a smaller margin here as well?
With a beacon interval of 19 TU and a download that finishes 10 ms
after a TBTT, the next two TBTTs are about 9.5 and 28.9 ms away. This
queues the next step about 38.9 ms later, two beacon intervals away.

Several counts can then go out twice even when the work runs on time.
That seems to put the AP further behind a station that timed its
switch from an earlier count. Could the queue and hold paths use a
margin that fits the beacon interval?

Best regards,
Luka Gejak

  reply	other threads:[~2026-11-20 14:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:19 [PATCH rtw-next v13 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-18 23:19 ` [PATCH rtw-next v13 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-18 23:19 ` [PATCH rtw-next v13 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-20 14:15   ` Luka Gejak
2026-11-20 17:03     ` Mehmet Fide
2026-11-18 23:19 ` [PATCH rtw-next v13 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-11-20 14:15   ` Luka Gejak [this message]
2026-11-20 17:03     ` Mehmet Fide
2026-11-19  5:38 ` [PATCH rtw-next v13 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120141554.68116-2-luka.gejak@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.