All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] nvme: fabrics and target fixes
@ 2026-11-16  8:12 Guixin Liu
  2026-11-16  8:12 ` [PATCH v3 1/2] nvme-fc: fix use-after-free in nvme_fc_match_disconn_ls() Guixin Liu
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Guixin Liu @ 2026-11-16  8:12 UTC (permalink / raw)
  To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
	Nilay Shroff, Daniel Wagner, Hannes Reinecke
  Cc: linux-nvme

Two remaining fixes from the previous rounds of this series:

 - a use-after-free in nvme_fc_match_disconn_ls(): no iterator is
   sound across the rport lock drop inside the loop, so the loop is
   reworked to run entirely under the rport lock and to take a
   reference only for the match; reproduced under KASAN through fcloop
 - a data race on the shared authentication transaction counter,
   reworked per review to a per-queue counter, dropping the shared
   ctrl->transaction field entirely

The other three patches from v2 are already resolved: the GFP_KERNEL
persistent reservation change and the tbkas configfs locking are in
nvme-7.4 now, and the reconnect_delay fix was superseded by an earlier
identical patch posted by someone else.

Both patches are verified on an initiator/target VM pair: the fc loop
is compile tested and exercised under KASAN through fcloop with six
controllers on one remote port across tbkas force-reconnect cycles
and concurrent disconnects with no reports; the
DH-HMAC-CHAP authenticated session including I/O covers the auth path.

Changes since v2:

 - rework the nvme-auth fix to a per-queue counter (Keith Busch),
   drop the now unused shared field, and add the Fixes tag (sashiko);
   the Reviewed-by on v2 covered the atomic_t variant and is dropped
 - resend the unchanged nvme-fc patch, still awaiting review
 - drop the reconnect_delay patch (superseded), the GFP_KERNEL patch
   (applied) and the tbkas patch (applied)

Link: https://lore.kernel.org/all/20261109022646.290792-1-kanie@linux.alibaba.com/

Guixin Liu (2):
  nvme-fc: fix use-after-free in nvme_fc_match_disconn_ls()
  nvme-auth: fix data race on ctrl->transaction

 drivers/nvme/host/auth.c |  3 +--
 drivers/nvme/host/fc.c   | 22 ++++++++++++----------
 drivers/nvme/host/nvme.h |  1 -
 3 files changed, 13 insertions(+), 13 deletions(-)

-- 
2.43.7



^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-11-20 19:55 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16  8:12 [PATCH v3 0/2] nvme: fabrics and target fixes Guixin Liu
2026-11-16  8:12 ` [PATCH v3 1/2] nvme-fc: fix use-after-free in nvme_fc_match_disconn_ls() Guixin Liu
2026-11-20 17:39   ` Christoph Hellwig
2026-11-16  8:12 ` [PATCH v3 2/2] nvme-auth: fix data race on ctrl->transaction Guixin Liu
2026-11-16 13:22   ` Hannes Reinecke
2026-11-16 15:37     ` Keith Busch
2026-11-17  7:23       ` Hannes Reinecke
2026-11-19  2:49         ` Keith Busch
2026-11-17  2:16     ` Guixin Liu
2026-11-17  7:31       ` Hannes Reinecke
2026-11-20 19:54 ` (subset) [PATCH v3 0/2] nvme: fabrics and target fixes Keith Busch

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.