All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: fbtft: fb_tinylcd: align argument with open parenthesis
@ 2026-10-31  6:46 Maria Sheikh
  2026-10-31 13:32 ` Julia Lawall
  2026-11-20  7:21 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Maria Sheikh @ 2026-10-31  6:46 UTC (permalink / raw)
  To: outreachy, andy, gregkh, dri-devel, linux-fbdev, linux-staging,
	linux-kernel
  Cc: Maria Sheikh

Align the continuation line of the write_reg() call with the open
parenthesis to fix the checkpatch.pl check "Alignment should match open
parenthesis".

Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
---
 drivers/staging/fbtft/fb_tinylcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
index afa8f1c740c5..d58b1247262b 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0xE5, 0x00);
 	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
 	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
-		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
 	write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
 	write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
 	fsleep(250);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: fbtft: fb_tinylcd: align argument with open parenthesis
  2026-10-31  6:46 [PATCH] staging: fbtft: fb_tinylcd: align argument with open parenthesis Maria Sheikh
@ 2026-10-31 13:32 ` Julia Lawall
  2026-11-20  7:21 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2026-10-31 13:32 UTC (permalink / raw)
  To: Maria Sheikh
  Cc: outreachy, andy, gregkh, dri-devel, linux-fbdev, linux-staging,
	linux-kernel, Maria Sheikh



> On 31 Oct 2026, at 02:47, Maria Sheikh <mariasheikh812@gmail.com> wrote:
> 
> Align the continuation line of the write_reg() call with the open
> parenthesis to fix the checkpatch.pl check "Alignment should match open
> parenthesis".

I believe that this patch had already been proposed by another applicant and rejected. Please check the mailing list archives before sending a patch.

Julia

> 
> Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index afa8f1c740c5..d58b1247262b 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
>    write_reg(par, 0xE5, 0x00);
>    write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
>    write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> -               0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> +          0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
>    write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
>    write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
>    fsleep(250);
> --
> 2.53.0
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: fbtft: fb_tinylcd: align argument with open parenthesis
  2026-10-31  6:46 [PATCH] staging: fbtft: fb_tinylcd: align argument with open parenthesis Maria Sheikh
  2026-10-31 13:32 ` Julia Lawall
@ 2026-11-20  7:21 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-11-20  7:21 UTC (permalink / raw)
  To: Maria Sheikh
  Cc: outreachy, andy, dri-devel, linux-fbdev, linux-staging,
	linux-kernel

On Sat, Oct 31, 2026 at 11:46:59AM +0500, Maria Sheikh wrote:
> Align the continuation line of the write_reg() call with the open
> parenthesis to fix the checkpatch.pl check "Alignment should match open
> parenthesis".
> 
> Signed-off-by: Maria Sheikh <mariasheikh812@gmail.com>
> ---
>  drivers/staging/fbtft/fb_tinylcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index afa8f1c740c5..d58b1247262b 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, 0xE5, 0x00);
>  	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
>  	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> -		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> +		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);

No, the original code here is correct, right?

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20  7:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-31  6:46 [PATCH] staging: fbtft: fb_tinylcd: align argument with open parenthesis Maria Sheikh
2026-10-31 13:32 ` Julia Lawall
2026-11-20  7:21 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.