All of lore.kernel.org
 help / color / mirror / Atom feed
* CVE-2026-99765: scsi: target: Fix demo-mode dynamic ACL dev-entry UAF vs LUN teardown
@ 2026-11-20  5:52 Greg Kroah-Hartman
  0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2026-11-20  5:52 UTC (permalink / raw)
  To: linux-cve-announce; +Cc: Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@kernel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

scsi: target: Fix demo-mode dynamic ACL dev-entry UAF vs LUN teardown

A demo-mode (generate_node_acls=1) login that allocates a dynamic NodeACL
populates that ACL's per-LUN dev entries in core_tpg_add_node_to_devs()
*before* the ACL is linked onto tpg->acl_node_list by
target_add_node_acl():

	core_tpg_check_initiator_node_acl():
		...
		core_tpg_add_node_to_devs(acl, tpg, NULL); /* builds deves */
		target_add_node_acl(acl);                  /* only now listed */

The LUN teardown sweep, core_clear_lun_from_tpg(), enumerates only
tpg->acl_node_list, so a dev entry whose ACL is still in the window above
is invisible to the sweep and is never disabled.  It is left on the
se_lun->lun_deve_list after core_tpg_remove_lun() frees the se_lun; when
the same unpacked_lun is later re-added and the se_lun is reallocated at
the same address, the stale dev entry is rediscovered by
target_nacl_find_deve() and core_enable_device_list_for_node() corrupts
lun_deve_list:

  BUG: KASAN: slab-use-after-free ...
   core_enable_device_list_for_node+0x5ce/0x880
   core_tpg_add_node_to_devs+0x169/0x190
   core_dev_add_lun+0x146/0x190
   target_fabric_port_link+0xe9/0x1b0
   configfs_symlink+0x381/0xae0
   __x64_sys_symlink+0x55/0x80

The demo-mode login path that drives the ACL/dev-entry creation is
reachable by an unauthenticated initiator; the colliding LUN add/remove is
a local configfs operation.

Commit 49cb77e297dc ("target: Avoid mappedlun symlink creation during lun
shutdown") introduced se_lun->lun_shutdown and guarded the *explicit* ACL
MappedLUN path (target_fabric_mappedlun_link()), but the demo-mode
automatic path, core_tpg_add_node_to_devs() ->
core_enable_device_list_for_node(), was never given the equivalent guard,
and the publish-after-populate ordering in
core_tpg_check_initiator_node_acl() was left unchanged.

Fix it in three cooperating parts:

 1) Publish the dynamic NodeACL onto acl_node_list *before* creating its
    dev entries, so the teardown sweep can observe them.

 2) Refuse to attach a dev entry to an se_lun that is shutting down,
    checked under nacl->lun_entry_mutex -- the same lock the sweep takes --
    so once the sweep has passed an ACL any later enable for that LUN
    observes lun_shutdown and skips it.

 3) In core_enable_device_list_for_node(), insert the new dev entry onto
    lun->lun_deve_list while still holding nacl->lun_entry_mutex, in both
    the replace and the new-entry branch.  Previously the entry was added
    to nacl->lun_entry_hlist under the mutex but to lun->lun_deve_list only
    after dropping it; with the ACL now published early, the sweep could
    take the mutex in that gap, find the entry on the hlist,
    core_disable_device_list_for_node() it (list_del() on the not-yet-
    linked lun_link succeeds and the entry is freed), and then the enable
    would list_add_tail() the freed entry back onto lun_deve_list.  Linking
    both lists under the mutex makes enable and the sweep mutually
    exclusive, closing that window.

core_tpg_add_node_to_devs() already ignores the return value of
core_enable_device_list_for_node(), so a shutting-down LUN is simply
skipped.

The Linux kernel CVE team has assigned CVE-2026-99765 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 4.11 with commit 49cb77e297dc611a1b795cfeb79452b3002bd331 and fixed in 6.18.64 with commit c8b6eec86742f736a913aba7d7c1d0cedb1d7751
	Issue introduced in 4.11 with commit 49cb77e297dc611a1b795cfeb79452b3002bd331 and fixed in 7.3.5 with commit 78ad4413fab0cbd42c7280b5069ed2dd3f039162
	Issue introduced in 4.11 with commit 49cb77e297dc611a1b795cfeb79452b3002bd331 and fixed in 7.4-rc2 with commit 6a6e7d7230cd4e0a6c003bae5b85bf37a1e77b94
	Issue introduced in 3.10.108 with commit 003bea4a702279fc339a0d2f1262e907364a2c73
	Issue introduced in 3.18.64 with commit 8adc614240f1e2b793949d4efd9d344c970c116f
	Issue introduced in 4.1.47 with commit ca84f64e33058df99a8fa8ff88fc4c01b2fd8b17
	Issue introduced in 4.4.81 with commit 2bf7791c6a5ec21228383f5a1fb5c443c3336622
	Issue introduced in 4.9.24 with commit 92f8aa7bb825eafc3686cdda6dbbce44d8b35e75
	Issue introduced in 4.10.12 with commit 22113847cd117b26bd14316f735af79fc37cb6be

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2026-99765
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/target/target_core_device.c
	drivers/target/target_core_tpg.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/c8b6eec86742f736a913aba7d7c1d0cedb1d7751
	https://git.kernel.org/stable/c/78ad4413fab0cbd42c7280b5069ed2dd3f039162
	https://git.kernel.org/stable/c/6a6e7d7230cd4e0a6c003bae5b85bf37a1e77b94

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-20  6:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20  5:52 CVE-2026-99765: scsi: target: Fix demo-mode dynamic ACL dev-entry UAF vs LUN teardown Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.