All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v4 3/9] nvme-auth: switch to use 'struct key'
@ 2026-11-20 20:11 kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2026-11-20 20:11 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "same reports for this branch"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20261120-dhchap-keyring-v4-v4-3-5f8c7d9926ee@kernel.org>
References: <20261120-dhchap-keyring-v4-v4-3-5f8c7d9926ee@kernel.org>
TO: Hannes Reinecke <hare@kernel.org>
TO: Keith Busch <kbusch@kernel.org>
TO: Jens Axboe <axboe@kernel.dk>
TO: Christoph Hellwig <hch@lst.de>
TO: Sagi Grimberg <sagi@grimberg.me>
TO: Hannes Reinecke <hare@suse.de>
TO: Chaitanya Kulkarni <kch@nvidia.com>
CC: linux-nvme@lists.infradead.org
CC: linux-kernel@vger.kernel.org

Hi Hannes,

kernel test robot noticed the following build errors:

[auto build test ERROR on 68099cf27253a8c89d703a282d3d811446d9453b]

url:    https://github.com/intel-lab-lkp/linux/commits/Hannes-Reinecke/nvme-auth-modify-nvme_auth_transform_key-to-return-status/20261120-121400
base:   68099cf27253a8c89d703a282d3d811446d9453b
patch link:    https://lore.kernel.org/r/20261120-dhchap-keyring-v4-v4-3-5f8c7d9926ee%40kernel.org
patch subject: [PATCH v4 3/9] nvme-auth: switch to use 'struct key'
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: nios2-randconfig-1000-20261120 (https://download.01.org/0day-ci/archive/20261121/202611210433.kaUKHSYE-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261121/202611210433.kaUKHSYE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202611210433.kaUKHSYE-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/nvme/host/fabrics.c:15:
>> include/linux/nvme-keyring.h:54:1: error: expected identifier or '(' before '{' token
      54 | {
         | ^
>> include/linux/nvme-keyring.h:57:4: warning: no previous prototype for 'nvme_dhchap_psk_hash' [-Wmissing-prototypes]
      57 | u8 nvme_dhchap_psk_hash(struct key *key)
         |    ^~~~~~~~~~~~~~~~~~~~
>> include/linux/nvme-keyring.h:52:27: warning: 'nvme_dhchap_psk_lookup' declared 'static' but never defined [-Wunused-function]
      52 | static inline struct key *nvme_dhchap_psk_lookup(struct key *keyring,
         |                           ^~~~~~~~~~~~~~~~~~~~~~


vim +54 include/linux/nvme-keyring.h

50d8f97114b492 Hannes Reinecke 2026-11-20  26  
9d77eb52778499 Hannes Reinecke 2023-08-24  27  #else
62eb89323cb08f Hannes Reinecke 2025-02-24  28  static inline struct key *nvme_tls_psk_refresh(struct key *keyring,
62eb89323cb08f Hannes Reinecke 2025-02-24  29  		u8 *data, size_t data_len, const char *digest)
62eb89323cb08f Hannes Reinecke 2025-02-24  30  {
50d8f97114b492 Hannes Reinecke 2026-11-20  31  	return ERR_PTR(-EOPNOTSUPP);
62eb89323cb08f Hannes Reinecke 2025-02-24  32  }
501cc6f4aca8dc Hannes Reinecke 2023-08-24  33  static inline key_serial_t nvme_tls_psk_default(struct key *keyring,
501cc6f4aca8dc Hannes Reinecke 2023-08-24  34  		const char *hostnqn, const char *subnqn)
501cc6f4aca8dc Hannes Reinecke 2023-08-24  35  {
501cc6f4aca8dc Hannes Reinecke 2023-08-24  36  	return 0;
501cc6f4aca8dc Hannes Reinecke 2023-08-24  37  }
9d77eb52778499 Hannes Reinecke 2023-08-24  38  static inline key_serial_t nvme_keyring_id(void)
9d77eb52778499 Hannes Reinecke 2023-08-24  39  {
9d77eb52778499 Hannes Reinecke 2023-08-24  40  	return 0;
9d77eb52778499 Hannes Reinecke 2023-08-24  41  }
5bc46b49c828a6 Hannes Reinecke 2024-07-22  42  static inline struct key *nvme_tls_key_lookup(key_serial_t key_id)
5bc46b49c828a6 Hannes Reinecke 2024-07-22  43  {
50d8f97114b492 Hannes Reinecke 2026-11-20  44  	return ERR_PTR(-EOPNOTSUPP);
50d8f97114b492 Hannes Reinecke 2026-11-20  45  }
50d8f97114b492 Hannes Reinecke 2026-11-20  46  static inline struct key *nvme_dhchap_psk_refresh(struct key *keyring,
50d8f97114b492 Hannes Reinecke 2026-11-20  47  		const char *hostnqn, const char *subnqn,
50d8f97114b492 Hannes Reinecke 2026-11-20  48  		u8 *data, size_t data_len)
50d8f97114b492 Hannes Reinecke 2026-11-20  49  {
50d8f97114b492 Hannes Reinecke 2026-11-20  50  	return ERR_PTR(-EOPNOTSUPP);
50d8f97114b492 Hannes Reinecke 2026-11-20  51  }
50d8f97114b492 Hannes Reinecke 2026-11-20 @52  static inline struct key *nvme_dhchap_psk_lookup(struct key *keyring,
50d8f97114b492 Hannes Reinecke 2026-11-20  53  		const char *hostnqn, const char *subnqn, u8 hmac);
50d8f97114b492 Hannes Reinecke 2026-11-20 @54  {
50d8f97114b492 Hannes Reinecke 2026-11-20  55  	return ERR_PTR(-EOPNOTSUPP);
50d8f97114b492 Hannes Reinecke 2026-11-20  56  }
50d8f97114b492 Hannes Reinecke 2026-11-20 @57  u8 nvme_dhchap_psk_hash(struct key *key)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v4 0/9] nvme-auth: switch to use the kernel keyring
@ 2026-11-20 11:13 Hannes Reinecke
  2026-11-20 11:14 ` [PATCH v4 3/9] nvme-auth: switch to use 'struct key' Hannes Reinecke
  0 siblings, 1 reply; 6+ messages in thread
From: Hannes Reinecke @ 2026-11-20 11:13 UTC (permalink / raw)
  To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
	Hannes Reinecke, Chaitanya Kulkarni
  Cc: linux-nvme, linux-kernel, Hannes Reinecke

Hey all,

the current NVMe authentication code is using a hand-crafted key
structure; idea was to have the initial implementation with a minimal
set of dependencies.
(And me not having a good grasp on how to use the kernel keyring :-)
That had the drawback that keys always had to be specified on the
nvme-cli commandline, which is far from ideal from a security standpoint.

So this patchset switches the authentication code over to use the
kernel keyring. User-facing interface (namely argument to 'nvme
connect') remain the same, but the key data is converted into keys
which are stored as a new key type 'dhchap' with a random UUID as
description in the kernel keyring.

With this I have updated the dhchap arguments to 'nvme connect' and
the configfs interface to either be the keydata (ie the original
interface) _or_ a key description referring to a pre-populated dhchap
key in the kernel keyring. This allows for easier provisioning of keys
and avoids the security risk from having to specify the key data on
the kernel commandline.

The entire patchset can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/hare/nvme.git
branch dhchap-keyring.v4

As usual, comments and reviews are welcome.

Changes to v3:
- Update to 7.4
- Add patch to set keyring for nvmet

Changes to v2:
- Update to v7.1
- Include reviews fromn Sagi
- Clarify decoded PSK length
- Add more function descriptions

Changes to the original submission:
- Dropped patches merged with upstream
- Modified the interface to refer to keys via the description
  and not the serial number

Signed-off-by: Hannes Reinecke <hare@kernel.org>
---
Hannes Reinecke (9):
      nvme-auth: modify nvme_auth_transform_key() to return status
      nvme-keyring: add 'dhchap' key type
      nvme-auth: switch to use 'struct key'
      nvme: parse dhchap keys during option parsing
      nvmet-auth: parse dhchap key from configfs attribute
      nvme: allow to pass in key description as dhchap secret
      nvme-auth: wait for authentication to finish when changing keys
      nvme-fabrics: allow to pass in keyring by name
      nvmet: add configfs attribute 'dhchap_keyring'

 drivers/nvme/common/Kconfig    |   1 +
 drivers/nvme/common/auth.c     | 213 ++++++++++++----------------
 drivers/nvme/common/keyring.c  | 314 +++++++++++++++++++++++++++++++++++++++++
 drivers/nvme/host/Kconfig      |   1 -
 drivers/nvme/host/auth.c       | 171 +++++++++++++++-------
 drivers/nvme/host/fabrics.c    | 121 +++++++++++-----
 drivers/nvme/host/fabrics.h    |  12 +-
 drivers/nvme/host/nvme.h       |   6 +-
 drivers/nvme/host/sysfs.c      | 212 +++++++++++++++++++++-------
 drivers/nvme/target/Kconfig    |   1 -
 drivers/nvme/target/auth.c     | 229 +++++++++++++++++++-----------
 drivers/nvme/target/configfs.c | 144 ++++++++++++++++---
 drivers/nvme/target/nvmet.h    |  16 +--
 include/linux/nvme-auth.h      |  11 +-
 include/linux/nvme-keyring.h   |  26 +++-
 15 files changed, 1092 insertions(+), 386 deletions(-)
---
base-commit: 68099cf27253a8c89d703a282d3d811446d9453b
change-id: 20261120-dhchap-keyring-v4-09f0bac1d8c5

Best regards,
-- 
Hannes Reinecke <hare@kernel.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-20 20:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 20:11 [PATCH v4 3/9] nvme-auth: switch to use 'struct key' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2026-11-20 11:13 [PATCH v4 0/9] nvme-auth: switch to use the kernel keyring Hannes Reinecke
2026-11-20 11:14 ` [PATCH v4 3/9] nvme-auth: switch to use 'struct key' Hannes Reinecke
2026-11-20 11:31   ` sashiko-bot
2026-11-20 13:08     ` Hannes Reinecke
2026-11-20 19:24   ` kernel test robot
2026-11-20 19:37   ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.