All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] recipeutils: fix NameError for recipes with unreliable upstream checks
@ 2026-11-21  5:38 Prasanth R
  2026-11-21  5:38 ` [PATCH 2/3] resulttool: fix NameError in filter_resultsdata() Prasanth R
  2026-11-21  5:38 ` [PATCH 3/3] oeqa/qemutinyrunner: fix NameError when RUNQEMU_TMPFS_DIR is set Prasanth R
  0 siblings, 2 replies; 3+ messages in thread
From: Prasanth R @ 2026-11-21  5:38 UTC (permalink / raw)
  To: openembedded-core; +Cc: Prasanth R

Since b1d01911fa ("lib/oe/reciputils.py: parallelize upstream version
checks") pn is no longer set in get_recipe_upgrade_status(), so a recipe
with UPSTREAM_CHECK_UNRELIABLE = "1" makes devtool check-upgrade-status
fail with:

  NameError: name 'pn' is not defined

Take the name from the recipe data instead.

AI-Generated: Uses Claude
Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp>
---
 meta/lib/oe/recipeutils.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/recipeutils.py b/meta/lib/oe/recipeutils.py
index 522537e0d9..9b3a2d0638 100644
--- a/meta/lib/oe/recipeutils.py
+++ b/meta/lib/oe/recipeutils.py
@@ -1186,7 +1186,7 @@ def get_recipe_upgrade_status(recipes=None, stable_upgrade=False):
 
             unreliable = data.getVar('UPSTREAM_CHECK_UNRELIABLE')
             if unreliable == "1":
-                bb.note(" Skip package %s as upstream check unreliable" % pn)
+                bb.note(" Skip package %s as upstream check unreliable" % data.getVar('PN'))
                 continue
 
             data_copy = bb.data.init()
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/3] resulttool: fix NameError in filter_resultsdata()
  2026-11-21  5:38 [PATCH 1/3] recipeutils: fix NameError for recipes with unreliable upstream checks Prasanth R
@ 2026-11-21  5:38 ` Prasanth R
  2026-11-21  5:38 ` [PATCH 3/3] oeqa/qemutinyrunner: fix NameError when RUNQEMU_TMPFS_DIR is set Prasanth R
  1 sibling, 0 replies; 3+ messages in thread
From: Prasanth R @ 2026-11-21  5:38 UTC (permalink / raw)
  To: openembedded-core; +Cc: Prasanth R

filter_resultsdata() takes resultid but compares against resultsid, so
resulttool regression with --base-result-id or --target-result-id fails
with:

  NameError: name 'resultsid' is not defined

Use the parameter name.

AI-Generated: Uses Claude
Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp>
---
 scripts/lib/resulttool/resultutils.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/resulttool/resultutils.py b/scripts/lib/resulttool/resultutils.py
index 53980f8007..13321a75f0 100644
--- a/scripts/lib/resulttool/resultutils.py
+++ b/scripts/lib/resulttool/resultutils.py
@@ -119,7 +119,7 @@ def filter_resultsdata(results, resultid):
     newresults = {}
     for r in results:
         for i in results[r]:
-            if i == resultsid:
+            if i == resultid:
                  newresults[r] = {}
                  newresults[r][i] = results[r][i]
     return newresults
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 3/3] oeqa/qemutinyrunner: fix NameError when RUNQEMU_TMPFS_DIR is set
  2026-11-21  5:38 [PATCH 1/3] recipeutils: fix NameError for recipes with unreliable upstream checks Prasanth R
  2026-11-21  5:38 ` [PATCH 2/3] resulttool: fix NameError in filter_resultsdata() Prasanth R
@ 2026-11-21  5:38 ` Prasanth R
  1 sibling, 0 replies; 3+ messages in thread
From: Prasanth R @ 2026-11-21  5:38 UTC (permalink / raw)
  To: openembedded-core; +Cc: Prasanth R

QemuTinyRunner.start() sets RUNQEMU_TMPFS_DIR in env, which only exists
in QemuRunner.start(). With RUNQEMU_TMPFS_DIR set, testimage on
poky-tiny fails with:

  NameError: name 'env' is not defined

Use os.environ, like the other variables set in this function.

AI-Generated: Uses Claude
Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp>
---
 meta/lib/oeqa/utils/qemutinyrunner.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/utils/qemutinyrunner.py b/meta/lib/oeqa/utils/qemutinyrunner.py
index 0510977e9d..917bafdeaf 100644
--- a/meta/lib/oeqa/utils/qemutinyrunner.py
+++ b/meta/lib/oeqa/utils/qemutinyrunner.py
@@ -86,7 +86,7 @@ class QemuTinyRunner(QemuRunner):
         else:
             os.environ["DEPLOY_DIR_IMAGE"] = self.deploy_dir_image
         if self.tmpfsdir:
-            env["RUNQEMU_TMPFS_DIR"] = self.tmpfsdir
+            os.environ["RUNQEMU_TMPFS_DIR"] = self.tmpfsdir
 
 
         # Set this flag so that Qemu doesn't do any grabs as SDL grabs interact
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-21  5:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21  5:38 [PATCH 1/3] recipeutils: fix NameError for recipes with unreliable upstream checks Prasanth R
2026-11-21  5:38 ` [PATCH 2/3] resulttool: fix NameError in filter_resultsdata() Prasanth R
2026-11-21  5:38 ` [PATCH 3/3] oeqa/qemutinyrunner: fix NameError when RUNQEMU_TMPFS_DIR is set Prasanth R

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.