All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t 0/3] gputop: Support accel devices
@ 2026-11-21  9:41 Gyeyoung Baek
  2026-11-21  9:41 ` [PATCH i-g-t 1/3] lib/igt_drm_clients: Track clients by dev_t instead of DRM minor Gyeyoung Baek
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Gyeyoung Baek @ 2026-11-21  9:41 UTC (permalink / raw)
  To: igt-dev; +Cc: Kamil Konieczny, Tvrtko Ursulin

Make gputop show the clients of accel devices (/dev/accel/*) too.

Accel drivers print the same drm-usage-stats fdinfo as DRM drivers
through drm_show_fdinfo() in the DRM core, but igt_drm_clients only
scans DRM nodes (major 226), so they never show up in gputop.

- Patch 1 extends the client identifier from the minor to dev_t (no
  functional change).
- Patch 2 also scans accel nodes (major 261).
- Patch 3 shows the device node and driver name in the client header
  instead of "DRM minor N".

Tested on RK3588 (Rock 5B+) with panthor (GPU) and rocket (NPU) running
at the same time, on drm-misc-next plus the rocket fdinfo series [1]
(bars trimmed):

  renderD128 (panthor)
  PID      MEM      RSS  panthor  NAME
  727       9M       9M   100.0%  gpuload
  accel0 (rocket)
  PID      MEM      RSS      npu  NAME
  724      23M       0B    14.7%  benchmark_model

Not tested on Intel hardware (patch 1, Intel frequency sysfs path:
/sys/class/drm/cardN -> /sys/dev/char/<major>:<minor>).

[1] https://lore.kernel.org/all/20261120141225.789350-1-sidong.yang@furiosa.ai/

Gyeyoung Baek (3):
  lib/igt_drm_clients: Track clients by dev_t instead of DRM minor
  lib/igt_drm_clients: Also scan accel device nodes
  tools/gputop: Show device node and driver name in client header

 lib/igt_drm_clients.c |  41 ++++++++++-------
 lib/igt_drm_clients.h |   4 +-
 tools/gputop.c        | 102 +++++++++++++++++++++++++-----------------
 3 files changed, 88 insertions(+), 59 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH i-g-t 1/3] lib/igt_drm_clients: Track clients by dev_t instead of DRM minor
  2026-11-21  9:41 [PATCH i-g-t 0/3] gputop: Support accel devices Gyeyoung Baek
@ 2026-11-21  9:41 ` Gyeyoung Baek
  2026-11-21  9:41 ` [PATCH i-g-t 2/3] lib/igt_drm_clients: Also scan accel device nodes Gyeyoung Baek
  2026-11-21  9:41 ` [PATCH i-g-t 3/3] tools/gputop: Show device node and driver name in client header Gyeyoung Baek
  2 siblings, 0 replies; 4+ messages in thread
From: Gyeyoung Baek @ 2026-11-21  9:41 UTC (permalink / raw)
  To: igt-dev; +Cc: Kamil Konieczny, Tvrtko Ursulin

So far only DRM nodes (major 226) have been scanned, so the minor alone
was enough to identify a client. Adding accel nodes (major 261) would
make minors collide, so extend the identifier from the minor to the
full dev_t.

gputop's get_sysfs_drm_path() guessed between card and renderD from the
minor range to build sysfs paths. With the dev_t, the node can be found
directly through /sys/dev/char/<major>:<minor>, so remove it.

No functional change: only DRM nodes are scanned and the header still
shows the minor.

Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
---
 lib/igt_drm_clients.c | 25 ++++++++-------
 lib/igt_drm_clients.h |  3 +-
 tools/gputop.c        | 75 ++++++++++++++++++++-----------------------
 3 files changed, 49 insertions(+), 54 deletions(-)

diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c
index 858cd3645..0b515c5aa 100644
--- a/lib/igt_drm_clients.c
+++ b/lib/igt_drm_clients.c
@@ -47,7 +47,7 @@ struct igt_drm_clients *igt_drm_clients_init(void *private_data)
 static struct igt_drm_client *
 igt_drm_clients_find(struct igt_drm_clients *clients,
 		     enum igt_drm_client_status status,
-		     unsigned int drm_minor, unsigned long id)
+		     dev_t rdev, unsigned long id)
 {
 	unsigned int start, num;
 	struct igt_drm_client *c;
@@ -60,7 +60,7 @@ igt_drm_clients_find(struct igt_drm_clients *clients,
 			continue;
 
 		if (status == IGT_DRM_CLIENT_FREE ||
-		    (drm_minor == c->drm_minor && c->id == id))
+		    (rdev == c->rdev && c->id == id))
 			return c;
 	}
 
@@ -160,13 +160,13 @@ igt_drm_client_update(struct igt_drm_client *c, unsigned int pid, char *name,
 static void
 igt_drm_client_add(struct igt_drm_clients *clients,
 		   const struct drm_client_fdinfo *info,
-		   unsigned int pid, char *name, unsigned int drm_minor)
+		   unsigned int pid, char *name, dev_t rdev)
 {
 	struct igt_drm_client *c;
 	unsigned int i;
 
 	assert(!igt_drm_clients_find(clients, IGT_DRM_CLIENT_ALIVE,
-				     drm_minor, info->id));
+				     rdev, info->id));
 
 	c = igt_drm_clients_find(clients, IGT_DRM_CLIENT_FREE, 0, 0);
 	if (!c) {
@@ -187,7 +187,7 @@ igt_drm_client_add(struct igt_drm_clients *clients,
 	}
 
 	c->id = info->id;
-	c->drm_minor = drm_minor;
+	c->rdev = rdev;
 	c->clients = clients;
 
 	/* Engines */
@@ -422,7 +422,7 @@ static void get_task_data(int pid_dir, unsigned int *pid, char *task, size_t tas
 }
 
 
-static bool is_drm_fd(int fd_dir, const char *name, unsigned int *minor)
+static bool is_drm_fd(int fd_dir, const char *name, dev_t *rdev)
 {
 	struct stat stat;
 	int ret;
@@ -432,7 +432,7 @@ static bool is_drm_fd(int fd_dir, const char *name, unsigned int *minor)
 	if (ret == 0 &&
 	    (stat.st_mode & S_IFMT) == S_IFCHR &&
 	    major(stat.st_rdev) == 226) {
-		*minor = minor(stat.st_rdev);
+		*rdev = stat.st_rdev;
 		return true;
 	}
 
@@ -515,7 +515,8 @@ igt_drm_clients_scan(struct igt_drm_clients *clients,
 		return clients;
 
 	while ((proc_dent = readdir(proc_dir)) != NULL) {
-		unsigned int client_pid = 0, minor = 0;
+		unsigned int client_pid = 0;
+		dev_t rdev = 0;
 		int pid_dir = -1, fd_dir = -1;
 		struct dirent *fdinfo_dent;
 		char client_name[64] = { };
@@ -547,7 +548,7 @@ igt_drm_clients_scan(struct igt_drm_clients *clients,
 			if (!isdigit(fdinfo_dent->d_name[0]))
 				continue;
 
-			if (!is_drm_fd(fd_dir, fdinfo_dent->d_name, &minor))
+			if (!is_drm_fd(fd_dir, fdinfo_dent->d_name, &rdev))
 				continue;
 
 			if (!__igt_parse_drm_fdinfo(dirfd(fdinfo_dir),
@@ -560,7 +561,7 @@ igt_drm_clients_scan(struct igt_drm_clients *clients,
 				continue;
 
 			if (igt_drm_clients_find(clients, IGT_DRM_CLIENT_ALIVE,
-						 minor, info.id))
+						 rdev, info.id))
 				continue; /* Skip duplicate fds. */
 
 			if (!client_pid) {
@@ -570,10 +571,10 @@ igt_drm_clients_scan(struct igt_drm_clients *clients,
 			}
 
 			c = igt_drm_clients_find(clients, IGT_DRM_CLIENT_PROBE,
-						 minor, info.id);
+						 rdev, info.id);
 			if (!c)
 				igt_drm_client_add(clients, &info, client_pid,
-						   client_name, minor);
+						   client_name, rdev);
 			else
 				igt_drm_client_update(c, client_pid,
 						      client_name, &info);
diff --git a/lib/igt_drm_clients.h b/lib/igt_drm_clients.h
index 946d709de..288f58b89 100644
--- a/lib/igt_drm_clients.h
+++ b/lib/igt_drm_clients.h
@@ -7,6 +7,7 @@
 #define IGT_DRM_CLIENTS_H
 
 #include <stdint.h>
+#include <sys/types.h>
 
 #include "lib/igt_drm_fdinfo.h"
 
@@ -63,7 +64,7 @@ struct igt_drm_client {
 	struct igt_drm_client_regions *regions; /* Memory regions present in this client, to map with memory usage. */
 	struct igt_drm_client_engines *engines; /* Engines used by this client, to map with busynees data. */
 	unsigned long id; /* DRM client id from fdinfo. */
-	unsigned int drm_minor; /* DRM minor of this client. */
+	dev_t rdev; /* Device number of the DRM node this client fd refers to. */
 	unsigned int pid; /* PID which has this DRM fd open. */
 	char pid_str[10]; /* Cached PID representation. */
 	char name[24]; /* Process name of the owning PID. */
diff --git a/tools/gputop.c b/tools/gputop.c
index 0ed5af456..e89a1e53e 100644
--- a/tools/gputop.c
+++ b/tools/gputop.c
@@ -83,14 +83,8 @@ static void print_percentage_bar(double percent, int max_len)
 	putchar('|');
 }
 
-/* Get the correct sysfs prefix based on DRM minor number */
-static const char *get_sysfs_drm_path(unsigned int drm_minor)
-{
-	return drm_minor >= 128 ? "/sys/class/drm/renderD" : "/sys/class/drm/card";
-}
-
 /* Detect if driver is bound to the device */
-static bool is_bound(unsigned int drm_minor, const char *driver_name)
+static bool is_bound(dev_t rdev, const char *driver_name)
 {
 	char path[256];
 	char link[256];
@@ -98,8 +92,8 @@ static bool is_bound(unsigned int drm_minor, const char *driver_name)
 	ssize_t len;
 
 	/* Read the driver symlink */
-	snprintf(path, sizeof(path), "%s%u/device/driver",
-		 get_sysfs_drm_path(drm_minor), drm_minor);
+	snprintf(path, sizeof(path), "/sys/dev/char/%u:%u/device/driver",
+		 major(rdev), minor(rdev));
 	len = readlink(path, link, sizeof(link) - 1);
 	if (len == -1)
 		return false;
@@ -117,24 +111,24 @@ static bool is_bound(unsigned int drm_minor, const char *driver_name)
 }
 
 /* Detect if this is an Intel device (i915 or Xe) */
-static bool is_intel_device(unsigned int drm_minor)
+static bool is_intel_device(dev_t rdev)
 {
-	return is_bound(drm_minor, "i915") || is_bound(drm_minor, "xe");
+	return is_bound(rdev, "i915") || is_bound(rdev, "xe");
 }
 
 /* Detect Intel driver variant */
-static enum intel_driver_type detect_intel_driver(unsigned int drm_minor)
+static enum intel_driver_type detect_intel_driver(dev_t rdev)
 {
-	if (is_bound(drm_minor, "xe"))
+	if (is_bound(rdev, "xe"))
 		return INTEL_DRIVER_XE;
-	else if (is_bound(drm_minor, "i915"))
+	else if (is_bound(rdev, "i915"))
 		return INTEL_DRIVER_I915;
 
 	return INTEL_DRIVER_UNKNOWN;
 }
 
 /* Count the number of GTs by checking which gt* directories exist */
-static int get_num_gts(unsigned int drm_minor, enum intel_driver_type driver_type)
+static int get_num_gts(dev_t rdev, enum intel_driver_type driver_type)
 {
 	char path[256];
 	struct stat st;
@@ -144,11 +138,11 @@ static int get_num_gts(unsigned int drm_minor, enum intel_driver_type driver_typ
 	for (int i = 0; i < 8; i++) {
 		if (driver_type == INTEL_DRIVER_XE)
 			/* For Xe, all GTs are under tile0 */
-			snprintf(path, sizeof(path), "%s%u/device/tile0/gt%d",
-				 get_sysfs_drm_path(drm_minor), drm_minor, i);
+			snprintf(path, sizeof(path), "/sys/dev/char/%u:%u/device/tile0/gt%d",
+				 major(rdev), minor(rdev), i);
 		else /* i915 */
-			snprintf(path, sizeof(path), "%s%u/gt/gt%d",
-				 get_sysfs_drm_path(drm_minor), drm_minor, i);
+			snprintf(path, sizeof(path), "/sys/dev/char/%u:%u/gt/gt%d",
+				 major(rdev), minor(rdev), i);
 
 		if (stat(path, &st) == 0 && S_ISDIR(st.st_mode))
 			gt_count++;
@@ -179,7 +173,7 @@ static bool read_freq_value(const char *path, unsigned int *freq)
 }
 
 /* Intel-specific frequency reading for i915/Xe drivers */
-static char *get_intel_frequencies(unsigned int drm_minor)
+static char *get_intel_frequencies(dev_t rdev)
 {
 	char freq_str[512] = "";
 	char gt_info[64];
@@ -189,12 +183,12 @@ static char *get_intel_frequencies(unsigned int drm_minor)
 	bool first = true;
 
 	/* Detect Intel driver variant */
-	driver_type = detect_intel_driver(drm_minor);
+	driver_type = detect_intel_driver(rdev);
 	if (driver_type == INTEL_DRIVER_UNKNOWN)
 		return NULL;
 
 	/* Get GT count from sysfs */
-	num_gts = get_num_gts(drm_minor, driver_type);
+	num_gts = get_num_gts(rdev, driver_type);
 	if (num_gts == 0)
 		return NULL;
 
@@ -207,24 +201,24 @@ static char *get_intel_frequencies(unsigned int drm_minor)
 		/* Read requested frequency */
 		if (driver_type == INTEL_DRIVER_XE)
 			snprintf(freq_path, sizeof(freq_path),
-				 "%s%u/device/tile0/gt%d/freq0/cur_freq",
-				 get_sysfs_drm_path(drm_minor), drm_minor, gt);
+				 "/sys/dev/char/%u:%u/device/tile0/gt%d/freq0/cur_freq",
+				 major(rdev), minor(rdev), gt);
 		else /* i915 */
 			snprintf(freq_path, sizeof(freq_path),
-				 "%s%u/gt/gt%d/rps_cur_freq_mhz",
-				 get_sysfs_drm_path(drm_minor), drm_minor, gt);
+				 "/sys/dev/char/%u:%u/gt/gt%d/rps_cur_freq_mhz",
+				 major(rdev), minor(rdev), gt);
 
 		has_cur = read_freq_value(freq_path, &cur_freq);
 
 		/* Read actual frequency */
 		if (driver_type == INTEL_DRIVER_XE)
 			snprintf(freq_path, sizeof(freq_path),
-				 "%s%u/device/tile0/gt%d/freq0/act_freq",
-				 get_sysfs_drm_path(drm_minor), drm_minor, gt);
+				 "/sys/dev/char/%u:%u/device/tile0/gt%d/freq0/act_freq",
+				 major(rdev), minor(rdev), gt);
 		else /* i915 */
 			snprintf(freq_path, sizeof(freq_path),
-				 "%s%u/gt/gt%d/rps_act_freq_mhz",
-				 get_sysfs_drm_path(drm_minor), drm_minor, gt);
+				 "/sys/dev/char/%u:%u/gt/gt%d/rps_act_freq_mhz",
+				 major(rdev), minor(rdev), gt);
 
 		has_act = read_freq_value(freq_path, &act_freq);
 
@@ -249,11 +243,11 @@ static char *get_intel_frequencies(unsigned int drm_minor)
 }
 
 /* Generic wrapper for frequency reading - dispatches to vendor-specific implementations */
-static char *get_frequencies(unsigned int drm_minor)
+static char *get_frequencies(dev_t rdev)
 {
 	/* Check for Intel devices (i915/Xe) */
-	if (is_intel_device(drm_minor))
-		return get_intel_frequencies(drm_minor);
+	if (is_intel_device(rdev))
+		return get_intel_frequencies(rdev);
 
 	return NULL;
 }
@@ -271,13 +265,14 @@ print_client_header(struct igt_drm_client *c, int lines, int con_w, int con_h,
 	printf(ANSI_HEADER);
 
 	/* Get frequency information */
-	freq_info = get_frequencies(c->drm_minor);
+	freq_info = get_frequencies(c->rdev);
 
 	if (freq_info) {
-		ret = printf("DRM minor %u   Frequency(MHz) %s", c->drm_minor, freq_info);
+		ret = printf("DRM minor %u   Frequency(MHz) %s",
+			     minor(c->rdev), freq_info);
 		free(freq_info);
 	} else {
-		ret = printf("DRM minor %u", c->drm_minor);
+		ret = printf("DRM minor %u", minor(c->rdev));
 	}
 
 	n_spaces(con_w - ret);
@@ -346,7 +341,7 @@ engines_identical(const struct igt_drm_client *c,
 static bool
 newheader(const struct igt_drm_client *c, const struct igt_drm_client *pc)
 {
-	return !pc || c->drm_minor != pc->drm_minor ||
+	return !pc || c->rdev != pc->rdev ||
 	       /*
 		* Below is a a hack for drivers like amdgpu which omit listing
 		* unused engines. Simply treat them as separate minors which
@@ -479,11 +474,9 @@ static int client_cmp(const void *_a, const void *_b, void *unused)
 	long val_a, val_b;
 
 	/* DRM cards into consecutive buckets first. */
-	val_a = a->drm_minor;
-	val_b = b->drm_minor;
-	if (val_a > val_b)
+	if (a->rdev > b->rdev)
 		return 1;
-	else if (val_b > val_a)
+	else if (b->rdev > a->rdev)
 		return -1;
 
 	/*
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH i-g-t 2/3] lib/igt_drm_clients: Also scan accel device nodes
  2026-11-21  9:41 [PATCH i-g-t 0/3] gputop: Support accel devices Gyeyoung Baek
  2026-11-21  9:41 ` [PATCH i-g-t 1/3] lib/igt_drm_clients: Track clients by dev_t instead of DRM minor Gyeyoung Baek
@ 2026-11-21  9:41 ` Gyeyoung Baek
  2026-11-21  9:41 ` [PATCH i-g-t 3/3] tools/gputop: Show device node and driver name in client header Gyeyoung Baek
  2 siblings, 0 replies; 4+ messages in thread
From: Gyeyoung Baek @ 2026-11-21  9:41 UTC (permalink / raw)
  To: igt-dev; +Cc: Kamil Konieczny, Tvrtko Ursulin

Scan accel nodes (major 261) for clients in addition to DRM nodes
(major 226).

Accel drivers print the same drm-usage-stats fdinfo through
drm_show_fdinfo() in the DRM core, so the existing fdinfo parsing works
as is.

Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
---
 lib/igt_drm_clients.c | 15 ++++++++++-----
 lib/igt_drm_clients.h |  2 +-
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c
index 0b515c5aa..4ab49a6b5 100644
--- a/lib/igt_drm_clients.c
+++ b/lib/igt_drm_clients.c
@@ -428,15 +428,20 @@ static bool is_drm_fd(int fd_dir, const char *name, dev_t *rdev)
 	int ret;
 
 	ret = fstatat(fd_dir, name, &stat, 0);
+	if (ret)
+		return false;
 
-	if (ret == 0 &&
-	    (stat.st_mode & S_IFMT) == S_IFCHR &&
-	    major(stat.st_rdev) == 226) {
+	if ((stat.st_mode & S_IFMT) != S_IFCHR)
+		return false;
+
+	switch (major(stat.st_rdev)) {
+	case 226: /* DRM */
+	case 261: /* accel */
 		*rdev = stat.st_rdev;
 		return true;
+	default:
+		return false;
 	}
-
-	return false;
 }
 
 static void clients_update_max_lengths(struct igt_drm_clients *clients)
diff --git a/lib/igt_drm_clients.h b/lib/igt_drm_clients.h
index 288f58b89..f2a7bab97 100644
--- a/lib/igt_drm_clients.h
+++ b/lib/igt_drm_clients.h
@@ -64,7 +64,7 @@ struct igt_drm_client {
 	struct igt_drm_client_regions *regions; /* Memory regions present in this client, to map with memory usage. */
 	struct igt_drm_client_engines *engines; /* Engines used by this client, to map with busynees data. */
 	unsigned long id; /* DRM client id from fdinfo. */
-	dev_t rdev; /* Device number of the DRM node this client fd refers to. */
+	dev_t rdev; /* Device number of the DRM or accel node this client fd refers to. */
 	unsigned int pid; /* PID which has this DRM fd open. */
 	char pid_str[10]; /* Cached PID representation. */
 	char name[24]; /* Process name of the owning PID. */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH i-g-t 3/3] tools/gputop: Show device node and driver name in client header
  2026-11-21  9:41 [PATCH i-g-t 0/3] gputop: Support accel devices Gyeyoung Baek
  2026-11-21  9:41 ` [PATCH i-g-t 1/3] lib/igt_drm_clients: Track clients by dev_t instead of DRM minor Gyeyoung Baek
  2026-11-21  9:41 ` [PATCH i-g-t 2/3] lib/igt_drm_clients: Also scan accel device nodes Gyeyoung Baek
@ 2026-11-21  9:41 ` Gyeyoung Baek
  2 siblings, 0 replies; 4+ messages in thread
From: Gyeyoung Baek @ 2026-11-21  9:41 UTC (permalink / raw)
  To: igt-dev; +Cc: Kamil Konieczny, Tvrtko Ursulin

Show the device node name and the driver name in the client header
instead of "DRM minor N".

Before:
  DRM minor 128
  DRM minor 0

After:
  renderD128 (panthor)
  accel0 (rocket)

The minor alone does not tell which device or driver the clients belong
to, and since accel nodes share minor numbers with DRM nodes,
"DRM minor 0" cannot even tell card0 from accel0.

Take the node name from sysfs and the driver name from the drm-driver
fdinfo key.

Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
---
 lib/igt_drm_clients.c |  1 +
 lib/igt_drm_clients.h |  1 +
 tools/gputop.c        | 33 ++++++++++++++++++++++++++++++---
 3 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c
index 4ab49a6b5..94e27f84b 100644
--- a/lib/igt_drm_clients.c
+++ b/lib/igt_drm_clients.c
@@ -188,6 +188,7 @@ igt_drm_client_add(struct igt_drm_clients *clients,
 
 	c->id = info->id;
 	c->rdev = rdev;
+	snprintf(c->driver, sizeof(c->driver), "%s", info->driver);
 	c->clients = clients;
 
 	/* Engines */
diff --git a/lib/igt_drm_clients.h b/lib/igt_drm_clients.h
index f2a7bab97..54bd12147 100644
--- a/lib/igt_drm_clients.h
+++ b/lib/igt_drm_clients.h
@@ -65,6 +65,7 @@ struct igt_drm_client {
 	struct igt_drm_client_engines *engines; /* Engines used by this client, to map with busynees data. */
 	unsigned long id; /* DRM client id from fdinfo. */
 	dev_t rdev; /* Device number of the DRM or accel node this client fd refers to. */
+	char driver[128]; /* DRM driver name from fdinfo. */
 	unsigned int pid; /* PID which has this DRM fd open. */
 	char pid_str[10]; /* Cached PID representation. */
 	char name[24]; /* Process name of the owning PID. */
diff --git a/tools/gputop.c b/tools/gputop.c
index e89a1e53e..fb1ee0fcf 100644
--- a/tools/gputop.c
+++ b/tools/gputop.c
@@ -252,27 +252,54 @@ static char *get_frequencies(dev_t rdev)
 	return NULL;
 }
 
+/*
+ * Get the device node name (e.g. card0, renderD128) from sysfs, falling back
+ * to the major:minor numbers.
+ */
+static void get_node_name(dev_t rdev, char *buf, size_t size)
+{
+	char path[64];
+	char link[256];
+	const char *name;
+	ssize_t len;
+
+	snprintf(path, sizeof(path), "/sys/dev/char/%u:%u",
+		 major(rdev), minor(rdev));
+	len = readlink(path, link, sizeof(link) - 1);
+	if (len == -1) {
+		snprintf(buf, size, "%u:%u", major(rdev), minor(rdev));
+		return;
+	}
+	link[len] = '\0';
+
+	name = strrchr(link, '/');
+	snprintf(buf, size, "%s", name ? name + 1 : link);
+}
+
 static int
 print_client_header(struct igt_drm_client *c, int lines, int con_w, int con_h,
 		    int *engine_w)
 {
 	int ret, len;
 	char *freq_info = NULL;
+	char node[256];
 
 	if (lines++ >= con_h)
 		return lines;
 
+	get_node_name(c->rdev, node, sizeof(node));
+
 	printf(ANSI_HEADER);
 
 	/* Get frequency information */
 	freq_info = get_frequencies(c->rdev);
 
 	if (freq_info) {
-		ret = printf("DRM minor %u   Frequency(MHz) %s",
-			     minor(c->rdev), freq_info);
+		ret = printf("%s (%s)   Frequency(MHz) %s",
+			     node, c->driver, freq_info);
 		free(freq_info);
 	} else {
-		ret = printf("DRM minor %u", minor(c->rdev));
+		ret = printf("%s (%s)", node, c->driver);
 	}
 
 	n_spaces(con_w - ret);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-21  9:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21  9:41 [PATCH i-g-t 0/3] gputop: Support accel devices Gyeyoung Baek
2026-11-21  9:41 ` [PATCH i-g-t 1/3] lib/igt_drm_clients: Track clients by dev_t instead of DRM minor Gyeyoung Baek
2026-11-21  9:41 ` [PATCH i-g-t 2/3] lib/igt_drm_clients: Also scan accel device nodes Gyeyoung Baek
2026-11-21  9:41 ` [PATCH i-g-t 3/3] tools/gputop: Show device node and driver name in client header Gyeyoung Baek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.