From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Oliver Neukum <oneukum@suse.com>, Alan Stern <stern@rowland.harvard.edu>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org,
"Mateusz Jończyk" <mat.jonczyk@o2.pl>
Subject: [PATCH 1/2] usb: uas: expose US_FL_NO_ATA_1X in sysfs as ata_passthrough_disabled
Date: Sat, 21 Nov 2026 16:52:52 +0100 [thread overview]
Message-ID: <20261121155253.4980-1-mat.jonczyk@o2.pl> (raw)
The uas driver blocks access to ATA passthrough commands for some
devices it considers buggy. However, it does not expose any meaningful
information whether the command was disabled by the driver or is
genuinly not supported by the hardware. This creates a problem for the
smartmontools program and makes it difficult for it to provide a useful
error message.
Link: https://www.smartmontools.org/wiki/SAT-with-UAS-Linux
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
---
v2:
- rename the attribute to ata_passthrough_disabled (to match others),
- add a proper documentation,
- add the ABI documentation for scsi to MAINTAINERS as appropriate,
- add a second patch to expose the information also for the usb-storage
driver,
---
.../ABI/testing/sysfs-class-scsi_device | 10 ++++++++++
MAINTAINERS | 1 +
drivers/usb/storage/uas.c | 20 +++++++++++++++++++
3 files changed, 31 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-scsi_device
diff --git a/Documentation/ABI/testing/sysfs-class-scsi_device b/Documentation/ABI/testing/sysfs-class-scsi_device
new file mode 100644
index 000000000000..4dc8645bf59b
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-class-scsi_device
@@ -0,0 +1,10 @@
+What: /sys/class/scsi_device/*/device/ata_passthrough_disabled
+Date: Nov, 2026
+KernelVersion: v7.5
+Contact: usb-storage@lists.one-eyed-alien.net
+Description: (RO) Indicates whether the driver blocks access from userspace
+ to ATA passthrough commands. Contains a value of '1' when such
+ commands are denied as the hardware is considered buggy and they
+ might interfere with a correct operation of the drive. Note that
+ a value of '0' does not necessarily mean that ATA passthrough is
+ available as it may not be supported by the hardware at all.
diff --git a/MAINTAINERS b/MAINTAINERS
index ccbcdc0799b9..d056984f4998 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25293,6 +25293,7 @@ S: Maintained
Q: https://patchwork.kernel.org/project/linux-scsi/list/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
+F: Documentation/ABI/testing/sysfs-class-scsi_*
F: Documentation/devicetree/bindings/scsi/
F: drivers/scsi/
F: drivers/ufs/
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 8655edbd66b1..49481bfca34c 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -910,6 +910,25 @@ static int uas_sdev_configure(struct scsi_device *sdev,
return 0;
}
+/* Sysfs interface */
+static ssize_t ata_passthrough_disabled_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct scsi_device *sdev = to_scsi_device(dev);
+ struct uas_dev_info *devinfo = sdev->hostdata;
+
+ return sysfs_emit(buf, "%d\n", !!(devinfo->flags & US_FL_NO_ATA_1X));
+}
+
+static DEVICE_ATTR_RO(ata_passthrough_disabled);
+
+static struct attribute *uas_sdev_attrs[] = {
+ &dev_attr_ata_passthrough_disabled.attr,
+ NULL,
+};
+
+ATTRIBUTE_GROUPS(uas_sdev);
+
static const struct scsi_host_template uas_host_template = {
.module = THIS_MODULE,
.name = "uas",
@@ -929,6 +948,7 @@ static const struct scsi_host_template uas_host_template = {
.dma_alignment = 511,
.dma_boundary = PAGE_SIZE - 1,
.cmd_size = sizeof(struct uas_cmd_info),
+ .sdev_groups = uas_sdev_groups,
};
#define UNUSUAL_DEV(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax, \
--
2.47.3
next reply other threads:[~2026-11-21 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 15:52 Mateusz Jończyk [this message]
2026-11-21 15:52 ` [PATCH 2/2] usb: mass storage: expose ata_passthrough_disabled in sysfs Mateusz Jończyk
2026-11-21 15:57 ` [PATCH 1/2] usb: uas: expose US_FL_NO_ATA_1X in sysfs as ata_passthrough_disabled sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121155253.4980-1-mat.jonczyk@o2.pl \
--to=mat.jonczyk@o2.pl \
--cc=James.Bottomley@HansenPartnership.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.