All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Oliver Neukum <oneukum@suse.com>, Alan Stern <stern@rowland.harvard.edu>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <mkp@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
	usb-storage@lists.one-eyed-alien.net,
	linux-kernel@vger.kernel.org,
	"Mateusz Jończyk" <mat.jonczyk@o2.pl>
Subject: [PATCH 2/2] usb: mass storage: expose ata_passthrough_disabled in sysfs
Date: Sat, 21 Nov 2026 16:52:53 +0100	[thread overview]
Message-ID: <20261121155253.4980-2-mat.jonczyk@o2.pl> (raw)
In-Reply-To: <20261121155253.4980-1-mat.jonczyk@o2.pl>

The mass storage driver blocks access to ATA passthrough commands for some
devices it considers buggy. As in the case of the uas driver, indicate
this in sysfs.

Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>

---

v2:
- add this patch to the series
---
 drivers/usb/storage/scsiglue.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
index 97de28e85562..43198888449e 100644
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -572,6 +572,18 @@ US_DO_ALL_FLAGS
  * Sysfs interface
  ***********************************************************************/
 
+/* Output routine for the sysfs ata_passthrough_disabled file */
+static ssize_t ata_passthrough_disabled_show(struct device *dev, struct device_attribute *attr,
+					     char *buf)
+{
+	struct scsi_device *sdev = to_scsi_device(dev);
+	struct us_data *us = host_to_us(sdev->host);
+
+	return sysfs_emit(buf, "%d\n", !!(us->fflags & US_FL_NO_ATA_1X));
+}
+
+static DEVICE_ATTR_RO(ata_passthrough_disabled);
+
 /* Output routine for the sysfs max_sectors file */
 static ssize_t max_sectors_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
@@ -602,6 +614,7 @@ static ssize_t max_sectors_store(struct device *dev, struct device_attribute *at
 static DEVICE_ATTR_RW(max_sectors);
 
 static struct attribute *usb_sdev_attrs[] = {
+	&dev_attr_ata_passthrough_disabled.attr,
 	&dev_attr_max_sectors.attr,
 	NULL,
 };
-- 
2.47.3


  reply	other threads:[~2026-11-21 15:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 15:52 [PATCH 1/2] usb: uas: expose US_FL_NO_ATA_1X in sysfs as ata_passthrough_disabled Mateusz Jończyk
2026-11-21 15:52 ` Mateusz Jończyk [this message]
2026-11-21 15:57 ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121155253.4980-2-mat.jonczyk@o2.pl \
    --to=mat.jonczyk@o2.pl \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mkp@kernel.org \
    --cc=oneukum@suse.com \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.