All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, Will Deacon <will@kernel.org>,
	lkp@intel.com, kbuild-all@lists.01.org,
	linux-arm-kernel@lists.infradead.org,
	Steven Price <steven.price@arm.com>,
	Jianyong Wu <jianyong.wu@arm.com>
Subject: Re: [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'
Date: Wed, 31 Mar 2021 09:17:36 +0100	[thread overview]
Message-ID: <20266a7616a349184aa66790c5851882@kernel.org> (raw)
In-Reply-To: <20210331043704.GG2065@kadam>

On 2021-03-31 05:37, Dan Carpenter wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> kvm-arm64/ptp
> head:   b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2
> commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64:
> Probe for the presence of KVM hypervisor
> config: arm64-randconfig-m031-20210330 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available()
> warn: signedness bug returning '(-22)'
> 
> vim +46 drivers/firmware/smccc/kvm_guest.c
> 
> fa591eac2e1ffd Will Deacon 2020-12-09  43  bool
> kvm_arm_hyp_service_available(u32 func_id)
>                                            ^^^^
> 
> fa591eac2e1ffd Will Deacon 2020-12-09  44  {
> fa591eac2e1ffd Will Deacon 2020-12-09  45  	if (func_id >=
> ARM_SMCCC_KVM_NUM_FUNCS)
> fa591eac2e1ffd Will Deacon 2020-12-09 @46  		return -EINVAL;
>                                                         ^^^^^^^^^^^^^^^
> This counts as true.

Nice catch. Now fixed. Thanks for the heads up.

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'
Date: Wed, 31 Mar 2021 09:17:36 +0100	[thread overview]
Message-ID: <20266a7616a349184aa66790c5851882@kernel.org> (raw)
In-Reply-To: <20210331043704.GG2065@kadam>

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

On 2021-03-31 05:37, Dan Carpenter wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> kvm-arm64/ptp
> head:   b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2
> commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64:
> Probe for the presence of KVM hypervisor
> config: arm64-randconfig-m031-20210330 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available()
> warn: signedness bug returning '(-22)'
> 
> vim +46 drivers/firmware/smccc/kvm_guest.c
> 
> fa591eac2e1ffd Will Deacon 2020-12-09  43  bool
> kvm_arm_hyp_service_available(u32 func_id)
>                                            ^^^^
> 
> fa591eac2e1ffd Will Deacon 2020-12-09  44  {
> fa591eac2e1ffd Will Deacon 2020-12-09  45  	if (func_id >=
> ARM_SMCCC_KVM_NUM_FUNCS)
> fa591eac2e1ffd Will Deacon 2020-12-09 @46  		return -EINVAL;
>                                                         ^^^^^^^^^^^^^^^
> This counts as true.

Nice catch. Now fixed. Thanks for the heads up.

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2021-03-31  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  4:37 [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)' Dan Carpenter
2021-03-31  4:37 ` Dan Carpenter
2021-03-31  4:37 ` Dan Carpenter
2021-03-31  8:17 ` Marc Zyngier [this message]
2021-03-31  8:17   ` Marc Zyngier
  -- strict thread matches above, loose matches on Subject: below --
2021-03-30 22:31 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20266a7616a349184aa66790c5851882@kernel.org \
    --to=maz@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=jianyong.wu@arm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=steven.price@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.