* [PATCH 0/1] Regression in rockchipdrm
@ 2020-01-08 22:39 ` Tobias Schramm
0 siblings, 0 replies; 14+ messages in thread
From: Tobias Schramm @ 2020-01-08 22:39 UTC (permalink / raw)
To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
Cc: dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel,
Tobias Schramm
commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changed
the datatype used for storing the display port data rate to u8.
A u8 is not sufficient to store the data rate, resulting in a crash due
to incorrect calculations.
This series resolves the issue by restoring the data types changed in
commit 2589c4025f13 to their original type.
Tobias Schramm (1):
drm/rockchip: fix integer type used for storing dp data rate and lane
count
drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.24.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 0/1] Regression in rockchipdrm @ 2020-01-08 22:39 ` Tobias Schramm 0 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-08 22:39 UTC (permalink / raw) To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel, linux-kernel commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changed the datatype used for storing the display port data rate to u8. A u8 is not sufficient to store the data rate, resulting in a crash due to incorrect calculations. This series resolves the issue by restoring the data types changed in commit 2589c4025f13 to their original type. Tobias Schramm (1): drm/rockchip: fix integer type used for storing dp data rate and lane count drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.24.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 0/1] Regression in rockchipdrm @ 2020-01-08 22:39 ` Tobias Schramm 0 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-08 22:39 UTC (permalink / raw) To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel, linux-kernel commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changed the datatype used for storing the display port data rate to u8. A u8 is not sufficient to store the data rate, resulting in a crash due to incorrect calculations. This series resolves the issue by restoring the data types changed in commit 2589c4025f13 to their original type. Tobias Schramm (1): drm/rockchip: fix integer type used for storing dp data rate and lane count drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.24.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count 2020-01-08 22:39 ` Tobias Schramm (?) (?) @ 2020-01-08 22:39 ` Tobias Schramm -1 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-08 22:39 UTC (permalink / raw) To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel, linux-kernel commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes the type of variables used to store the display port data rate and number of lanes to u8. However u8 is not sufficient to store the link data rate of the display port. This commit reverts the type of both the number of lanes and the data rate to unsigned int. Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> --- drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h index 83c4586665b4..806cb0b08982 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h @@ -94,8 +94,8 @@ struct cdn_dp_device { struct video_info video_info; struct cdn_dp_port *port[MAX_PHY]; u8 ports; - u8 max_lanes; - u8 max_rate; + unsigned int max_lanes; + unsigned int max_rate; u8 lanes; int active_port; -- 2.24.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-08 22:39 ` Tobias Schramm 0 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-08 22:39 UTC (permalink / raw) To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter Cc: dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel, Tobias Schramm commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes the type of variables used to store the display port data rate and number of lanes to u8. However u8 is not sufficient to store the link data rate of the display port. This commit reverts the type of both the number of lanes and the data rate to unsigned int. Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> --- drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h index 83c4586665b4..806cb0b08982 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h @@ -94,8 +94,8 @@ struct cdn_dp_device { struct video_info video_info; struct cdn_dp_port *port[MAX_PHY]; u8 ports; - u8 max_lanes; - u8 max_rate; + unsigned int max_lanes; + unsigned int max_rate; u8 lanes; int active_port; -- 2.24.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-08 22:39 ` Tobias Schramm 0 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-08 22:39 UTC (permalink / raw) To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel, linux-kernel commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes the type of variables used to store the display port data rate and number of lanes to u8. However u8 is not sufficient to store the link data rate of the display port. This commit reverts the type of both the number of lanes and the data rate to unsigned int. Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> --- drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h index 83c4586665b4..806cb0b08982 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h @@ -94,8 +94,8 @@ struct cdn_dp_device { struct video_info video_info; struct cdn_dp_port *port[MAX_PHY]; u8 ports; - u8 max_lanes; - u8 max_rate; + unsigned int max_lanes; + unsigned int max_rate; u8 lanes; int active_port; -- 2.24.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-08 22:39 ` Tobias Schramm 0 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-08 22:39 UTC (permalink / raw) To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel, linux-kernel commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes the type of variables used to store the display port data rate and number of lanes to u8. However u8 is not sufficient to store the link data rate of the display port. This commit reverts the type of both the number of lanes and the data rate to unsigned int. Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> --- drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h index 83c4586665b4..806cb0b08982 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h @@ -94,8 +94,8 @@ struct cdn_dp_device { struct video_info video_info; struct cdn_dp_port *port[MAX_PHY]; u8 ports; - u8 max_lanes; - u8 max_rate; + unsigned int max_lanes; + unsigned int max_rate; u8 lanes; int active_port; -- 2.24.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count 2020-01-08 22:39 ` Tobias Schramm (?) (?) @ 2020-01-09 0:15 ` Heiko Stübner -1 siblings, 0 replies; 14+ messages in thread From: Heiko Stübner @ 2020-01-09 0:15 UTC (permalink / raw) To: Tobias Schramm Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel, linux-rockchip, Daniel Vetter, linux-arm-kernel Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm: > commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes > the type of variables used to store the display port data rate and > number of lanes to u8. However u8 is not sufficient to store the link > data rate of the display port. > This commit reverts the type of both the number of lanes and the data > rate to unsigned int. > > Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > --- > drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h > index 83c4586665b4..806cb0b08982 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h > @@ -94,8 +94,8 @@ struct cdn_dp_device { > struct video_info video_info; > struct cdn_dp_port *port[MAX_PHY]; > u8 ports; > - u8 max_lanes; > - u8 max_rate; > + unsigned int max_lanes; although I would think u8 should be enough for max_lanes? There shouldn't be be more than 255 dp lanes? Heiko > + unsigned int max_rate; > u8 lanes; > int active_port; > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-09 0:15 ` Heiko Stübner 0 siblings, 0 replies; 14+ messages in thread From: Heiko Stübner @ 2020-01-09 0:15 UTC (permalink / raw) To: Tobias Schramm Cc: Sandy Huang, David Airlie, Daniel Vetter, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm: > commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes > the type of variables used to store the display port data rate and > number of lanes to u8. However u8 is not sufficient to store the link > data rate of the display port. > This commit reverts the type of both the number of lanes and the data > rate to unsigned int. > > Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > --- > drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h > index 83c4586665b4..806cb0b08982 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h > @@ -94,8 +94,8 @@ struct cdn_dp_device { > struct video_info video_info; > struct cdn_dp_port *port[MAX_PHY]; > u8 ports; > - u8 max_lanes; > - u8 max_rate; > + unsigned int max_lanes; although I would think u8 should be enough for max_lanes? There shouldn't be be more than 255 dp lanes? Heiko > + unsigned int max_rate; > u8 lanes; > int active_port; > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-09 0:15 ` Heiko Stübner 0 siblings, 0 replies; 14+ messages in thread From: Heiko Stübner @ 2020-01-09 0:15 UTC (permalink / raw) To: Tobias Schramm Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel, linux-rockchip, linux-arm-kernel Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm: > commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes > the type of variables used to store the display port data rate and > number of lanes to u8. However u8 is not sufficient to store the link > data rate of the display port. > This commit reverts the type of both the number of lanes and the data > rate to unsigned int. > > Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > --- > drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h > index 83c4586665b4..806cb0b08982 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h > @@ -94,8 +94,8 @@ struct cdn_dp_device { > struct video_info video_info; > struct cdn_dp_port *port[MAX_PHY]; > u8 ports; > - u8 max_lanes; > - u8 max_rate; > + unsigned int max_lanes; although I would think u8 should be enough for max_lanes? There shouldn't be be more than 255 dp lanes? Heiko > + unsigned int max_rate; > u8 lanes; > int active_port; > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-09 0:15 ` Heiko Stübner 0 siblings, 0 replies; 14+ messages in thread From: Heiko Stübner @ 2020-01-09 0:15 UTC (permalink / raw) To: Tobias Schramm Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel, linux-rockchip, Daniel Vetter, linux-arm-kernel Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm: > commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes > the type of variables used to store the display port data rate and > number of lanes to u8. However u8 is not sufficient to store the link > data rate of the display port. > This commit reverts the type of both the number of lanes and the data > rate to unsigned int. > > Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > --- > drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h > index 83c4586665b4..806cb0b08982 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h > @@ -94,8 +94,8 @@ struct cdn_dp_device { > struct video_info video_info; > struct cdn_dp_port *port[MAX_PHY]; > u8 ports; > - u8 max_lanes; > - u8 max_rate; > + unsigned int max_lanes; although I would think u8 should be enough for max_lanes? There shouldn't be be more than 255 dp lanes? Heiko > + unsigned int max_rate; > u8 lanes; > int active_port; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count 2020-01-09 0:15 ` Heiko Stübner (?) @ 2020-01-09 6:56 ` Tobias Schramm -1 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-09 6:56 UTC (permalink / raw) To: Heiko Stübner, Tobias Schramm Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel, linux-rockchip, linux-arm-kernel Am 09.01.20 um 01:15 schrieb Heiko Stübner: > Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm: >> commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes >> the type of variables used to store the display port data rate and >> number of lanes to u8. However u8 is not sufficient to store the link >> data rate of the display port. >> This commit reverts the type of both the number of lanes and the data >> rate to unsigned int. >> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> >> --- >> drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h >> index 83c4586665b4..806cb0b08982 100644 >> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h >> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h >> @@ -94,8 +94,8 @@ struct cdn_dp_device { >> struct video_info video_info; >> struct cdn_dp_port *port[MAX_PHY]; >> u8 ports; >> - u8 max_lanes; >> - u8 max_rate; >> + unsigned int max_lanes; > > although I would think u8 should be enough for max_lanes? > There shouldn't be be more than 255 dp lanes? True. I'll test and send a v2. Thanks, Tobias > > Heiko > >> + unsigned int max_rate; >> u8 lanes; >> int active_port; >> >> > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-09 6:56 ` Tobias Schramm 0 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-09 6:56 UTC (permalink / raw) To: Heiko Stübner, Tobias Schramm Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel, linux-rockchip, linux-arm-kernel Am 09.01.20 um 01:15 schrieb Heiko Stübner: > Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm: >> commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes >> the type of variables used to store the display port data rate and >> number of lanes to u8. However u8 is not sufficient to store the link >> data rate of the display port. >> This commit reverts the type of both the number of lanes and the data >> rate to unsigned int. >> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> >> --- >> drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h >> index 83c4586665b4..806cb0b08982 100644 >> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h >> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h >> @@ -94,8 +94,8 @@ struct cdn_dp_device { >> struct video_info video_info; >> struct cdn_dp_port *port[MAX_PHY]; >> u8 ports; >> - u8 max_lanes; >> - u8 max_rate; >> + unsigned int max_lanes; > > although I would think u8 should be enough for max_lanes? > There shouldn't be be more than 255 dp lanes? True. I'll test and send a v2. Thanks, Tobias > > Heiko > >> + unsigned int max_rate; >> u8 lanes; >> int active_port; >> >> > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count @ 2020-01-09 6:56 ` Tobias Schramm 0 siblings, 0 replies; 14+ messages in thread From: Tobias Schramm @ 2020-01-09 6:56 UTC (permalink / raw) To: Heiko Stübner, Tobias Schramm Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel, linux-rockchip, linux-arm-kernel Am 09.01.20 um 01:15 schrieb Heiko Stübner: > Am Mittwoch, 8. Januar 2020, 23:39:49 CET schrieb Tobias Schramm: >> commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes >> the type of variables used to store the display port data rate and >> number of lanes to u8. However u8 is not sufficient to store the link >> data rate of the display port. >> This commit reverts the type of both the number of lanes and the data >> rate to unsigned int. >> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> >> --- >> drivers/gpu/drm/rockchip/cdn-dp-core.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h >> index 83c4586665b4..806cb0b08982 100644 >> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.h >> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h >> @@ -94,8 +94,8 @@ struct cdn_dp_device { >> struct video_info video_info; >> struct cdn_dp_port *port[MAX_PHY]; >> u8 ports; >> - u8 max_lanes; >> - u8 max_rate; >> + unsigned int max_lanes; > > although I would think u8 should be enough for max_lanes? > There shouldn't be be more than 255 dp lanes? True. I'll test and send a v2. Thanks, Tobias > > Heiko > >> + unsigned int max_rate; >> u8 lanes; >> int active_port; >> >> > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-01-09 6:58 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-01-08 22:39 [PATCH 0/1] Regression in rockchipdrm Tobias Schramm 2020-01-08 22:39 ` Tobias Schramm 2020-01-08 22:39 ` Tobias Schramm 2020-01-08 22:39 ` [PATCH 1/1] drm/rockchip: fix integer type used for storing dp data rate and lane count Tobias Schramm 2020-01-08 22:39 ` Tobias Schramm 2020-01-08 22:39 ` Tobias Schramm 2020-01-08 22:39 ` Tobias Schramm 2020-01-09 0:15 ` Heiko Stübner 2020-01-09 0:15 ` Heiko Stübner 2020-01-09 0:15 ` Heiko Stübner 2020-01-09 0:15 ` Heiko Stübner 2020-01-09 6:56 ` Tobias Schramm 2020-01-09 6:56 ` Tobias Schramm 2020-01-09 6:56 ` Tobias Schramm
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.