From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict
Date: Thu, 11 Oct 2012 10:05:51 +0100 [thread overview]
Message-ID: <2029532.l8FLCLtnC1@helios> (raw)
In-Reply-To: <20121011090133.GA3589@jama.jama.net>
On Thursday 11 October 2012 11:01:33 Martin Jansa wrote:
> On Wed, Oct 10, 2012 at 10:42:52AM +0000, git@git.openembedded.org wrote:
> > Module: meta-openembedded.git
> > Branch: master
> > Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696
> > URL:
> > http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f522
> > 80ea9b2f3d7b36ef248be5ba3e7c696
> >
> > Author: Otavio Salvador <otavio@ossystems.com.br>
> > Date: Sat Oct 6 20:18:30 2012 +0000
> > ...
> >
> > -PACKAGES_DYNAMIC = "lib*"
> > +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
>
> Unfortunatelly this does not work, this regexp matches everything starting
> with 'lib', so it's only a bit more strict then old version which matched
> everything starting with 'li' :).
>
> Please change it to:
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)"
> or
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
>
> ^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching
> faster * is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but
> not regexp), so all those last '-' are optional
Are we going to fix this to actually be a glob or are we going to start
treating it as a regex? Frankly I'd prefer to fix it to be a glob since that's
what everyone has assumed it was since the beginning.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-11 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121010104253.EB7AB1034A@opal>
2012-10-11 9:01 ` [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict Martin Jansa
2012-10-11 9:05 ` Paul Eggleton [this message]
2012-10-11 9:32 ` Martin Jansa
2012-10-11 9:38 ` Phil Blundell
2012-10-11 19:34 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2029532.l8FLCLtnC1@helios \
--to=paul.eggleton@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.