* Re: [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict
[not found] <20121010104253.EB7AB1034A@opal>
@ 2012-10-11 9:01 ` Martin Jansa
2012-10-11 9:05 ` Paul Eggleton
2012-10-11 19:34 ` Otavio Salvador
0 siblings, 2 replies; 5+ messages in thread
From: Martin Jansa @ 2012-10-11 9:01 UTC (permalink / raw)
To: openembedded-devel; +Cc: openembedded-commits
[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]
On Wed, Oct 10, 2012 at 10:42:52AM +0000, git@git.openembedded.org wrote:
> Module: meta-openembedded.git
> Branch: master
> Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696
> URL: http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f52280ea9b2f3d7b36ef248be5ba3e7c696
>
> Author: Otavio Salvador <otavio@ossystems.com.br>
> Date: Sat Oct 6 20:18:30 2012 +0000
>
> libav: Change the PACKAGES_DYNAMIC expression to be more restrict
>
> Using 'lib*' we end having problem with every other package that
> generate libraries dynamically thus we changed it to match the library
> prefixes.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>
> ---
>
> meta-oe/recipes-multimedia/libav/libav.inc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-oe/recipes-multimedia/libav/libav.inc b/meta-oe/recipes-multimedia/libav/libav.inc
> index aa170c5..4a1716f 100644
> --- a/meta-oe/recipes-multimedia/libav/libav.inc
> +++ b/meta-oe/recipes-multimedia/libav/libav.inc
> @@ -119,4 +119,4 @@ python populate_packages_prepend() {
> allow_links=True)
> }
>
> -PACKAGES_DYNAMIC = "lib*"
> +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
Unfortunatelly this does not work, this regexp matches everything starting with 'lib',
so it's only a bit more strict then old version which matched everything starting with 'li' :).
Please change it to:
PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)"
or
PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching faster
* is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but not regexp), so all those last '-' are optional
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict
2012-10-11 9:01 ` [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict Martin Jansa
@ 2012-10-11 9:05 ` Paul Eggleton
2012-10-11 9:32 ` Martin Jansa
2012-10-11 19:34 ` Otavio Salvador
1 sibling, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2012-10-11 9:05 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel
On Thursday 11 October 2012 11:01:33 Martin Jansa wrote:
> On Wed, Oct 10, 2012 at 10:42:52AM +0000, git@git.openembedded.org wrote:
> > Module: meta-openembedded.git
> > Branch: master
> > Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696
> > URL:
> > http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f522
> > 80ea9b2f3d7b36ef248be5ba3e7c696
> >
> > Author: Otavio Salvador <otavio@ossystems.com.br>
> > Date: Sat Oct 6 20:18:30 2012 +0000
> > ...
> >
> > -PACKAGES_DYNAMIC = "lib*"
> > +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
>
> Unfortunatelly this does not work, this regexp matches everything starting
> with 'lib', so it's only a bit more strict then old version which matched
> everything starting with 'li' :).
>
> Please change it to:
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)"
> or
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
>
> ^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching
> faster * is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but
> not regexp), so all those last '-' are optional
Are we going to fix this to actually be a glob or are we going to start
treating it as a regex? Frankly I'd prefer to fix it to be a glob since that's
what everyone has assumed it was since the beginning.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict
2012-10-11 9:05 ` Paul Eggleton
@ 2012-10-11 9:32 ` Martin Jansa
2012-10-11 9:38 ` Phil Blundell
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2012-10-11 9:32 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]
On Thu, Oct 11, 2012 at 10:05:51AM +0100, Paul Eggleton wrote:
> On Thursday 11 October 2012 11:01:33 Martin Jansa wrote:
> > On Wed, Oct 10, 2012 at 10:42:52AM +0000, git@git.openembedded.org wrote:
> > > Module: meta-openembedded.git
> > > Branch: master
> > > Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696
> > > URL:
> > > http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f522
> > > 80ea9b2f3d7b36ef248be5ba3e7c696
> > >
> > > Author: Otavio Salvador <otavio@ossystems.com.br>
> > > Date: Sat Oct 6 20:18:30 2012 +0000
> > > ...
> > >
> > > -PACKAGES_DYNAMIC = "lib*"
> > > +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
> >
> > Unfortunatelly this does not work, this regexp matches everything starting
> > with 'lib', so it's only a bit more strict then old version which matched
> > everything starting with 'li' :).
> >
> > Please change it to:
> > PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)"
> > or
> > PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
> >
> > ^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching
> > faster * is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but
> > not regexp), so all those last '-' are optional
>
> Are we going to fix this to actually be a glob or are we going to start
> treating it as a regex? Frankly I'd prefer to fix it to be a glob since that's
> what everyone has assumed it was since the beginning.
glob would make libav PACKAGES_DYNAMIC a bit longer (6 glob expressions)
and would need another bitbake version bump + bump of required version
in sanity test.
Or we can fix all PACKAGES_DYNAMIC expressions:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=3275
Cheers,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict
2012-10-11 9:32 ` Martin Jansa
@ 2012-10-11 9:38 ` Phil Blundell
0 siblings, 0 replies; 5+ messages in thread
From: Phil Blundell @ 2012-10-11 9:38 UTC (permalink / raw)
To: openembedded-devel
On Thu, 2012-10-11 at 11:32 +0200, Martin Jansa wrote:
> glob would make libav PACKAGES_DYNAMIC a bit longer (6 glob expressions)
> and would need another bitbake version bump + bump of required version
> in sanity test.
Also, I don't think there's any precedent for globs in the metadata: all
the other variables I can think of (COMPATIBLE_HOST etc) are regexps.
The fact that people have been using it wrongly up to now doesn't seem
like a particularly compelling reason to change bitbake's behaviour.
There aren't all that many PACKAGES_DYNAMICses in oe-core (and
presumably not all that many more in meta-oe either) and it wouldn't be
very hard to just fix them. I think we should do that.
p.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict
2012-10-11 9:01 ` [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict Martin Jansa
2012-10-11 9:05 ` Paul Eggleton
@ 2012-10-11 19:34 ` Otavio Salvador
1 sibling, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2012-10-11 19:34 UTC (permalink / raw)
To: openembedded-devel
On Thu, Oct 11, 2012 at 6:01 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, Oct 10, 2012 at 10:42:52AM +0000, git@git.openembedded.org wrote:
>> Module: meta-openembedded.git
>> Branch: master
>> Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696
>> URL: http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f52280ea9b2f3d7b36ef248be5ba3e7c696
>>
>> Author: Otavio Salvador <otavio@ossystems.com.br>
>> Date: Sat Oct 6 20:18:30 2012 +0000
>>
>> libav: Change the PACKAGES_DYNAMIC expression to be more restrict
>>
>> Using 'lib*' we end having problem with every other package that
>> generate libraries dynamically thus we changed it to match the library
>> prefixes.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>>
>> ---
>>
>> meta-oe/recipes-multimedia/libav/libav.inc | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta-oe/recipes-multimedia/libav/libav.inc b/meta-oe/recipes-multimedia/libav/libav.inc
>> index aa170c5..4a1716f 100644
>> --- a/meta-oe/recipes-multimedia/libav/libav.inc
>> +++ b/meta-oe/recipes-multimedia/libav/libav.inc
>> @@ -119,4 +119,4 @@ python populate_packages_prepend() {
>> allow_links=True)
>> }
>>
>> -PACKAGES_DYNAMIC = "lib*"
>> +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
>
> Unfortunatelly this does not work, this regexp matches everything starting with 'lib',
> so it's only a bit more strict then old version which matched everything starting with 'li' :).
>
> Please change it to:
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)"
> or
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
>
> ^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching faster
> * is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but not regexp), so all those last '-' are optional
PACKAGES_DYNAMIC =
"^lib(av(codec|device|filter|format|util)|postproc).*" is the right
one.
Koen, I am traveling but people amend my patch commit it please ... or
I send a new revision next week.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-11 19:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121010104253.EB7AB1034A@opal>
2012-10-11 9:01 ` [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict Martin Jansa
2012-10-11 9:05 ` Paul Eggleton
2012-10-11 9:32 ` Martin Jansa
2012-10-11 9:38 ` Phil Blundell
2012-10-11 19:34 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.