From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] ARM: MCS814x: add Device Tree bindings documentation
Date: Tue, 17 Jul 2012 15:35:24 +0200 [thread overview]
Message-ID: <2030205.GuLVzJk5dq@flexo> (raw)
In-Reply-To: <201207171324.11392.arnd@arndb.de>
On Tuesday 17 July 2012 13:24:10 Arnd Bergmann wrote:
> On Sunday 15 July 2012, Florian Fainelli wrote:
>
> > diff --git a/Documentation/devicetree/bindings/arm/mcs814x/mcs814x-pci.txt
b/Documentation/devicetree/bindings/arm/mcs814x/mcs814x-pci.txt
> > new file mode 100644
> > index 0000000..de59b04
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/mcs814x/mcs814x-pci.txt
> > @@ -0,0 +1,16 @@
> > +Moschip MCS814x PCI controller bindings
> > +---------------------------------------
> > +
> > +Required properties:
> > +- compatible: should be "moschip,mcs814x-pci"
> > +- reg: should contain the base register address and length of the PCI
controller
> > + configuration register as well as the base register address and length
of the
> > + PCI eeprom emulator
> > +- interrupts: should contain the interrupt line of the abort interrupt
> > +- #address-cells: should be 3
> > +- #size-cells: should be 2
> > +- ranges: should contain the properly encoded PCI ranges of the IO, non-
prefetchable
> > + and prefetchable memory regions
> > +- #interrupt-cells: should be 1
> > +- interrupt-map-mask: should be 0
> > +- interrupt-map: should be the properly encoded PCI slot/pin to interrupt
line
>
> interrupt-map-mask of 0 implies that all devices are wired to the
> same IRQ lines, which is rather unusual. Better leave that open
> so the interrupt-map can be written to work on any board.
>
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > index 6eab917..943e4f3 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -28,6 +28,7 @@ linux Linux-specific binding
> > marvell Marvell Technology Group Ltd.
> > maxim Maxim Integrated Products
> > mosaixtech Mosaix Technologies, Inc.
> > +moschp Moschip Semiconductors
> > national National Semiconductor
> > nintendo Nintendo
> > nvidia NVIDIA
>
> This string does not match what you use everywhere else. Please fix
> either the documentation here or every other instance. The stock
> ticker symbol is MOSCHIP.BO, so using "moschip" is probably better
> than "moschp".
This was actually a typo, I meant to type "moschip" instead of "moschp", I
will fix that of course.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: olof@lixom.net, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/8] ARM: MCS814x: add Device Tree bindings documentation
Date: Tue, 17 Jul 2012 15:35:24 +0200 [thread overview]
Message-ID: <2030205.GuLVzJk5dq@flexo> (raw)
In-Reply-To: <201207171324.11392.arnd@arndb.de>
On Tuesday 17 July 2012 13:24:10 Arnd Bergmann wrote:
> On Sunday 15 July 2012, Florian Fainelli wrote:
>
> > diff --git a/Documentation/devicetree/bindings/arm/mcs814x/mcs814x-pci.txt
b/Documentation/devicetree/bindings/arm/mcs814x/mcs814x-pci.txt
> > new file mode 100644
> > index 0000000..de59b04
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/mcs814x/mcs814x-pci.txt
> > @@ -0,0 +1,16 @@
> > +Moschip MCS814x PCI controller bindings
> > +---------------------------------------
> > +
> > +Required properties:
> > +- compatible: should be "moschip,mcs814x-pci"
> > +- reg: should contain the base register address and length of the PCI
controller
> > + configuration register as well as the base register address and length
of the
> > + PCI eeprom emulator
> > +- interrupts: should contain the interrupt line of the abort interrupt
> > +- #address-cells: should be 3
> > +- #size-cells: should be 2
> > +- ranges: should contain the properly encoded PCI ranges of the IO, non-
prefetchable
> > + and prefetchable memory regions
> > +- #interrupt-cells: should be 1
> > +- interrupt-map-mask: should be 0
> > +- interrupt-map: should be the properly encoded PCI slot/pin to interrupt
line
>
> interrupt-map-mask of 0 implies that all devices are wired to the
> same IRQ lines, which is rather unusual. Better leave that open
> so the interrupt-map can be written to work on any board.
>
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > index 6eab917..943e4f3 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -28,6 +28,7 @@ linux Linux-specific binding
> > marvell Marvell Technology Group Ltd.
> > maxim Maxim Integrated Products
> > mosaixtech Mosaix Technologies, Inc.
> > +moschp Moschip Semiconductors
> > national National Semiconductor
> > nintendo Nintendo
> > nvidia NVIDIA
>
> This string does not match what you use everywhere else. Please fix
> either the documentation here or every other instance. The stock
> ticker symbol is MOSCHIP.BO, so using "moschip" is probably better
> than "moschp".
This was actually a typo, I meant to type "moschip" instead of "moschp", I
will fix that of course.
--
Florian
next prev parent reply other threads:[~2012-07-17 13:35 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 14:49 [PATCH 0/8] ARM: support for Moschip MCS814x SoCs Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-15 14:49 ` [PATCH 1/8] " Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-16 12:29 ` Thomas Petazzoni
2012-07-16 12:29 ` Thomas Petazzoni
2012-07-16 12:43 ` Florian Fainelli
2012-07-16 12:43 ` Florian Fainelli
2012-07-16 15:55 ` Arnd Bergmann
2012-07-16 15:55 ` Arnd Bergmann
2012-07-16 17:57 ` Nicolas Pitre
2012-07-16 17:57 ` Nicolas Pitre
2012-07-23 19:11 ` Florian Fainelli
2012-07-23 19:11 ` Florian Fainelli
2012-07-27 22:42 ` Linus Walleij
2012-07-27 22:42 ` Linus Walleij
2012-07-16 15:54 ` Arnd Bergmann
2012-07-16 15:54 ` Arnd Bergmann
2012-07-16 20:47 ` Turquette, Mike
2012-07-16 20:47 ` Turquette, Mike
2012-07-17 9:41 ` Florian Fainelli
2012-07-17 9:41 ` Florian Fainelli
2012-07-17 10:47 ` Florian Fainelli
2012-07-17 10:47 ` Florian Fainelli
2012-07-16 22:12 ` Linus Walleij
2012-07-16 22:12 ` Linus Walleij
2012-07-17 9:35 ` Florian Fainelli
2012-07-17 9:35 ` Florian Fainelli
2012-07-17 9:34 ` Florian Fainelli
2012-07-17 9:34 ` Florian Fainelli
2012-07-17 13:07 ` Arnd Bergmann
2012-07-17 13:07 ` Arnd Bergmann
2012-07-17 13:32 ` Florian Fainelli
2012-07-17 13:32 ` Florian Fainelli
2012-07-17 13:45 ` Arnd Bergmann
2012-07-17 13:45 ` Arnd Bergmann
2012-07-17 10:16 ` Thomas Petazzoni
2012-07-17 10:16 ` Thomas Petazzoni
2012-07-17 13:12 ` Arnd Bergmann
2012-07-17 13:12 ` Arnd Bergmann
2012-07-17 13:28 ` Thomas Petazzoni
2012-07-17 13:28 ` Thomas Petazzoni
2012-07-17 13:51 ` Arnd Bergmann
2012-07-17 13:51 ` Arnd Bergmann
2012-07-16 22:06 ` Linus Walleij
2012-07-16 22:06 ` Linus Walleij
2012-07-15 14:49 ` [PATCH 2/8] ARM: MCS814x: add Device Tree based MCS8140 board support Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-17 13:19 ` Arnd Bergmann
2012-07-17 13:19 ` Arnd Bergmann
2012-07-17 13:34 ` Florian Fainelli
2012-07-17 13:34 ` Florian Fainelli
2012-07-17 13:53 ` Arnd Bergmann
2012-07-17 13:53 ` Arnd Bergmann
2012-07-17 13:57 ` Florian Fainelli
2012-07-17 13:57 ` Florian Fainelli
2012-07-15 14:49 ` [PATCH 3/8] ARM: MCS814x: add Device Tree bindings documentation Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-17 13:24 ` Arnd Bergmann
2012-07-17 13:24 ` Arnd Bergmann
2012-07-17 13:35 ` Florian Fainelli [this message]
2012-07-17 13:35 ` Florian Fainelli
2012-07-15 14:49 ` [PATCH 4/8] ARM: MCS814X: add DTS file for Tigal/Robotech RBT-832 Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-17 13:27 ` Arnd Bergmann
2012-07-17 13:27 ` Arnd Bergmann
2012-07-15 14:49 ` [PATCH 5/8] ARM: MCS814x: add DTS file for Devolo dLAN USB Extender Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-15 14:49 ` [PATCH 6/8] ARM: MCS814x: provide a sample defconfig file Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-15 14:49 ` [PATCH 7/8] ARM: MSC814X: add Kconfig and Makefile to arch/arm Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-15 14:49 ` [PATCH 8/8] ARM: MSC814x: add MAINTAINERS entry Florian Fainelli
2012-07-15 14:49 ` Florian Fainelli
2012-07-15 19:59 ` [PATCH 0/8] ARM: support for Moschip MCS814x SoCs Arnd Bergmann
2012-07-15 19:59 ` Arnd Bergmann
2012-07-16 8:16 ` Florian Fainelli
2012-07-16 8:16 ` Florian Fainelli
2012-07-16 18:09 ` Nicolas Pitre
2012-07-16 18:09 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2030205.GuLVzJk5dq@flexo \
--to=florian@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.