[linux-lvm] Patch for Kernel 2.2.16

[linux-lvm] Patch for Kernel 2.2.16

[ZECHA,HOLGER (HP-Germany,ex1)]

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]

Hello,
 
is there a lvm patch for kernel 2.2.16 available ?
 
Regards 
 
Holger Zecha
 

[-- Attachment #2: Type: application/ms-tnef, Size: 2244 bytes --]

Re: [linux-lvm] Patch for Kernel 2.2.16

[AJ Lewis]

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

On Fri, Jan 19, 2001 at 04:19:54PM +0100, ZECHA,HOLGER (HP-Germany,ex1) wrote:
> is there a lvm patch for kernel 2.2.16 available ?

By following the instructions in the PATCHES/README file for 0.9.1 Beta2, I
was able to generate a patch that appears to work for 2.2.16.  I copied the
fragments-2.2.18 file to fragments-2.2.16 and ran 'make' in the PATCHES
directory.  This created a file called lvm-0.9.1_beta2-2.2.16.patch.

I grabbed the 2.2.16 rawio patch from the 0.8.1 release of LVM.  (You can
get this from the LVM ftp site at
ftp://ftp.sistina.com/LVM/0.8.1/PATCHES/linux-2.2.16-rawio.patch)  I applied
this rawio patch and the generated lvm patch to the clean 2.2.16 kernel,
configured, and built the kernel.  After installing the kernel and rebooting
the machine, I was able to see the volume group i had created with a 2.2.18
kernel and LVM 0.9.1 Beta2.  I mounted a logical volume from the volume
group, and was able to use it.  

That is the extent of the testing I have done, so if you are worried about
your data, don't do this!  Or at least backup your data before trying it.
Good luck.

-- 
AJ Lewis
Sistina Software Inc.                  Voice:  612-379-3951
1313 5th St SE, Suite 111              Fax:    612-379-3952
Minneapolis, MN 55414                  E-Mail: lewis@sistina.com
http://www.sistina.com

Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B  52A0 941E 1261 0029 2648
Get my key at: http://www.sistina.com/~lewis/gpgkey
 (Unfortunately, the PKS-type keyservers do not work with multiple sub-keys)

-----Begin Obligatory Humorous Quote----------------------------------------
Students nowadays, complaining they only get 5MBs of disk space!
In my day we were lucky if we had one file, and that was /dev/null.
-----End Obligatory Humorous Quote------------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [linux-lvm] Patch for Kernel 2.2.16

[Joe Thornber]

On Fri, Jan 19, 2001 at 04:19:54PM +0100, ZECHA,HOLGER (HP-Germany,ex1) wrote:
> Hello,
>  
> is there a lvm patch for kernel 2.2.16 available ?
>  
> Regards 
>  
> Holger Zecha
>  

read PATCHES/README

- Joe

Re: [linux-lvm] Patch for Kernel 2.2.16

[AJ Lewis]

[-- Attachment #1: Type: text/plain, Size: 2154 bytes --]

On Fri, Jan 19, 2001 at 10:17:57AM -0600, AJ Lewis wrote:
> On Fri, Jan 19, 2001 at 04:19:54PM +0100, ZECHA,HOLGER (HP-Germany,ex1) wrote:
> > is there a lvm patch for kernel 2.2.16 available ?
> 
> By following the instructions in the PATCHES/README file for 0.9.1 Beta2, I
> was able to generate a patch that appears to work for 2.2.16.  I copied the
> fragments-2.2.18 file to fragments-2.2.16 and ran 'make' in the PATCHES
> directory.  This created a file called lvm-0.9.1_beta2-2.2.16.patch.
> 
> I grabbed the 2.2.16 rawio patch from the 0.8.1 release of LVM.  (You can
> get this from the LVM ftp site at
> ftp://ftp.sistina.com/LVM/0.8.1/PATCHES/linux-2.2.16-rawio.patch)  I applied
> this rawio patch and the generated lvm patch to the clean 2.2.16 kernel,
> configured, and built the kernel.  After installing the kernel and rebooting
> the machine, I was able to see the volume group i had created with a 2.2.18
> kernel and LVM 0.9.1 Beta2.  I mounted a logical volume from the volume
> group, and was able to use it.  
> 
> That is the extent of the testing I have done, so if you are worried about
> your data, don't do this!  Or at least backup your data before trying it.
> Good luck.
> 

After testing a bit more, I have found a bug in the snapshot creation.
Under load, you can get a 
'kernel panic: brw_kiovec: iobuf not locked for I/O'

Joe, is this the same as the problem you discussed in the 
"[linux-lvm] Kernel panic while snapshotting."
thread?

-- 
AJ Lewis
Sistina Software Inc.                  Voice:  612-379-3951
1313 5th St SE, Suite 111              Fax:    612-379-3952
Minneapolis, MN 55414                  E-Mail: lewis@sistina.com
http://www.sistina.com

Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B  52A0 941E 1261 0029 2648
Get my key at: http://www.sistina.com/~lewis/gpgkey
 (Unfortunately, the PKS-type keyservers do not work with multiple sub-keys)

-----Begin Obligatory Humorous Quote----------------------------------------
Linux: Because rebooting is for adding new hardware.
-----End Obligatory Humorous Quote------------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [linux-lvm] Patch for Kernel 2.2.16

[Joe Thornber]

On Fri, Jan 19, 2001 at 10:49:32AM -0600, AJ Lewis wrote:
> After testing a bit more, I have found a bug in the snapshot creation.
> Under load, you can get a 
> 'kernel panic: brw_kiovec: iobuf not locked for I/O'
> 
> Joe, is this the same as the problem you discussed in the 
> "[linux-lvm] Kernel panic while snapshotting."
> thread?

Sounds like it.  Can you try reversing that patch as well please ?

- Joe

Re: [linux-lvm] Patch for Kernel 2.2.16

[Heinz J. Mauelshagen]

On Fri, Jan 19, 2001 at 10:49:32AM -0600, AJ Lewis wrote:
> On Fri, Jan 19, 2001 at 10:17:57AM -0600, AJ Lewis wrote:
> > On Fri, Jan 19, 2001 at 04:19:54PM +0100, ZECHA,HOLGER (HP-Germany,ex1) wrote:
> > > is there a lvm patch for kernel 2.2.16 available ?
> > 
> > By following the instructions in the PATCHES/README file for 0.9.1 Beta2, I
> > was able to generate a patch that appears to work for 2.2.16.  I copied the
> > fragments-2.2.18 file to fragments-2.2.16 and ran 'make' in the PATCHES
> > directory.  This created a file called lvm-0.9.1_beta2-2.2.16.patch.
> > 
> > I grabbed the 2.2.16 rawio patch from the 0.8.1 release of LVM.  (You can
> > get this from the LVM ftp site at
> > ftp://ftp.sistina.com/LVM/0.8.1/PATCHES/linux-2.2.16-rawio.patch)  I applied
> > this rawio patch and the generated lvm patch to the clean 2.2.16 kernel,
> > configured, and built the kernel.  After installing the kernel and rebooting
> > the machine, I was able to see the volume group i had created with a 2.2.18
> > kernel and LVM 0.9.1 Beta2.  I mounted a logical volume from the volume
> > group, and was able to use it.  
> > 
> > That is the extent of the testing I have done, so if you are worried about
> > your data, don't do this!  Or at least backup your data before trying it.
> > Good luck.
> > 
> 
> After testing a bit more, I have found a bug in the snapshot creation.
> Under load, you can get a 
> 'kernel panic: brw_kiovec: iobuf not locked for I/O'

I think Andrea Arcangeli's patch set the previously introduced

iobuf->locked = 1; 

to 0 again.
Change it to 1 and test.
This should fix it.

> 
> Joe, is this the same as the problem you discussed in the 
> "[linux-lvm] Kernel panic while snapshotting."
> thread?
> 
> -- 
> AJ Lewis
> Sistina Software Inc.                  Voice:  612-379-3951
> 1313 5th St SE, Suite 111              Fax:    612-379-3952
> Minneapolis, MN 55414                  E-Mail: lewis@sistina.com
> http://www.sistina.com
> 
> Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B  52A0 941E 1261 0029 2648
> Get my key at: http://www.sistina.com/~lewis/gpgkey
>  (Unfortunately, the PKS-type keyservers do not work with multiple sub-keys)
> 
> -----Begin Obligatory Humorous Quote----------------------------------------
> Linux: Because rebooting is for adding new hardware.
> -----End Obligatory Humorous Quote------------------------------------------



-- 

Regards,
Heinz    -- The LVM Guy --

*** Software bugs are stupid.
    Nevertheless it needs not so stupid people to solve them ***

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-lvm] Patch for Kernel 2.2.16

[AJ Lewis]

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

On Fri, Jan 19, 2001 at 05:22:40PM +0000, Joe Thornber wrote:
> On Fri, Jan 19, 2001 at 10:49:32AM -0600, AJ Lewis wrote:
> > After testing a bit more, I have found a bug in the snapshot creation.
> > Under load, you can get a 
> > 'kernel panic: brw_kiovec: iobuf not locked for I/O'
> > 
> > Joe, is this the same as the problem you discussed in the 
> > "[linux-lvm] Kernel panic while snapshotting."
> > thread?
> 
> Sounds like it.  Can you try reversing that patch as well please ?

I reversed that patch and it fixed the panic.  I 'spose we should pull that
out of the CVS.  Does it need to be in there for 2.4.x?

-- 
AJ Lewis
Sistina Software Inc.                  Voice:  612-379-3951
1313 5th St SE, Suite 111              Fax:    612-379-3952
Minneapolis, MN 55414                  E-Mail: lewis@sistina.com
http://www.sistina.com

Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B  52A0 941E 1261 0029 2648
Get my key at: http://www.sistina.com/~lewis/gpgkey
 (Unfortunately, the PKS-type keyservers do not work with multiple sub-keys)

-----Begin Obligatory Humorous Quote----------------------------------------
A morning without coffee is like something without something else.
-----End Obligatory Humorous Quote------------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [linux-lvm] Patch for Kernel 2.2.16

[Chris Mason]

On Friday, January 19, 2001 06:17:35 PM +0000 "Heinz J. Mauelshagen"
<Heinz.Mauelshagen@t-online.de> wrote:

>> After testing a bit more, I have found a bug in the snapshot creation.
>> Under load, you can get a 
>> 'kernel panic: brw_kiovec: iobuf not locked for I/O'
> 
> I think Andrea Arcangeli's patch set the previously introduced
> 
> iobuf->locked = 1; 
> 
> to 0 again.
> Change it to 1 and test.
> This should fix it.
> 

Yes, this diff looks like it came from Andrea's code, but his brw_kiovec
doesn't panic when the iobuf isn't locked.

-chris

Re: [linux-lvm] Patch for Kernel 2.2.16

[Joe Thornber]

On Fri, Jan 19, 2001 at 01:51:15PM -0600, AJ Lewis wrote:
> I reversed that patch and it fixed the panic.  I 'spose we should pull that
> out of the CVS.  Does it need to be in there for 2.4.x?

I'll look into it.  As you know this was one area that I was unsure
about my original fix.  I need to read raw_io for and convince myself
we have the right solution.  This is top of my list.

- Joe