All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	K Prasad <prasad@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: powerpc/perf: hw breakpoints return ENOSPC
Date: Thu, 16 Aug 2012 21:17:29 +1000	[thread overview]
Message-ID: <20344.1345115849@neuling.org> (raw)
In-Reply-To: <1345102812.31459.114.camel@twins>

Peter,

> > On this second syscall, fetch_bp_busy_slots() sets slots.pinned to be 1,
> > despite there being no breakpoint on this CPU.  This is because the call
> > the task_bp_pinned, checks all CPUs, rather than just the current CPU.
> > POWER7 only has one hardware breakpoint per CPU (ie. HBP_NUM=1), so we
> > return ENOSPC.
> 
> I think this comes from the ptrace legacy, we register a breakpoint on
> all cpus because when we migrate a task it cannot fail to migrate the
> breakpoint.
> 
> Its one of the things I hate most about the hwbp stuff as it relates to
> perf.
> 
> Frederic knows more...

Maybe I should wait for Frederic to respond but I'm not sure I
understand what you're saying.

I can see how using ptrace hw breakpoints and perf hw breakpoints at the
same time could be a problem, but I'm not sure how this would stop it.

Are you saying that we need to keep at least 1 slot free at all times,
so that we can use it for ptrace?

Is "perf record -e mem:0x10000000 true" ever going to be able to work on
POWER7 with only one hw breakpoint resource per CPU?  

Thanks,
Mikey

WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: K Prasad <prasad@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: powerpc/perf: hw breakpoints return ENOSPC
Date: Thu, 16 Aug 2012 21:17:29 +1000	[thread overview]
Message-ID: <20344.1345115849@neuling.org> (raw)
In-Reply-To: <1345102812.31459.114.camel@twins>

Peter,

> > On this second syscall, fetch_bp_busy_slots() sets slots.pinned to be 1,
> > despite there being no breakpoint on this CPU.  This is because the call
> > the task_bp_pinned, checks all CPUs, rather than just the current CPU.
> > POWER7 only has one hardware breakpoint per CPU (ie. HBP_NUM=1), so we
> > return ENOSPC.
> 
> I think this comes from the ptrace legacy, we register a breakpoint on
> all cpus because when we migrate a task it cannot fail to migrate the
> breakpoint.
> 
> Its one of the things I hate most about the hwbp stuff as it relates to
> perf.
> 
> Frederic knows more...

Maybe I should wait for Frederic to respond but I'm not sure I
understand what you're saying.

I can see how using ptrace hw breakpoints and perf hw breakpoints at the
same time could be a problem, but I'm not sure how this would stop it.

Are you saying that we need to keep at least 1 slot free at all times,
so that we can use it for ptrace?

Is "perf record -e mem:0x10000000 true" ever going to be able to work on
POWER7 with only one hw breakpoint resource per CPU?  

Thanks,
Mikey

  reply	other threads:[~2012-08-16 11:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16  4:23 powerpc/perf: hw breakpoints return ENOSPC Michael Neuling
2012-08-16  4:23 ` Michael Neuling
2012-08-16  7:40 ` Peter Zijlstra
2012-08-16  7:40   ` Peter Zijlstra
2012-08-16 11:17   ` Michael Neuling [this message]
2012-08-16 11:17     ` Michael Neuling
2012-08-16 11:44     ` Peter Zijlstra
2012-08-16 11:44       ` Peter Zijlstra
2012-08-16 14:02       ` Michael Ellerman
2012-08-16 14:02         ` Michael Ellerman
2012-08-16 14:15         ` Peter Zijlstra
2012-08-16 14:15           ` Peter Zijlstra
2012-08-17  1:20           ` Michael Ellerman
2012-08-17  1:20             ` Michael Ellerman
2012-08-16 23:34       ` Michael Neuling
2012-08-16 23:34         ` Michael Neuling
2012-08-17 16:15 ` Frederic Weisbecker
2012-08-17 16:15   ` Frederic Weisbecker
2012-08-17 21:58   ` Michael Neuling
2012-08-17 21:58     ` Michael Neuling
2012-09-25  7:10     ` Michael Neuling
2012-09-25  7:10       ` Michael Neuling
2012-09-27 15:23       ` Frederic Weisbecker
2012-09-27 15:23         ` Frederic Weisbecker
2012-09-27  1:02 ` Jovi Zhang
2012-09-27  1:02   ` Jovi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20344.1345115849@neuling.org \
    --to=mikey@neuling.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=prasad@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.