From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: Johan Jonker <jbx6244@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
Date: Tue, 12 May 2020 03:09:30 +0200 [thread overview]
Message-ID: <2039286.bXBTDbpnOK@diego> (raw)
In-Reply-To: <20200511213605.GA14679@bogus>
Am Montag, 11. Mai 2020, 23:36:05 CEST schrieb Rob Herring:
> On Fri, Apr 24, 2020 at 05:11:05PM +0200, Johan Jonker wrote:
> > The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
> > RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
> > "deprecated" to prevent that someone start using them again.
>
> What changed exactly? The binding changed, or just using raw 0-6 instead
> of the defines?
This ... they are just dumb mappings of RK_GPIOx -> x so we switched
over to just using the raw numbers, as the constants do not provide any
additional information.
> If there's not anything using these in tree, just delete them.
Ok, good to know that we can just delete them if noone is using them
anymore.
> It is still used in the binding doc.
I think Johan will provide a v2 with that.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Johan Jonker <jbx6244@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated
Date: Tue, 12 May 2020 03:09:30 +0200 [thread overview]
Message-ID: <2039286.bXBTDbpnOK@diego> (raw)
In-Reply-To: <20200511213605.GA14679@bogus>
Am Montag, 11. Mai 2020, 23:36:05 CEST schrieb Rob Herring:
> On Fri, Apr 24, 2020 at 05:11:05PM +0200, Johan Jonker wrote:
> > The defines RK_GPIO0, RK_GPIO1, RK_GPIO2, RK_GPIO3,
> > RK_GPIO4 and RK_GPIO6 are no longer used. Mark them as
> > "deprecated" to prevent that someone start using them again.
>
> What changed exactly? The binding changed, or just using raw 0-6 instead
> of the defines?
This ... they are just dumb mappings of RK_GPIOx -> x so we switched
over to just using the raw numbers, as the constants do not provide any
additional information.
> If there's not anything using these in tree, just delete them.
Ok, good to know that we can just delete them if noone is using them
anymore.
> It is still used in the binding doc.
I think Johan will provide a v2 with that.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-12 1:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 15:11 [PATCH] include: dt-bindings: rockchip: mark RK_GPIO defines as deprecated Johan Jonker
2020-04-24 15:11 ` Johan Jonker
2020-04-24 15:11 ` Johan Jonker
[not found] ` <20200424151105.18736-1-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-05-11 21:36 ` Rob Herring
2020-05-11 21:36 ` Rob Herring
2020-05-11 21:36 ` Rob Herring
2020-05-12 1:09 ` Heiko Stübner [this message]
2020-05-12 1:09 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2039286.bXBTDbpnOK@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.