From: Heiko Stuebner <heiko@sntech.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] phy: rockhip-usb: use devm_add_action_or_reset()
Date: Sun, 03 Jul 2016 23:34:07 +0200 [thread overview]
Message-ID: <2045236.FJVOO9eQKE@phil> (raw)
In-Reply-To: <1467579666-9179-1-git-send-email-sudipm.mukherjee@gmail.com>
Am Sonntag, 3. Juli 2016, 22:01:06 schrieb Sudip Mukherjee:
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated. Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup function
> has been already called by the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
a nice new helper this devm_add_action_or_reset.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: rockhip-usb: use devm_add_action_or_reset()
Date: Sun, 03 Jul 2016 23:34:07 +0200 [thread overview]
Message-ID: <2045236.FJVOO9eQKE@phil> (raw)
In-Reply-To: <1467579666-9179-1-git-send-email-sudipm.mukherjee@gmail.com>
Am Sonntag, 3. Juli 2016, 22:01:06 schrieb Sudip Mukherjee:
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated. Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup function
> has been already called by the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
a nice new helper this devm_add_action_or_reset.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2016-07-03 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 21:01 [PATCH] phy: rockhip-usb: use devm_add_action_or_reset() Sudip Mukherjee
2016-07-03 21:01 ` Sudip Mukherjee
2016-07-03 21:34 ` Heiko Stuebner [this message]
2016-07-03 21:34 ` Heiko Stuebner
2016-07-04 10:56 ` Kishon Vijay Abraham I
2016-07-04 10:56 ` Kishon Vijay Abraham I
2016-07-04 10:56 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2045236.FJVOO9eQKE@phil \
--to=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.