From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Paul Burton <paul.burton@mips.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@amacapital.net>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <linux@arm.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>,
Ben Maurer <bmaurer@fb.com>, rostedt <rostedt@goodmis.org>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will
Subject: Re: [RFC PATCH for 5.2 10/10] rseq/selftests: mips: use break instruction for RSEQ_SIG
Date: Wed, 24 Apr 2019 19:22:57 -0400 (EDT) [thread overview]
Message-ID: <2047127593.1305.1556148177478.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20190424231717.os4p6fq7fbx6afxa@pburton-laptop>
----- On Apr 24, 2019, at 7:17 PM, Paul Burton paul.burton@mips.com wrote:
> Hi Mathieu,
>
> On Wed, Apr 24, 2019 at 07:12:03PM -0400, Mathieu Desnoyers wrote:
>> Does the following comment above the forest of #ifdef work for you ?
>>
>> /*
>> * RSEQ_SIG uses the break instruction. The instruction pattern is:
>> *
>> * On MIPS:
>> * 0350000d break 0x350
>> *
>> * On nanoMIPS32:
>> * 00100350 break 0x350
>> *
>> * On microMIPS:
>> * 0000d407 break 0x350
>> *
>> * For nanoMIPS32 and microMIPS, the instruction stream is encoded as 16-bit
>> * halfwords, so the signature halfwords need to be swapped accordingly for
>> * little-endian.
>> */
>
> I'd probably just say nanoMIPS rather than nanoMIPS32, because when we
> get nanoMIPS64 in the future it'll be a superset of nanoMIPS32 & the
> break encoding will be the same.
Done.
>
> But otherwise it looks good to me :)
Great! I've added your "Suggested-by" tag to the patch.
Thanks,
Mathieu
>
> Thanks,
> Paul
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Paul Burton <paul.burton@mips.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@amacapital.net>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <linux@arm.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>,
Ben Maurer <bmaurer@fb.com>, rostedt <rostedt@goodmis.org>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Joel Fernandes <joelaf@google.com>, shuah <shuah@kernel.org>,
James Hogan <jhogan@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [RFC PATCH for 5.2 10/10] rseq/selftests: mips: use break instruction for RSEQ_SIG
Date: Wed, 24 Apr 2019 19:22:57 -0400 (EDT) [thread overview]
Message-ID: <2047127593.1305.1556148177478.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20190424231717.os4p6fq7fbx6afxa@pburton-laptop>
----- On Apr 24, 2019, at 7:17 PM, Paul Burton paul.burton@mips.com wrote:
> Hi Mathieu,
>
> On Wed, Apr 24, 2019 at 07:12:03PM -0400, Mathieu Desnoyers wrote:
>> Does the following comment above the forest of #ifdef work for you ?
>>
>> /*
>> * RSEQ_SIG uses the break instruction. The instruction pattern is:
>> *
>> * On MIPS:
>> * 0350000d break 0x350
>> *
>> * On nanoMIPS32:
>> * 00100350 break 0x350
>> *
>> * On microMIPS:
>> * 0000d407 break 0x350
>> *
>> * For nanoMIPS32 and microMIPS, the instruction stream is encoded as 16-bit
>> * halfwords, so the signature halfwords need to be swapped accordingly for
>> * little-endian.
>> */
>
> I'd probably just say nanoMIPS rather than nanoMIPS32, because when we
> get nanoMIPS64 in the future it'll be a superset of nanoMIPS32 & the
> break encoding will be the same.
Done.
>
> But otherwise it looks good to me :)
Great! I've added your "Suggested-by" tag to the patch.
Thanks,
Mathieu
>
> Thanks,
> Paul
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2019-04-24 23:22 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 15:24 [RFC PATCH for 5.2 00/10] Restartable Sequences selftests updates Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` [RFC PATCH for 5.2 01/10] rseq/selftests: Add __rseq_exit_point_array section for debuggers Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` mathieu.desnoyers
2019-04-24 15:24 ` [RFC PATCH for 5.2 02/10] rseq/selftests: Introduce __rseq_cs_ptr_array, rename __rseq_table to __rseq_cs Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` mathieu.desnoyers
2019-04-24 15:24 ` [RFC PATCH for 5.2 03/10] rseq/selftests: Use __rseq_handled symbol to coexist with glibc Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` [RFC PATCH for 5.2 04/10] rseq/selftests: s390: use jg instruction for jumps outside of the asm Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` mathieu.desnoyers
2019-04-24 15:24 ` [RFC PATCH for 5.2 05/10] rseq/selftests: x86: use ud1 instruction as RSEQ_SIG opcode Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` mathieu.desnoyers
2019-04-24 15:24 ` [RFC PATCH for 5.2 06/10] rseq/selftests: s390: use trap4 for RSEQ_SIG Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` [RFC PATCH for 5.2 07/10] rseq/selftests: arm: use udf instruction " Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` Mathieu Desnoyers
2019-04-24 15:24 ` mathieu.desnoyers
2019-04-24 15:25 ` [RFC PATCH for 5.2 08/10] rseq/selftests: aarch64 code signature: handle big-endian environment Mathieu Desnoyers
2019-04-24 15:25 ` Mathieu Desnoyers
2019-04-24 15:25 ` Mathieu Desnoyers
2019-04-24 15:25 ` mathieu.desnoyers
2019-04-24 16:40 ` Mark Rutland
2019-04-24 16:40 ` Mark Rutland
2019-04-24 16:40 ` Mark Rutland
2019-04-24 16:40 ` mark.rutland
2019-04-24 16:44 ` Will Deacon
2019-04-24 16:44 ` Will Deacon
2019-04-24 16:44 ` Will Deacon
2019-04-24 16:44 ` will.deacon
2019-04-24 16:45 ` Mark Rutland
2019-04-24 16:45 ` Mark Rutland
2019-04-24 16:45 ` Mark Rutland
2019-04-24 16:45 ` mark.rutland
2019-04-24 16:45 ` Will Deacon
2019-04-24 16:45 ` Will Deacon
2019-04-24 16:45 ` Will Deacon
2019-04-24 16:45 ` will.deacon
2019-04-24 16:51 ` Mark Rutland
2019-04-24 16:51 ` Mark Rutland
2019-04-24 16:51 ` Mark Rutland
2019-04-24 16:51 ` mark.rutland
2019-04-24 17:00 ` Mathieu Desnoyers
2019-04-24 17:00 ` Mathieu Desnoyers
2019-04-24 17:00 ` Mathieu Desnoyers
2019-04-24 17:00 ` mathieu.desnoyers
2019-04-24 17:02 ` Mathieu Desnoyers
2019-04-24 17:02 ` Mathieu Desnoyers
2019-04-24 17:02 ` Mathieu Desnoyers
2019-04-24 17:02 ` mathieu.desnoyers
2019-04-24 15:25 ` [RFC PATCH for 5.2 09/10] rseq/selftests: powerpc code signature: generate valid instructions Mathieu Desnoyers
2019-04-24 15:25 ` Mathieu Desnoyers
2019-04-24 15:25 ` Mathieu Desnoyers
2019-04-24 15:25 ` [RFC PATCH for 5.2 10/10] rseq/selftests: mips: use break instruction for RSEQ_SIG Mathieu Desnoyers
2019-04-24 15:25 ` Mathieu Desnoyers
2019-04-24 22:06 ` Paul Burton
2019-04-24 22:06 ` Paul Burton
2019-04-24 23:12 ` Mathieu Desnoyers
2019-04-24 23:12 ` Mathieu Desnoyers
2019-04-24 23:17 ` Paul Burton
2019-04-24 23:17 ` Paul Burton
2019-04-24 23:22 ` Mathieu Desnoyers [this message]
2019-04-24 23:22 ` Mathieu Desnoyers
2019-04-25 14:21 ` Mathieu Desnoyers
2019-04-25 14:21 ` Mathieu Desnoyers
2019-04-29 22:31 ` Paul Burton
2019-04-29 22:31 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2047127593.1305.1556148177478.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bmaurer@fb.com \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=davejwatson@fb.com \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=paul.burton@mips.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.