From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Dave Martin <dave.martin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linaro-dev@lists.linaro.org
Subject: RE: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL
Date: Wed, 8 Dec 2010 11:27:12 +0530 [thread overview]
Message-ID: <2080abb418a8d3c651dd41353ef59d25@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinPifchS23j5EdrhMBNNdtEfF_KmX=AE9tUiiL=@mail.gmail.com>
> -----Original Message-----
> From: Dave Martin [mailto:dave.martin@linaro.org]
> Sent: Tuesday, December 07, 2010 10:21 PM
> To: Santosh Shilimkar
> Cc: linux-arm-kernel@lists.infradead.org; Tony Lindgren; linux-
> omap@vger.kernel.org; linaro-dev@lists.linaro.org
> Subject: Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi()
> forCONFIG_THUMB2_KERNEL
>
> Hi,
>
> On Tue, Dec 7, 2010 at 6:28 AM, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
> > Dave,
> >> -----Original Message-----
> >> From: linaro-dev-bounces@lists.linaro.org [mailto:linaro-dev-
> >> bounces@lists.linaro.org] On Behalf Of Dave Martin
> >> Sent: Monday, December 06, 2010 11:06 PM
> >> To: linux-arm-kernel@lists.infradead.org
> >> Cc: Tony Lindgren; Dave Martin; linux-omap@vger.kernel.org; linaro-
> >> dev@lists.linaro.org
> >> Subject: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi()
> >> forCONFIG_THUMB2_KERNEL
> >>
> >> For the Thumb-2 case, the "wfi" mnemonic is used, since in this
> >> case the tools will necessarily be new enough to support it.
> >>
> >> Signed-off-by: Dave Martin <dave.martin@linaro.org>
> >> ---
> >> KernelVersion: 2.6.37-rc4
> >
> > The choice of opcode instead of instruction here was not because
> > of toolchain. The problem was it breaks multi-omap build where
> > ARMv6 and ARMv7 are build together.
> >
> > For this reason I NAK this patch.
>
> You can't built a kernel for pre-v7 platforms with
> CONFIG_THUMB2_KERNEL: the code can't run on those platforms because
> they don't support Thumb-2.
>
That's better.
> So anything inside #ifdef CONFIG_THUMB2_KERNEL can assume v7/Thumb-2
> capable (and hence reasonably new) tools.
>
> I'll follow up shortly with a patch to the generic ARM Kconfig to make
> this explicit, so that ARCH_OMAP2 and THUMB2_KERNEL can't accidentally
> be configured together.
>
sure
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL
Date: Wed, 8 Dec 2010 11:27:12 +0530 [thread overview]
Message-ID: <2080abb418a8d3c651dd41353ef59d25@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinPifchS23j5EdrhMBNNdtEfF_KmX=AE9tUiiL=@mail.gmail.com>
> -----Original Message-----
> From: Dave Martin [mailto:dave.martin at linaro.org]
> Sent: Tuesday, December 07, 2010 10:21 PM
> To: Santosh Shilimkar
> Cc: linux-arm-kernel at lists.infradead.org; Tony Lindgren; linux-
> omap at vger.kernel.org; linaro-dev at lists.linaro.org
> Subject: Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi()
> forCONFIG_THUMB2_KERNEL
>
> Hi,
>
> On Tue, Dec 7, 2010 at 6:28 AM, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
> > Dave,
> >> -----Original Message-----
> >> From: linaro-dev-bounces at lists.linaro.org [mailto:linaro-dev-
> >> bounces at lists.linaro.org] On Behalf Of Dave Martin
> >> Sent: Monday, December 06, 2010 11:06 PM
> >> To: linux-arm-kernel at lists.infradead.org
> >> Cc: Tony Lindgren; Dave Martin; linux-omap at vger.kernel.org; linaro-
> >> dev at lists.linaro.org
> >> Subject: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi()
> >> forCONFIG_THUMB2_KERNEL
> >>
> >> For the Thumb-2 case, the "wfi" mnemonic is used, since in this
> >> case the tools will necessarily be new enough to support it.
> >>
> >> Signed-off-by: Dave Martin <dave.martin@linaro.org>
> >> ---
> >> KernelVersion: 2.6.37-rc4
> >
> > The choice of opcode instead of instruction here was not because
> > of toolchain. The problem was it breaks multi-omap build where
> > ARMv6 and ARMv7 are build together.
> >
> > For this reason I NAK this patch.
>
> You can't built a kernel for pre-v7 platforms with
> CONFIG_THUMB2_KERNEL: the code can't run on those platforms because
> they don't support Thumb-2.
>
That's better.
> So anything inside #ifdef CONFIG_THUMB2_KERNEL can assume v7/Thumb-2
> capable (and hence reasonably new) tools.
>
> I'll follow up shortly with a patch to the generic ARM Kconfig to make
> this explicit, so that ARCH_OMAP2 and THUMB2_KERNEL can't accidentally
> be configured together.
>
sure
next prev parent reply other threads:[~2010-12-08 5:57 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 17:35 [PATCH v2 0/3] ARM: omap: Thumb-2 kernel compatibility fixes Dave Martin
2010-12-06 17:35 ` Dave Martin
2010-12-06 17:35 ` [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work with CONFIG_THUMB2_KERNEL Dave Martin
2010-12-06 17:35 ` Dave Martin
[not found] ` <1291656937-24992-2-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2010-12-06 18:17 ` Catalin Marinas
2010-12-06 18:17 ` Catalin Marinas
2010-12-06 18:41 ` Dave Martin
2010-12-06 18:41 ` Dave Martin
2010-12-07 6:31 ` [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work withCONFIG_THUMB2_KERNEL Santosh Shilimkar
2010-12-07 6:31 ` Santosh Shilimkar
2010-12-07 10:16 ` Dave Martin
2010-12-07 10:16 ` Dave Martin
2010-12-07 11:59 ` Jean Pihet
2010-12-07 11:59 ` Jean Pihet
2010-12-07 14:53 ` Dave Martin
2010-12-07 14:53 ` Dave Martin
2010-12-07 14:55 ` Dave Martin
2010-12-07 14:55 ` Dave Martin
[not found] ` <AANLkTin4oiDGqMJqjYO+5pCM4MffiGiTEKW5WxXx9gfg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-07 19:15 ` Nicolas Pitre
2010-12-07 19:15 ` Nicolas Pitre
2010-12-08 10:24 ` Dave Martin
2010-12-08 10:24 ` Dave Martin
[not found] ` <AANLkTikVHOgujYh+28TFJDQbHx=AXT_5354bTy9+FLVR-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-08 16:56 ` Nicolas Pitre
2010-12-08 16:56 ` Nicolas Pitre
[not found] ` <1291656937-24992-1-git-send-email-dave.martin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2010-12-06 17:35 ` [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL Dave Martin
2010-12-06 17:35 ` Dave Martin
2010-12-07 6:28 ` [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL Santosh Shilimkar
2010-12-07 6:28 ` Santosh Shilimkar
2010-12-07 16:50 ` Dave Martin
2010-12-07 16:50 ` Dave Martin
2010-12-07 19:29 ` Russell King - ARM Linux
2010-12-07 19:29 ` Russell King - ARM Linux
2010-12-08 11:40 ` Dave Martin
2010-12-08 11:40 ` Dave Martin
2010-12-08 5:57 ` Santosh Shilimkar [this message]
2010-12-08 5:57 ` Santosh Shilimkar
2010-12-08 5:59 ` Santosh Shilimkar
2010-12-08 5:59 ` Santosh Shilimkar
2010-12-08 10:40 ` Dave Martin
2010-12-08 10:40 ` Dave Martin
2010-12-08 10:45 ` Santosh Shilimkar
2010-12-08 10:45 ` Santosh Shilimkar
2010-12-08 11:05 ` Dave Martin
2010-12-08 11:05 ` Dave Martin
2010-12-08 11:10 ` Santosh Shilimkar
2010-12-08 11:10 ` Santosh Shilimkar
2010-12-08 11:25 ` Dave Martin
2010-12-08 11:25 ` Dave Martin
2010-12-06 17:35 ` [PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL Dave Martin
2010-12-06 17:35 ` Dave Martin
2010-12-07 6:29 ` [PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for correctlinkage " Santosh Shilimkar
2010-12-07 6:29 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2080abb418a8d3c651dd41353ef59d25@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=dave.martin@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.