From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: "Sneeker. Yeh" <Sneeker.Yeh-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org>
Cc: Sneeker Yeh <sneeker.yeh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Thomas Pugliese
<thomas.pugliese-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Mosberger <davidm-haPfTeumbwasTnJN9+BGXg@public.gmane.org>,
Peter Griffin
<peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Sylwester Nawrocki
<s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Yoshihiro Shimoda
<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux
Subject: Re: [PATCH 1/3] usb: host: f_usb20ho: add support for Fujitsu ehci/ohci USB 2.0 host controller
Date: Wed, 17 Dec 2014 16:44:29 +0100 [thread overview]
Message-ID: <2084132.xT3x4RUEre@wuerfel> (raw)
In-Reply-To: <830AC58E49A426478AC39824BC0FA915D8BB402BB7-BxlyW7DJwtfE0yrG4eIIn8GT06e9YD5CS4/B3AGzWvkvtab9mdV7tw@public.gmane.org>
On Wednesday 17 December 2014 23:33:02 Sneeker. Yeh wrote:
> >
> >No need for playing games with child devices, just see how the other drivers do
> >it.
>
> I am wondering if this is what you mentioned here? :
> Hcd21: f_usb20ho {
> compatible = "fujitsu,f_usb20ho";
> ...
> Ehci {
> compatible = "generic-ehci";
> reg = <>;
> }
> ohci {
> compatible = "generic-ohci";
> reg = <>;
> }
> }
> By doing that, I can just use of_platform_populate() to create platform device more gracefully,
> than using platform_device_xxx() those have been done in of_platform_populate().
> And also, managing register offset is totally done via dts description, not in the code.
What I mean is leaving out the fujitsu,f_usb20ho node entirely, just put the
two USB controllers on the bus directly and remove this driver.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Sneeker. Yeh" <Sneeker.Yeh@tw.fujitsu.com>
Cc: Sneeker Yeh <sneeker.yeh@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Grant Likely <grant.likely@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
Paul Bolle <pebolle@tiscali.nl>,
Hans de Goede <hdegoede@redhat.com>,
Thomas Pugliese <thomas.pugliese@gmail.com>,
David Mosberger <davidm@egauge.net>,
Peter Griffin <peter.griffin@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Andrew Bresticker <abrestic@chromium.org>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Andy Green <andy.green@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH 1/3] usb: host: f_usb20ho: add support for Fujitsu ehci/ohci USB 2.0 host controller
Date: Wed, 17 Dec 2014 16:44:29 +0100 [thread overview]
Message-ID: <2084132.xT3x4RUEre@wuerfel> (raw)
In-Reply-To: <830AC58E49A426478AC39824BC0FA915D8BB402BB7@fmpitwmsex01.fmpi.sea.css.fujitsu.com>
On Wednesday 17 December 2014 23:33:02 Sneeker. Yeh wrote:
> >
> >No need for playing games with child devices, just see how the other drivers do
> >it.
>
> I am wondering if this is what you mentioned here? :
> Hcd21: f_usb20ho {
> compatible = "fujitsu,f_usb20ho";
> ...
> Ehci {
> compatible = "generic-ehci";
> reg = <>;
> }
> ohci {
> compatible = "generic-ohci";
> reg = <>;
> }
> }
> By doing that, I can just use of_platform_populate() to create platform device more gracefully,
> than using platform_device_xxx() those have been done in of_platform_populate().
> And also, managing register offset is totally done via dts description, not in the code.
What I mean is leaving out the fujitsu,f_usb20ho node entirely, just put the
two USB controllers on the bus directly and remove this driver.
Arnd
next prev parent reply other threads:[~2014-12-17 15:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 2:10 [PATCH 0/3] Add support for Fujitsu USB host controller Sneeker Yeh
2014-12-16 2:10 ` Sneeker Yeh
2014-12-16 2:10 ` [PATCH 1/3] usb: host: f_usb20ho: add support for Fujitsu ehci/ohci USB 2.0 " Sneeker Yeh
2014-12-16 2:10 ` Sneeker Yeh
2014-12-16 9:06 ` Arnd Bergmann
2014-12-16 9:06 ` Arnd Bergmann
2014-12-17 15:33 ` Sneeker.Yeh
[not found] ` <830AC58E49A426478AC39824BC0FA915D8BB402BB7-BxlyW7DJwtfE0yrG4eIIn8GT06e9YD5CS4/B3AGzWvkvtab9mdV7tw@public.gmane.org>
2014-12-17 15:44 ` Arnd Bergmann [this message]
2014-12-17 15:44 ` Arnd Bergmann
2014-12-17 15:46 ` Sneeker.Yeh
2014-12-16 2:10 ` [PATCH 2/3] usb: dwc3: add Fujitsu Specific Glue layer Sneeker Yeh
2014-12-16 2:10 ` Sneeker Yeh
[not found] ` <1418695828-605-3-git-send-email-Sneeker.Yeh-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org>
2014-12-22 15:59 ` Felipe Balbi
2014-12-22 15:59 ` Felipe Balbi
2014-12-28 17:52 ` Sneeker Yeh
2014-12-29 16:14 ` Felipe Balbi
2014-12-29 16:14 ` Felipe Balbi
2015-01-04 13:16 ` Sneeker Yeh
2015-01-05 15:52 ` Felipe Balbi
2015-01-05 15:52 ` Felipe Balbi
[not found] ` <CAJ1gpc0uniw3F3O9nxTLHp9M2boxrOACYDB=fgruhLOLdqg9yA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-30 10:12 ` Arnd Bergmann
2014-12-30 10:12 ` Arnd Bergmann
2015-01-03 1:21 ` Felipe Balbi
2015-01-03 1:21 ` Felipe Balbi
2015-01-05 15:28 ` Arnd Bergmann
2015-01-05 15:28 ` Arnd Bergmann
2015-01-05 15:50 ` Felipe Balbi
2015-01-05 15:50 ` Felipe Balbi
2015-01-04 14:32 ` Sneeker Yeh
2014-12-16 2:10 ` [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core Sneeker Yeh
2014-12-16 2:10 ` Sneeker Yeh
2014-12-22 15:37 ` Felipe Balbi
2014-12-22 15:37 ` Felipe Balbi
2014-12-29 6:41 ` Sneeker Yeh
2014-12-29 8:07 ` Sneeker Yeh
[not found] ` <CAJ1gpc3-Wjtm54WOhO6RXjZft9BMngzyYC0-S-XnTacV-qKgMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-29 16:06 ` Felipe Balbi
2014-12-29 16:06 ` Felipe Balbi
2015-01-04 12:55 ` Sneeker Yeh
[not found] ` <CAJ1gpc0Uu4vS2iA_o_W5NaE_QBWDYFZJio7yKvhpaR5f=qWcGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-05 17:09 ` Felipe Balbi
2015-01-05 17:09 ` Felipe Balbi
2015-01-11 15:19 ` Sneeker Yeh
2015-01-12 17:20 ` Felipe Balbi
2015-01-12 17:20 ` Felipe Balbi
2015-01-12 17:29 ` Paul Bolle
2015-01-12 17:29 ` Paul Bolle
2015-01-12 17:50 ` Felipe Balbi
2015-01-12 17:50 ` Felipe Balbi
2015-01-14 7:08 ` Sneeker Yeh
2015-01-14 17:02 ` Felipe Balbi
2015-01-14 17:02 ` Felipe Balbi
2015-01-17 10:52 ` Sneeker Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2084132.xT3x4RUEre@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=Sneeker.Yeh-l16TxrwUIHTQFUHtdCDX3A@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=davidm-haPfTeumbwasTnJN9+BGXg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
--cc=peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=sneeker.yeh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=thomas.pugliese-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.