Re: [PATCH net-next 14/15] batman-adv: tt: don't uncount never committed clients on pending purge

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831135117.574836-1-sw%40simonwunderlich.de?part=14

> > diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
> > index a870d9a97e32..794692170b61 100644
> > --- a/net/batman-adv/translation-table.c
> > +++ b/net/batman-adv/translation-table.c
> 
> [ ... ]
> 
> > @@ -4019,8 +4023,13 @@ static void batadv_tt_local_purge_pending_clients(struct batadv_priv *bat_priv)
> >  					   tt_common->addr,
> >  					   batadv_print_vid(tt_common->vid));
> >  
> > -				batadv_tt_local_size_dec(bat_priv, tt_common->vid);
> >  				hlist_del_rcu(&tt_common->hash_entry);
> > +
> > +				/* An entry which still carries BATADV_TT_CLIENT_NEW was
> > +				 * never counted and must not be uncounted here.
> > +				 */
> > +				if (!(tt_common->flags & BATADV_TT_CLIENT_NEW))
> > +					batadv_tt_local_size_dec(bat_priv, tt_common->vid);
> >  			}
> 
> Discovered by: gpt-5-6-sol, opus-5, sonnet-5 · Missed by: sashiko-gemini
> Should this carry a Fixes: tag and a Cc: stable hint?


I am not allowed to add Fixes: lines for patches targeting net-next. And this 
is not suitable for net or stable backports. See
https://lore.kernel.org/all/7d73cd74-b040-4a3d-9d78-4ad8fc0a01f4@redhat.com/

Regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]