All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: boris.brezillon@free-electrons.com, dwmw2@infradead.org,
	computersforpeace@gmail.com, marek.vasut@gmail.com,
	cyrille.pitchen@wedev4u.fr, maximlevitsky@gmail.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	ezequiel@vanguardiasur.com.ar, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro
Date: Thu, 22 Feb 2018 15:30:09 +0100	[thread overview]
Message-ID: <2093598.TLbMltDcSo@blindfold> (raw)
In-Reply-To: <1519305014-2547-1-git-send-email-shreeya.patel23498@gmail.com>

Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel:
> @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct mtd_info
> *mtd) break;
>  	}
>  	doc->chips_per_floor = i;
> -	printk(KERN_DEBUG "Detected %d chips per floor.\n", i);
> +	pr_debug("Detected %d chips per floor.\n", i);

<bike-shedding>

You are aware of the fact that printk(KERN_DEBUG and pr_debug() are not 
equivalent?
Not a big deal, just want to make sure that you understand what you are doing. 
:-)

</bike-shedding>

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: boris.brezillon@free-electrons.com, dwmw2@infradead.org,
	computersforpeace@gmail.com, marek.vasut@gmail.com,
	cyrille.pitchen@wedev4u.fr, maximlevitsky@gmail.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	ezequiel@vanguardiasur.com.ar, outreachy-kernel@googlegroups.com
Subject: [Outreachy kernel] Re: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro
Date: Thu, 22 Feb 2018 15:30:09 +0100	[thread overview]
Message-ID: <2093598.TLbMltDcSo@blindfold> (raw)
In-Reply-To: <1519305014-2547-1-git-send-email-shreeya.patel23498@gmail.com>

Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel:
> @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct mtd_info
> *mtd) break;
>  	}
>  	doc->chips_per_floor = i;
> -	printk(KERN_DEBUG "Detected %d chips per floor.\n", i);
> +	pr_debug("Detected %d chips per floor.\n", i);

<bike-shedding>

You are aware of the fact that printk(KERN_DEBUG and pr_debug() are not 
equivalent?
Not a big deal, just want to make sure that you understand what you are doing. 
:-)

</bike-shedding>

Thanks,
//richard

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
To post to this group, send email to outreachy-kernel@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2093598.TLbMltDcSo%40blindfold.
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2018-02-22 14:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 13:10 [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro Shreeya Patel
2018-02-22 13:10 ` [Outreachy kernel] " Shreeya Patel
2018-02-22 13:13 ` Shreeya Patel
2018-02-22 13:13   ` [Outreachy kernel] " Shreeya Patel
2018-02-22 14:30 ` Richard Weinberger [this message]
2018-02-22 14:30   ` Richard Weinberger
2018-02-22 14:45   ` Shreeya Patel
2018-02-22 14:45     ` [Outreachy kernel] " Shreeya Patel
2018-02-22 14:51     ` Boris Brezillon
2018-02-22 14:51       ` [Outreachy kernel] " Boris Brezillon
2018-02-22 15:25     ` Boris Brezillon
2018-02-22 15:25       ` [Outreachy kernel] " Boris Brezillon
2018-02-22 14:45 ` Boris Brezillon
2018-02-22 14:45   ` [Outreachy kernel] " Boris Brezillon
2018-02-22 14:57 ` Boris Brezillon
2018-02-22 14:57   ` [Outreachy kernel] " Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2093598.TLbMltDcSo@blindfold \
    --to=richard@nod.at \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=maximlevitsky@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shreeya.patel23498@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.