All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Xu <peterx@redhat.com>, Sven Schnelle <svens@linux.ibm.com>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests
Date: Tue, 16 Apr 2024 14:02:22 +0200	[thread overview]
Message-ID: <20d1d8c5-70e9-4b00-965b-918f275cfae7@linux.ibm.com> (raw)
In-Reply-To: <Zh4cqZkuPR9V1t1o@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>



Am 16.04.24 um 08:37 schrieb Alexander Gordeev:

>> We could piggy-back on vm_fault_to_errno(). We could use
>> vm_fault_to_errno(rc, FOLL_HWPOISON), and only continue (retry) if the rc is 0 or
>> -EFAULT, otherwise fail with the returned error.
>>
>> But I'd do that as a follow up, and also use it in break_ksm() in the same fashion.
> 
> @Christian, do you agree with this suggestion?

I would need to look into that more closely to give a proper answer. In general I am ok
with this but I prefer to have more eyes on that.
 From what I can tell we should cover all the normal cases with our CI as soon as it hits
next. But maybe we should try to create/change a selftest to trigger these error cases?

  parent reply	other threads:[~2024-04-16 12:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 16:14 [PATCH v3 0/2] s390/mm: shared zeropage + KVM fixes David Hildenbrand
2024-04-11 16:14 ` [PATCH v3 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed David Hildenbrand
2024-04-11 16:14 ` [PATCH v3 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests David Hildenbrand
2024-04-11 16:37   ` Alexander Gordeev
2024-04-11 21:09     ` David Hildenbrand
2024-04-15 11:49       ` Christian Borntraeger
2024-04-15 13:14         ` Alexander Gordeev
2024-04-15 18:24   ` Alexander Gordeev
2024-04-15 19:14     ` David Hildenbrand
2024-04-16  6:37       ` Alexander Gordeev
2024-04-16  7:05         ` David Hildenbrand
2024-04-16 12:02         ` Christian Borntraeger [this message]
2024-04-16 13:41           ` David Hildenbrand
2024-04-18 13:09             ` Christian Borntraeger
2024-04-11 21:28 ` [PATCH v3 0/2] s390/mm: shared zeropage + KVM fixes Andrew Morton
2024-04-11 21:56   ` David Hildenbrand
2024-04-12 13:25 ` Alexander Gordeev
2024-04-17 12:46 ` Alexander Gordeev
2024-04-17 12:47   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20d1d8c5-70e9-4b00-965b-918f275cfae7@linux.ibm.com \
    --to=borntraeger@linux.ibm.com \
    --cc=aarcange@redhat.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=peterx@redhat.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.